From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 2CD6B2B9E for ; Tue, 5 Mar 2019 23:41:17 +0100 (CET) Received: by mail-wr1-f67.google.com with SMTP id w17so11232425wrn.12 for ; Tue, 05 Mar 2019 14:41:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=fswBBLSHMovm2jMWwa32damlgVWVoa+buHCSCr+FomQ=; b=aEIwxRbHNeuY4XiGLPa5+pzgHRNeSORvSqaayvtwE+bXthazJhJlEp56q10v3Y4GmL sd1w0+WBVYP6G8CnO3d9rTGyXEmUulQbwr5lmtsn3jXpiM69wtTGLtmKFBDNs9BXrtqF iZMWriJRoGu0CP/VFXwNnd8q/CUff7QELMfJLlRIB/UzYN0zaOfgf2picN26Jgdqb3Pw P1Q4kIqgq+MQFn1xMPebWjh2VnvnKDiIdxWV29J3pxWmlTb0lvd1VQqt6h6tXYLZcwI6 SJysj1ahjT3AYaMVjXalosOH/LdSlsJcDC8O/Buz5a56bJZEFg/TaGNQjsRYci2CkUl5 Shyw== X-Gm-Message-State: APjAAAWw20vOEVowYRk5l4IRK18WDkcDa2iNtstimmX6HwsKID69+s61 1MvMsiVsRBT1RIqd34rDpMC0bjxJ X-Google-Smtp-Source: APXvYqwk48HhpCkLSFQ3qfkLks75b/Hw4OqoOCk4VysDI6Ji3AZg57Bd54rxSiMVSQY5TW/JgeQktA== X-Received: by 2002:a5d:51cf:: with SMTP id n15mr782062wrv.274.1551825676595; Tue, 05 Mar 2019 14:41:16 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id 62sm11145102wra.46.2019.03.05.14.41.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Mar 2019 14:41:15 -0800 (PST) Message-ID: <130a4780434ea30138a7c98f5689da143c73a8a1.camel@debian.org> From: Luca Boccassi To: Rastislav Cernay , dev@dpdk.org Date: Tue, 05 Mar 2019 22:41:14 +0000 In-Reply-To: <1551451054-111249-1-git-send-email-cernay@netcope.com> References: <1551185824-5501-2-git-send-email-cernay@netcope.com> <1551451054-111249-1-git-send-email-cernay@netcope.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] net/nfb: new netcope driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Mar 2019 22:41:17 -0000 On Fri, 2019-03-01 at 15:37 +0100, Rastislav Cernay wrote: > From: Rastislav Cernay >=20 > Added new net driver for Netcope nfb cards >=20 > Signed-off-by: Rastislav Cernay > --- > v2: remove unnecessary cast > remove unnecessary zeroing > move declaration to not mix with code > restore skeleton example > v3: add release notes > add doc to doc index > add architecture limits to doc > edit features list > add .map file > change link to dependecies to official vendor site > move declarations out of code > remove false comments (rte_errno is set) > comments to c89 style > remove log from main rx loop > remove redundant code > MAINTAINERS | 7 + > config/common_base | 4 + > devtools/test-build.sh | 1 + > doc/guides/nics/features/nfb.ini | 18 + > doc/guides/nics/index.rst | 1 + > doc/guides/nics/nfb.rst | 143 ++++++++ > doc/guides/rel_notes/release_19_02.rst | 5 + > drivers/net/Makefile | 1 + > drivers/net/meson.build | 1 + > drivers/net/nfb/Makefile | 41 +++ > drivers/net/nfb/meson.build | 9 + > drivers/net/nfb/nfb.h | 50 +++ > drivers/net/nfb/nfb_ethdev.c | 589 > ++++++++++++++++++++++++++++++++ > drivers/net/nfb/nfb_rx.c | 127 +++++++ > drivers/net/nfb/nfb_rx.h | 213 ++++++++++++ > drivers/net/nfb/nfb_rxmode.c | 100 ++++++ > drivers/net/nfb/nfb_rxmode.h | 78 +++++ > drivers/net/nfb/nfb_stats.c | 78 +++++ > drivers/net/nfb/nfb_stats.h | 48 +++ > drivers/net/nfb/nfb_tx.c | 113 ++++++ > drivers/net/nfb/nfb_tx.h | 204 +++++++++++ > drivers/net/nfb/rte_nfb_pmd_version.map | 4 + > mk/rte.app.mk | 1 + > 23 files changed, 1836 insertions(+) > create mode 100644 doc/guides/nics/features/nfb.ini > create mode 100644 doc/guides/nics/nfb.rst > create mode 100644 drivers/net/nfb/Makefile > create mode 100644 drivers/net/nfb/meson.build > create mode 100644 drivers/net/nfb/nfb.h > create mode 100644 drivers/net/nfb/nfb_ethdev.c > create mode 100644 drivers/net/nfb/nfb_rx.c > create mode 100644 drivers/net/nfb/nfb_rx.h > create mode 100644 drivers/net/nfb/nfb_rxmode.c > create mode 100644 drivers/net/nfb/nfb_rxmode.h > create mode 100644 drivers/net/nfb/nfb_stats.c > create mode 100644 drivers/net/nfb/nfb_stats.h > create mode 100644 drivers/net/nfb/nfb_tx.c > create mode 100644 drivers/net/nfb/nfb_tx.h > create mode 100644 drivers/net/nfb/rte_nfb_pmd_version.map >=20 <...> > diff --git a/drivers/net/nfb/meson.build > b/drivers/net/nfb/meson.build > new file mode 100644 > index 0000000..d7dccba > --- /dev/null > +++ b/drivers/net/nfb/meson.build > @@ -0,0 +1,9 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(c) 2018 Cesnet > +# Copyright(c) 2018 Netcope Technologies, a.s. > +# All rights reserved. > + > +dep =3D cc.find_library('nfb', required: true) This unconditionally breaks the build, please look at how drivers/net/pcap/meson.build checks for dependencies for an example (I assume libnfd does not provide a pkg-config file?) > +build =3D dep.found() > +ext_deps +=3D dep > +sources =3D files('nfb_rx.c', 'nfb_tx.c', 'nfb_stats.c', > 'nfb_ethdev.c', 'nfb_rxmode.c') <...> > diff --git a/drivers/net/nfb/rte_nfb_pmd_version.map > b/drivers/net/nfb/rte_nfb_pmd_version.map > new file mode 100644 > index 0000000..97fd251 > --- /dev/null > +++ b/drivers/net/nfb/rte_nfb_pmd_version.map > @@ -0,0 +1,4 @@ > +DPDK_19.02 { > + > + local: *; > +}; These are all new symbols so they should be marked as experimental, please see doc/guides/contributing/versioning.rst > diff --git a/mk/rte.app.mk b/mk/rte.app.mk > index 8a4f0f4..32e88b5 100644 > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -196,6 +196,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SOFTNIC) +=3D > -lrte_pmd_softnic > endif > _LDLIBS-$(CONFIG_RTE_LIBRTE_SFC_EFX_PMD) +=3D -lrte_pmd_sfc_efx > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SZEDATA2) +=3D -lrte_pmd_szedata2 > -lsze2 > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_NFB) +=3D -lrte_pmd_nfb -lnfb > -lfdt Why is -lfdt added? I don't see any symbols from libfdt used in the rest of the patch? > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_TAP) +=3D -lrte_pmd_tap > _LDLIBS-$(CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD) +=3D > -lrte_pmd_thunderx_nicvf > _LDLIBS-$(CONFIG_RTE_LIBRTE_VDEV_NETVSC_PMD) +=3D > -lrte_pmd_vdev_netvsc --=20 Kind regards, Luca Boccassi