From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-f169.google.com (mail-wj0-f169.google.com [209.85.210.169]) by dpdk.org (Postfix) with ESMTP id 096012B96 for ; Wed, 7 Dec 2016 09:33:20 +0100 (CET) Received: by mail-wj0-f169.google.com with SMTP id xy5so352998191wjc.0 for ; Wed, 07 Dec 2016 00:33:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=Bk7RFUyv8+/LOUYouw6Q8NMXP2Kif3vBWMgBmff6YTg=; b=Ab3kdKRsxgwPuhcTkrnnAQNoMBwIHoS2pzys35ahck9D9caP4bUalqwMAKOwhyK72B YxYdYjZKHalOlT7VGlQdTpknMKfuCtKTa0tWW88/Z5YP32MvhjAV6IhhKrKwseL736Gr 8lT91mzpRw80bZfWGgsVSxvpl5DQd31D8nVu0Z+qqg7K+B2XGQ8Y7zbx99W/jPiIM2m4 rm2xcfYgJ2pZO5SBvTXiRYbRSpVSjkFdDsiYs127S3tEkzCgANj2tyvqUIBoa1MHAyWZ xOULLLSIa51pjC2MjdtwaK67TDykwNTqiRdPdoeCqTNMlhduMiC5WOZg65P+Z3QvCiId NC2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=Bk7RFUyv8+/LOUYouw6Q8NMXP2Kif3vBWMgBmff6YTg=; b=eSOXao3D0zkG+K3PAYq485c+NortWEvvK753RPOL8DN69LO5ZJIBqIFk1tmfc6zAjM LgMpmK+RmSFCwxsvZ32EO+VyojHnGXo8Zn/LWSs1BTsHgqrw3IAY0rtpICQBciAesQzE WtJW9+K6ONydL6gMdEGIQzrQflRnd+tL1Bunm3LOcSApt4kmrq7CQefYtndVWqKoYQjA M9V8JzRy8k7hP5/0gmAi3lOfwFMwQtQuZ7lreUhnyvGP4mWBSn4Jrlnkc57Ycs0nbA6y Wv8onF2dQYJdj2LH1XEFVObfZvC+MvVwx5s/mF0G2ygRvm2Jb4I15mtax7cXlskXOnqd kCNw== X-Gm-Message-State: AKaTC00Xyk0xnaF31Q5Dfqw5wlOrrwdI1VwNYuUppTvanyIVG9QzBRYv4bXYDLPgEAoEEGXg X-Received: by 10.194.37.6 with SMTP id u6mr66232747wjj.20.1481099599853; Wed, 07 Dec 2016 00:33:19 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id bj1sm30075790wjc.17.2016.12.07.00.33.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Dec 2016 00:33:18 -0800 (PST) From: Thomas Monjalon To: Akhil Goyal Cc: dev@dpdk.org, declan.doherty@intel.com, pablo.de.lara.guarch@intel.com, Hemant Agrawal , Horia =?utf-8?B?R2VhbnTEgw==?= Date: Wed, 07 Dec 2016 09:33:17 +0100 Message-ID: <13107823.ZnI407z9cY@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <20161205125540.6419-1-akhil.goyal@nxp.com> <5589636.gHNnFhEcxp@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/8] drivers/common/dpaa2: Run time assembler for Descriptor formation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Dec 2016 08:33:21 -0000 2016-12-07 06:24, Akhil Goyal: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > 2016-12-05 18:25, Akhil Goyal: > > FLib is a library which helps in making the descriptors which is > > understood by NXP's SEC hardware. > > This patch provides header files for command words which can be used > > for descritptor formation. > > It seems this code is old. Does it exist as a standalone library somewhere? > Where was it hosted before duplicating it in DPDK? > > Why do you want to have a common directory drivers/common/dpaa2/flib instead of a sub-directory in the crypto driver? > > [Akhil] This is not really a library. This is a set of header files which is required for compilation. We have 2 other cypto drivers (for different platforms viz: Non-DPAA and DPAA1_QORIQ) which uses the same flib. So we put it in common directory. We plan to send patches for other drivers in the upcoming releases. Please Akhil, could you answer to the three questions?