* [dpdk-dev] [PATCH] examples/power: fix intel pstate power manager
@ 2019-01-08 15:25 David Hunt
2019-01-14 23:07 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: David Hunt @ 2019-01-08 15:25 UTC (permalink / raw)
To: dev; +Cc: david.hunt, liang.j.ma
The vm_power_manager starts by setting the environment to acpi
using rte_power_set_env(PM_ENV_ACPI_CPUFREQ). This causes a problem
starting vm_power_manager when the system is using the intel_pstate
driver. The env should be set to none, or not called at all, because
the library now auto-detects the environment to be either acpi or
intel_pstate. This patch sets the environment to none so that the
library can successfully auto-detect.
Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility")
Signed-off-by: David Hunt <david.hunt@intel.com>
---
examples/vm_power_manager/power_manager.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/vm_power_manager/power_manager.c b/examples/vm_power_manager/power_manager.c
index 21dc3a727..aef832644 100644
--- a/examples/vm_power_manager/power_manager.c
+++ b/examples/vm_power_manager/power_manager.c
@@ -83,7 +83,7 @@ power_manager_init(void)
struct core_info *ci;
unsigned int max_core_num;
- rte_power_set_env(PM_ENV_ACPI_CPUFREQ);
+ rte_power_set_env(PM_ENV_NOT_SET);
ci = get_core_info();
if (!ci) {
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dpdk-dev] [PATCH] examples/power: fix intel pstate power manager
2019-01-08 15:25 [dpdk-dev] [PATCH] examples/power: fix intel pstate power manager David Hunt
@ 2019-01-14 23:07 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2019-01-14 23:07 UTC (permalink / raw)
To: David Hunt; +Cc: dev, liang.j.ma
08/01/2019 16:25, David Hunt:
> The vm_power_manager starts by setting the environment to acpi
> using rte_power_set_env(PM_ENV_ACPI_CPUFREQ). This causes a problem
> starting vm_power_manager when the system is using the intel_pstate
> driver. The env should be set to none, or not called at all, because
> the library now auto-detects the environment to be either acpi or
> intel_pstate. This patch sets the environment to none so that the
> library can successfully auto-detect.
>
> Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility")
>
> Signed-off-by: David Hunt <david.hunt@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-14 23:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-08 15:25 [dpdk-dev] [PATCH] examples/power: fix intel pstate power manager David Hunt
2019-01-14 23:07 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).