From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
Vipin Varghese <vipin.varghese@amd.com>,
Alaa Duhaidy <alaaduh@nvidia.com>,
Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk>
Subject: Re: [PATCH v3] build/x86: fix support for older compilers
Date: Thu, 03 Jul 2025 15:23:02 +0200 [thread overview]
Message-ID: <13147413.04QRnsoN9i@thomas> (raw)
In-Reply-To: <20250703102123.3708401-2-bruce.richardson@intel.com>
03/07/2025 12:21, Bruce Richardson:
> Some older compilers e.g. gcc 8.5, do not support overriding
> -march=native with another architecture, leading to build warnings such
> as reported in Bugzilla (link below). Add a check for that case, and
> explicitly add the avx512 flags if necessary.
>
> Note: it appears that it is only the "native" flag that isn't
> overridden, which makes the issue hard to reproduce e.g. using
> godbolt.org, or on a modern machine. For example, testing with gcc 8.5
> on a haswell machine, using 'native' vs explicit 'haswell':
>
> gcc -march=native -march=skylake-avx512 -dM -E - < /dev/null | grep AVX512 | wc -l
> 0
>
> gcc -march=haswell -march=skylake-avx512 -dM -E - < /dev/null | grep AVX512 | wc -l
> 5
>
> Bugzilla ID: 1736
> Fixes: e361ae3f59d3 ("build: reduce use of AVX compiler flags")
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks.
prev parent reply other threads:[~2025-07-03 13:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-02 15:51 [PATCH] " Bruce Richardson
2025-07-02 15:53 ` Bruce Richardson
2025-07-02 16:00 ` [PATCH v2] " Bruce Richardson
2025-07-02 18:22 ` Stephen Hemminger
2025-07-03 8:00 ` Bruce Richardson
2025-07-03 8:12 ` David Marchand
2025-07-03 16:10 ` Stephen Hemminger
2025-07-03 10:21 ` [PATCH v3] " Bruce Richardson
2025-07-03 13:23 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13147413.04QRnsoN9i@thomas \
--to=thomas@monjalon.net \
--cc=14pwcse1224@uetpeshawar.edu.pk \
--cc=alaaduh@nvidia.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=vipin.varghese@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).