DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>,
	Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com,
	Somnath Kotur <somnath.kotur@broadcom.com>
Subject: Re: [dpdk-dev] [PATCH v2 4/4] net/bnxt: fix vfrep add when VF interface is down
Date: Wed, 05 Aug 2020 22:37:01 +0200
Message-ID: <13231762.CZJP8ZC4vz@thomas> (raw)
In-Reply-To: <20200731172302.5292-5-ajit.khaparde@broadcom.com>

31/07/2020 19:23, Ajit Khaparde:
> From: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>
> 
> While adding vfrep port to OVS bridge, vnic & svif information of

You should avoid justifying use cases with external applications.

> vfrep's endpoint(VF) would be needed to program default flow rules.

vfrep is not a well known word. Please use "VF representor".

> However, if the endpoint interface is down when vfrep port is added,
> firmware will return invalid vnic & svif information.
> 
> This patch fixes the problem by registering to DEFAULT_VNIC_CHANGE
> async event and once the async event is received, use the endpoint
> information(VF's fid) to fetch it's vnic & svif information and
> program the default flow rules.
> 
> Fixes: 322bd6e70272 ("net/bnxt: add port representor infrastructure")

It looks to be a patch adding the support of a special case:
configuring VF representor while VF is down.
I don't think it is a fix.


> Signed-off-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
> ---
>  drivers/net/bnxt/bnxt.h        | 21 ++++++++++
>  drivers/net/bnxt/bnxt_cpr.c    | 51 +++++++++++++++++++++++++
>  drivers/net/bnxt/bnxt_ethdev.c | 12 +++++-
>  drivers/net/bnxt/bnxt_hwrm.c   |  4 ++
>  drivers/net/bnxt/bnxt_hwrm.h   |  2 +
>  drivers/net/bnxt/bnxt_reps.c   | 70 +++++++++++++++++++++++++---------
>  6 files changed, 140 insertions(+), 20 deletions(-)

This is quite a big change.

This patchset has been deferred (not pulled in next-net) in -rc3.
I confirm it is postponed to DPDK 20.11.

In general, the idea is to have limits to avoid last minute rushes.
Thanks for understanding.



  reply	other threads:[~2020-08-05 20:37 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-29 14:03 [dpdk-dev] [PATCH 0/4] bnxt patches Somnath Kotur
2020-07-29 14:03 ` [dpdk-dev] [PATCH 1/4] net/bnxt: configure loopback parif for full offload egress flows Somnath Kotur
2020-07-29 21:23 ` [dpdk-dev] [PATCH 0/4] bnxt patches Ajit Khaparde
2020-07-31 17:22   ` [dpdk-dev] [PATCH v2 " Ajit Khaparde
2020-07-31 17:22     ` [dpdk-dev] [PATCH v2 1/4] net/bnxt: fix loopback parif for egress flows Ajit Khaparde
2020-08-05 20:29       ` Thomas Monjalon
2020-07-31 17:23     ` [dpdk-dev] [PATCH v2 2/4] net/bnxt: fix lookup for default parif action record Ajit Khaparde
2020-08-05 20:28       ` Thomas Monjalon
2020-08-06  1:27         ` Kishore Padmanabha
2020-07-31 17:23     ` [dpdk-dev] [PATCH v2 3/4] net/bnxt: fix cleanup and check for ulp context alloc Ajit Khaparde
2020-08-05 20:27       ` Thomas Monjalon
2020-07-31 17:23     ` [dpdk-dev] [PATCH v2 4/4] net/bnxt: fix vfrep add when VF interface is down Ajit Khaparde
2020-08-05 20:37       ` Thomas Monjalon [this message]
2020-09-02  5:31     ` [dpdk-dev] [PATCH v3 0/4] bnxt patches Ajit Khaparde
2020-09-02  5:31       ` [dpdk-dev] [PATCH v3 1/4] net/bnxt: configure loopback parif for egress flows Ajit Khaparde
2020-09-02  5:31       ` [dpdk-dev] [PATCH v3 2/4] net/bnxt: lookup default action record parif Ajit Khaparde
2020-09-02  5:31       ` [dpdk-dev] [PATCH v3 3/4] net/bnxt: cleanups and checks ULP context allocation Ajit Khaparde
2020-09-02  5:31       ` [dpdk-dev] [PATCH v3 4/4] net/bnxt: fix VF representor port add Ajit Khaparde
2020-09-02 19:16       ` [dpdk-dev] [PATCH v3 0/4] bnxt patches Ajit Khaparde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13231762.CZJP8ZC4vz@thomas \
    --to=thomas@monjalon.net \
    --cc=ajit.khaparde@broadcom.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=somnath.kotur@broadcom.com \
    --cc=venkatkumar.duvvuru@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git