From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 636DDA054F; Tue, 16 Mar 2021 00:14:09 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 10418160820; Tue, 16 Mar 2021 00:14:09 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 8858540042 for ; Tue, 16 Mar 2021 00:14:08 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id E173C5C0195; Mon, 15 Mar 2021 19:14:07 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 15 Mar 2021 19:14:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= M+vSkdC5IxqCp6z5Q6p4fDAGe04Misn8VEWO/npU/x4=; b=mRAZ/hl1XGukKUFl 9TvuRcfAZTQKc9D43bDCtDDxaZP4KRP1Tgozf9LBT5OnFtF8pn2mlOmCTd/E+NDg UtH3JwS4Ctx+sgbQpBB3AHF9d02r6GjZN3TwWSL3VXBUcjA4Y4suVS29N3rhPMzy KmzB4dIv3CA+ZwSDMKoj3isBLOG5zeh1p3jf8xW8pE/FjWLZXYawRw1l1S6fhXEQ XCx/KgEaIG7DNwLMyZzRKcJdSyn3+VsudsTl6YfV8kB5GuajeSjIxOfUDXze5iKy 8Kd80mphHGXyvXMZO/8y0FbL2oRFMjib2T9QSk+rmlFsha81Tv7VmlnICxyb/yG2 wNnBwA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=M+vSkdC5IxqCp6z5Q6p4fDAGe04Misn8VEWO/npU/ x4=; b=Wedgkj42xKKXsWQq95WQod6mmzrynlo1JSoUXhIfM2SAJgetV0NJaA+Bd izQei9IknLKTLE0doH6qfnfS67G3eW6uGAEh8QhaOOPW37Y76aGq/8y6UrcKKrAR T3/FGubUzn+MIBk40AVNEhoTuMJfeU4cR/2Qim9iERnf7NSVvYpSGUmqf7YGy2SY +xzdjyR5KBxMUWjIIEH9CTR9/5cJ6O8d8sRRUob4emipTKcbYVNSi7ANhs1gmkal jp1QzirfHDME+D4df8E4nT58ZXnuyxnB0gMRAf/u7z0E7s6gCb3sBi4FupgwXN0I iOXMmkgzIyKeaHtYPEB4bVrtsomcA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudefuddgtdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B121E1080064; Mon, 15 Mar 2021 19:14:05 -0400 (EDT) From: Thomas Monjalon To: Tal Shnaiderman Cc: dev@dpdk.org, pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com, navasile@linux.microsoft.com, dmitrym@microsoft.com, david.marchand@redhat.com, anatoly.burakov@intel.com, vladimir.medvedkin@intel.com, mb@smartsharesystems.com Date: Tue, 16 Mar 2021 00:14:03 +0100 Message-ID: <13245764.PrGM1mO2OL@thomas> In-Reply-To: <20210310124856.8188-2-talshn@nvidia.com> References: <20210310120632.14464-2-talshn@nvidia.com> <20210310124856.8188-1-talshn@nvidia.com> <20210310124856.8188-2-talshn@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 1/2] eal: error number enhancement for thread TLS API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/03/2021 13:48, Tal Shnaiderman: > --- a/lib/librte_eal/include/rte_thread.h > +++ b/lib/librte_eal/include/rte_thread.h > @@ -59,7 +59,9 @@ void rte_thread_get_affinity(rte_cpuset_t *cpusetp); > * > * @return > * On success, zero. > - * On failure, a negative number. > + * On failure, a negative number and an error number is set in rte_errno. > + * rte_errno can be set to: ENOMEM - Memory allocation error. > + * ENOEXEC - Specific OS error. > */ > > __rte_experimental > @@ -73,7 +75,9 @@ int rte_thread_tls_key_create(rte_tls_key *key, void (*destructor)(void *)); > * > * @return > * On success, zero. > - * On failure, a negative number. > + * On failure, a negative number and an error number is set in rte_errno. > + * rte_errno can be set to: EINVAL - Invalid parameter passed. > + * ENOEXEC - Specific OS error. > */ > __rte_experimental > int rte_thread_tls_key_delete(rte_tls_key key); > @@ -88,7 +92,9 @@ int rte_thread_tls_key_delete(rte_tls_key key); > * > * @return > * On success, zero. > - * On failure, a negative number. > + * On failure, a negative number and an error number is set in rte_errno. > + * rte_errno can be set to: EINVAL - Invalid parameter passed. > + * ENOEXEC - Specific OS error. > */ > __rte_experimental > int rte_thread_tls_value_set(rte_tls_key key, const void *value); > @@ -102,6 +108,8 @@ int rte_thread_tls_value_set(rte_tls_key key, const void *value); > * @return > * On success, value data pointer (can also be NULL). > * On failure, NULL and an error number is set in rte_errno. > + * rte_errno can be set to: EINVAL - Invalid parameter passed. > + * ENOEXEC - Specific OS error. Shorter (and less confusing): "rte_errno can be:"