From: Thomas Monjalon <thomas@monjalon.net> To: Tasnim Bashar <tbashar@mellanox.com> Cc: dev@dpdk.org, harini.ramakrishnan@microsoft.com, pallavi.kadam@intel.com, ranjit.menon@intel.com, ocardona@microsoft.com, navasile@linux.microsoft.com, dmitry.kozliuk@gmail.com, talshn@mellanox.com, fady@mellanox.com, ophirmu@mellanox.com Subject: Re: [dpdk-dev] [PATCH v3] eal/windows: fix invalid thread handle Date: Mon, 15 Jun 2020 11:42:04 +0200 Message-ID: <13269652.10yzYP2DCA@thomas> (raw) In-Reply-To: <20200602020052.4540-1-tbashar@mellanox.com> 02/06/2020 04:00, Tasnim Bashar: > #define pthread_setaffinity_np(thread, size, cpuset) \ > - eal_set_thread_affinity_mask(thread, (unsigned long *) cpuset) > + eal_set_thread_affinity_mask(thread, cpuset) > #define pthread_getaffinity_np(thread, size, cpuset) \ > - eal_get_thread_affinity_mask(thread, (unsigned long *) cpuset) > + eal_get_thread_affinity_mask(thread, cpuset) > #define pthread_create(threadid, threadattr, threadfunc, args) \ > eal_create_thread(threadid, threadfunc, args) > > static inline int > -eal_set_thread_affinity_mask(pthread_t threadid, unsigned long *cpuset) > +eal_set_thread_affinity_mask(pthread_t threadid, rte_cpuset_t *cpuset) [...] > static inline int > -eal_get_thread_affinity_mask(pthread_t threadid, unsigned long *cpuset) > +eal_get_thread_affinity_mask(pthread_t threadid, rte_cpuset_t *cpuset) I don't understand the need for the #define. Why not naming the functions with the final pthread standard name?
next prev parent reply other threads:[~2020-06-15 9:42 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-22 0:11 [dpdk-dev] [PATCH] " Tasnim Bashar 2020-05-22 0:55 ` Dmitry Kozlyuk 2020-06-02 2:00 ` [dpdk-dev] [PATCH v3] " Tasnim Bashar 2020-06-11 14:35 ` Thomas Monjalon 2020-06-12 16:22 ` Tasnim Bashar 2020-06-12 21:33 ` Thomas Monjalon 2020-06-15 8:16 ` Thomas Monjalon 2020-06-16 18:53 ` Tasnim Bashar 2020-06-16 19:17 ` Thomas Monjalon 2020-06-16 19:59 ` Tasnim Bashar 2020-06-15 9:42 ` Thomas Monjalon [this message] 2020-06-16 19:00 ` Tasnim Bashar 2020-06-24 23:10 ` [dpdk-dev] [PATCH v4] eal/windows: fix " Tasnim Bashar 2020-06-25 0:38 ` Ranjit Menon 2020-06-25 19:11 ` Tasnim Bashar 2020-06-25 19:25 ` [dpdk-dev] [PATCH v5] " Tasnim Bashar 2020-06-29 23:09 ` Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=13269652.10yzYP2DCA@thomas \ --to=thomas@monjalon.net \ --cc=dev@dpdk.org \ --cc=dmitry.kozliuk@gmail.com \ --cc=fady@mellanox.com \ --cc=harini.ramakrishnan@microsoft.com \ --cc=navasile@linux.microsoft.com \ --cc=ocardona@microsoft.com \ --cc=ophirmu@mellanox.com \ --cc=pallavi.kadam@intel.com \ --cc=ranjit.menon@intel.com \ --cc=talshn@mellanox.com \ --cc=tbashar@mellanox.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git