* [dpdk-dev] [PATCH 1/2] app/test: fix clang 12 warning
@ 2021-04-20 13:09 Kevin Traynor
2021-04-20 13:09 ` [dpdk-dev] [PATCH 2/2] app/test: silence " Kevin Traynor
2021-04-20 13:21 ` [dpdk-dev] [PATCH v2 1/2] app/test: fix " Kevin Traynor
0 siblings, 2 replies; 5+ messages in thread
From: Kevin Traynor @ 2021-04-20 13:09 UTC (permalink / raw)
To: dev; +Cc: Kevin Traynor, Olivier Matz
clang 12 gives a warning about string size. In this case it looks like
it was unintentional to concatenate the strings. Separate with a comma.
$ clang --version
clang version 12.0.0 (Fedora 12.0.0-0.3.rc1.fc34)
[2557/2719]
Compiling C object app/test/dpdk-test.p/test_cmdline_ipaddr.c.o
../app/test/test_cmdline_ipaddr.c:259:3: warning:
suspicious concatenation of string literals in an array initialization;
did you mean to separate the elements with a comma?
[-Wstring-concatenation]
"random invalid text",
^
../app/test/test_cmdline_ipaddr.c:258:3: note:
place parentheses around the string literal to silence warning
"1234:1234:1234:1234:1234:1234:1234:1234:1234:1234:1234"
^
Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
---
app/test/test_cmdline_ipaddr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test/test_cmdline_ipaddr.c b/app/test/test_cmdline_ipaddr.c
index b3f50d80d2..2a1ee120fc 100644
--- a/app/test/test_cmdline_ipaddr.c
+++ b/app/test/test_cmdline_ipaddr.c
@@ -256,5 +256,5 @@ const char * ipaddr_invalid_strs[] = {
/* too long */
- "1234:1234:1234:1234:1234:1234:1234:1234:1234:1234:1234"
+ "1234:1234:1234:1234:1234:1234:1234:1234:1234:1234:1234",
"random invalid text",
"",
--
2.30.2
^ permalink raw reply [flat|nested] 5+ messages in thread* [dpdk-dev] [PATCH 2/2] app/test: silence clang 12 warning
2021-04-20 13:09 [dpdk-dev] [PATCH 1/2] app/test: fix clang 12 warning Kevin Traynor
@ 2021-04-20 13:09 ` Kevin Traynor
2021-04-20 13:21 ` [dpdk-dev] [PATCH v2 1/2] app/test: fix " Kevin Traynor
1 sibling, 0 replies; 5+ messages in thread
From: Kevin Traynor @ 2021-04-20 13:09 UTC (permalink / raw)
To: dev; +Cc: Kevin Traynor, Olivier Matz
clang 12 gives a warning about string size. In this case it is a long
string test. Add parentheses to indicate this.
$ clang --version
clang version 12.0.0 (Fedora 12.0.0-0.3.rc1.fc34)
[2556/2719]
Compiling C object app/test/dpdk-test.p/test_cmdline_num.c.o
../app/test/test_cmdline_num.c:204:5: warning:
suspicious concatenation of string literals in an array initialization;
did you mean to separate the elements with a comma?
[-Wstring-concatenation]
"1111000011110000111100001111000011110000111100001111000011110000",
^
../app/test/test_cmdline_num.c:203:3: note:
place parentheses around the string literal to silence warning
"0b1111000011110000111100001111000011110000111100001111000011110000"
^
Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
---
app/test/test_cmdline_num.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test/test_cmdline_num.c b/app/test/test_cmdline_num.c
index ec479cdb3a..9276de59bd 100644
--- a/app/test/test_cmdline_num.c
+++ b/app/test/test_cmdline_num.c
@@ -201,6 +201,6 @@ const char * num_invalid_strs[] = {
"-0b0111010101",
/* too long (128+ chars) */
- "0b1111000011110000111100001111000011110000111100001111000011110000"
- "1111000011110000111100001111000011110000111100001111000011110000",
+ ("0b1111000011110000111100001111000011110000111100001111000011110000"
+ "1111000011110000111100001111000011110000111100001111000011110000"),
"1E3",
"0A",
--
2.30.2
^ permalink raw reply [flat|nested] 5+ messages in thread* [dpdk-dev] [PATCH v2 1/2] app/test: fix clang 12 warning
2021-04-20 13:09 [dpdk-dev] [PATCH 1/2] app/test: fix clang 12 warning Kevin Traynor
2021-04-20 13:09 ` [dpdk-dev] [PATCH 2/2] app/test: silence " Kevin Traynor
@ 2021-04-20 13:21 ` Kevin Traynor
2021-04-20 13:21 ` [dpdk-dev] [PATCH v2 2/2] app/test: silence " Kevin Traynor
1 sibling, 1 reply; 5+ messages in thread
From: Kevin Traynor @ 2021-04-20 13:21 UTC (permalink / raw)
To: dev; +Cc: Kevin Traynor, Olivier Matz
clang 12 gives a warning about string concatenation in arrays.
In this case it looks like it was unintentional to concatenate
the strings. Separate with a comma.
$ clang --version
clang version 12.0.0 (Fedora 12.0.0-0.3.rc1.fc34)
[2557/2719]
Compiling C object app/test/dpdk-test.p/test_cmdline_ipaddr.c.o
../app/test/test_cmdline_ipaddr.c:259:3: warning:
suspicious concatenation of string literals in an array initialization;
did you mean to separate the elements with a comma?
[-Wstring-concatenation]
"random invalid text",
^
../app/test/test_cmdline_ipaddr.c:258:3: note:
place parentheses around the string literal to silence warning
"1234:1234:1234:1234:1234:1234:1234:1234:1234:1234:1234"
^
Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
---
v2: updated commit msg
---
app/test/test_cmdline_ipaddr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test/test_cmdline_ipaddr.c b/app/test/test_cmdline_ipaddr.c
index b3f50d80d2..2a1ee120fc 100644
--- a/app/test/test_cmdline_ipaddr.c
+++ b/app/test/test_cmdline_ipaddr.c
@@ -256,5 +256,5 @@ const char * ipaddr_invalid_strs[] = {
/* too long */
- "1234:1234:1234:1234:1234:1234:1234:1234:1234:1234:1234"
+ "1234:1234:1234:1234:1234:1234:1234:1234:1234:1234:1234",
"random invalid text",
"",
--
2.30.2
^ permalink raw reply [flat|nested] 5+ messages in thread* [dpdk-dev] [PATCH v2 2/2] app/test: silence clang 12 warning
2021-04-20 13:21 ` [dpdk-dev] [PATCH v2 1/2] app/test: fix " Kevin Traynor
@ 2021-04-20 13:21 ` Kevin Traynor
2021-04-20 22:40 ` Thomas Monjalon
0 siblings, 1 reply; 5+ messages in thread
From: Kevin Traynor @ 2021-04-20 13:21 UTC (permalink / raw)
To: dev; +Cc: Kevin Traynor, Olivier Matz
clang 12 gives a warning about string concatenation in arrays.
In this case, as it is a long string test the strings are concatenated.
Add parentheses to indicate this.
$ clang --version
clang version 12.0.0 (Fedora 12.0.0-0.3.rc1.fc34)
[2556/2719]
Compiling C object app/test/dpdk-test.p/test_cmdline_num.c.o
../app/test/test_cmdline_num.c:204:5: warning:
suspicious concatenation of string literals in an array initialization;
did you mean to separate the elements with a comma?
[-Wstring-concatenation]
"1111000011110000111100001111000011110000111100001111000011110000",
^
../app/test/test_cmdline_num.c:203:3: note:
place parentheses around the string literal to silence warning
"0b1111000011110000111100001111000011110000111100001111000011110000"
^
Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
---
v2: updated commit msg
---
app/test/test_cmdline_num.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test/test_cmdline_num.c b/app/test/test_cmdline_num.c
index ec479cdb3a..9276de59bd 100644
--- a/app/test/test_cmdline_num.c
+++ b/app/test/test_cmdline_num.c
@@ -201,6 +201,6 @@ const char * num_invalid_strs[] = {
"-0b0111010101",
/* too long (128+ chars) */
- "0b1111000011110000111100001111000011110000111100001111000011110000"
- "1111000011110000111100001111000011110000111100001111000011110000",
+ ("0b1111000011110000111100001111000011110000111100001111000011110000"
+ "1111000011110000111100001111000011110000111100001111000011110000"),
"1E3",
"0A",
--
2.30.2
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH v2 2/2] app/test: silence clang 12 warning
2021-04-20 13:21 ` [dpdk-dev] [PATCH v2 2/2] app/test: silence " Kevin Traynor
@ 2021-04-20 22:40 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2021-04-20 22:40 UTC (permalink / raw)
To: Kevin Traynor; +Cc: dev, Olivier Matz
20/04/2021 15:21, Kevin Traynor:
> clang 12 gives a warning about string concatenation in arrays.
> In this case, as it is a long string test the strings are concatenated.
> Add parentheses to indicate this.
>
> $ clang --version
> clang version 12.0.0 (Fedora 12.0.0-0.3.rc1.fc34)
>
> [2556/2719]
> Compiling C object app/test/dpdk-test.p/test_cmdline_num.c.o
> ../app/test/test_cmdline_num.c:204:5: warning:
> suspicious concatenation of string literals in an array initialization;
> did you mean to separate the elements with a comma?
> [-Wstring-concatenation]
> "1111000011110000111100001111000011110000111100001111000011110000",
> ^
> ../app/test/test_cmdline_num.c:203:3: note:
> place parentheses around the string literal to silence warning
> "0b1111000011110000111100001111000011110000111100001111000011110000"
> ^
>
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
Series applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-04-20 22:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-20 13:09 [dpdk-dev] [PATCH 1/2] app/test: fix clang 12 warning Kevin Traynor
2021-04-20 13:09 ` [dpdk-dev] [PATCH 2/2] app/test: silence " Kevin Traynor
2021-04-20 13:21 ` [dpdk-dev] [PATCH v2 1/2] app/test: fix " Kevin Traynor
2021-04-20 13:21 ` [dpdk-dev] [PATCH v2 2/2] app/test: silence " Kevin Traynor
2021-04-20 22:40 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).