From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 00E5B4C8D for ; Thu, 28 Feb 2019 17:27:25 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7E94621E97; Thu, 28 Feb 2019 11:27:25 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 28 Feb 2019 11:27:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=NowDw1EpqOBri9Lea70JRRIaOECvVUbcmx3YDFlYOZE=; b=Nr9xkJtv0zZU s8kubEcsIkhtSWMgmrLdmGH2vXARrZSODmuwm2AVgdpiWm5LV0CuLonmVqWYqAvM UVBCEsKxKkLPq1JkVqDJimLEy4N5pRpy8ZV6JFesJj0X+lpPHVcmILTYw2bhituO 92yCITBUHtpz3oK3rJzLmjSR3Q3olU4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=NowDw1EpqOBri9Lea70JRRIaOECvVUbcmx3YDFlYO ZE=; b=odHyL6TRUnP6rOb7qWf9C4/3UHekFG3YioSQ8HIM8mSJdmOIPhvqiQJsS 60hOC7pUkKErNkHaCkO7/XHzlT60bpDMGMmoloTS/2fsTq4urmfw17rPghT5Fkbs u5S3oq1YuGpxbyFetSLBUl8YFOD/o4kktXNEYktkCYGyMP+b0eawlZ1eckaPRgQb kE4W9wgUg8LbWyM8vbyEiR8prmF20ZPkPIZWl+3i5ZVZJZs+ZPjD2DWUmtnar2Vy G3g2TnJhQJxahxuglKXcUDYIRD2rutGd2LWT4x2wLO/akymO3B3CzrtbAfG8ziq8 S9O9FVkzcrF25qvPq2VIq58gKilTw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrvdefgdelvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epleefrdeirddugeelrdduudegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgr shesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (114.149.6.93.rev.sfr.net [93.6.149.114]) by mail.messagingengine.com (Postfix) with ESMTPA id E9BA7E4309; Thu, 28 Feb 2019 11:27:22 -0500 (EST) From: Thomas Monjalon To: Raslan Darawsheh Cc: "gaetan.rivet@6wind.com" , "dev@dpdk.org" Date: Thu, 28 Feb 2019 17:27:13 +0100 Message-ID: <13394612.Q6ZXlXj6hl@xps> In-Reply-To: <1551368952-1871-2-git-send-email-rasland@mellanox.com> References: <1551368952-1871-1-git-send-email-rasland@mellanox.com> <1551368952-1871-2-git-send-email-rasland@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/4] net/failsafe: replace local device with shared data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Feb 2019 16:27:26 -0000 28/02/2019 16:49, Raslan Darawsheh: > In multiprocess context, the private structure is shared between > processes. The back reference from private to generic data was using > a pointer to a per process eth_dev. It's now changed to a reference of > the shared data. > > Signed-off-by: Raslan Darawsheh > Signed-off-by: Thomas Monjalon > --- > - struct sub_device *subs; > + struct sub_device *subs; /* shared between processes */ I think this comment would have more sense if added in patch 3 which is about subdev. Sorry for nitpicking ;)