From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30070.outbound.protection.outlook.com [40.107.3.70]) by dpdk.org (Postfix) with ESMTP id 5C0812BAF for ; Sun, 2 Jul 2017 02:12:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Xc6OFvo5AqAggN8gxoisFvHNUhUNgu6YzyhtBPL6tqw=; b=vk/+omkwnkNflKQST2C9572cfUJjzrc5w0u5zcaMMzkul3sBSBmvQlPEFbQk0WRN7ivsj238b6EjIji2Jhnq7jhC0fzojEmlZrkb8RUYm0LzocRKfUyqFYoSYXcy4KBhiOcRF5tw5PbVDLq5eofvKM2QsPv43xKfVr6nBcuSRHc= Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com (10.167.195.147) by VI1PR0501MB2048.eurprd05.prod.outlook.com (10.167.195.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1220.11; Sun, 2 Jul 2017 00:12:38 +0000 Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::b9a4:d6b7:4f91:9418]) by VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::b9a4:d6b7:4f91:9418%14]) with mapi id 15.01.1220.015; Sun, 2 Jul 2017 00:12:38 +0000 From: Yongseok Koh To: Ferruh Yigit CC: Adrien Mazarguil , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx: update C compliance standard Thread-Index: AQHS8cUKLTVA0CVfFUuVLZunWsypmqI9rkKAgAAHwICAAAL9gIABaSAAgACKKgA= Date: Sun, 2 Jul 2017 00:12:37 +0000 Message-ID: <1342F388-7481-4007-937B-F804452E3757@mellanox.com> References: <4bc47a8c50dc528f8061d95cdd0c0934e4e40b38.1498843072.git.adrien.mazarguil@6wind.com> <1C0F2AC4-AF9D-4A02-A35A-F70577FE67B5@mellanox.com> <7672F9BE-1782-4F1A-B4B7-F28C82C34FD5@mellanox.com> <45a80418-acd5-42d7-4319-365bed329fa9@intel.com> In-Reply-To: <45a80418-acd5-42d7-4319-365bed329fa9@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [73.222.116.174] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0501MB2048; 7:QMqEXaD0uf9winbhyCivI0cy6DH8MHksyQw5XfGhqleGS5puCJg7c3Q1JFfV8VFGfURWhsfc8hBhSlNyixUH6lq5bhWJ5BvudvE50SMUTt3DzoVAex4+QnHTbDAldgRAoAVAbYMEFGibiiYMUn560wGtKLYY3SF2kddeR7VE+o0fuI26PtIAELIGeeAxOv2SIdW2E4lzCXTpu0yDzw0Z4P+GBbiFXcniSmD3RcdSA8L5deJ/PXrQLYe9EzMmSevgShEAI/GqiLpm85fU0c3LRV+4nyMOoHaOyjgWN+tPtrkxnazpGs1PPKFwuZluwQWAkw/4W2f/27LD0BYi64QQSXKTEK08FdoCDjuigtD7lAuLR+1NDGXIzXu49p+GEYCr/MWrxznywWb6thC5r5caA05eCA4B2DvRnZO0qbRHeCgJL4GeHRcLr/a+mL5BmK6FBIf/uExA65028UdsTJ4zCODIyPtOnmXYNhK/1078LVe6eNDnBNPSKP/ZXc3tEcCzQO2yPgEqaSJuvOU6NAXZ+sHXQRzB5HLO7NXbl9b6Sl7HM1zsTsC3h/NjJkgjWFQBoHbfpZv94ntTaWG8FZNE8FuOfU/Orpmm72878r1B3+Ro5qvOCOqb7KGdo8qB7EqHJ6ctVvMHs9hAv9qSajL0M4OR4WDRBnwiMFcYx8Dt9BNRZ8n/lclCr5EumSsGdQDolu2uETpzJVGnMb1uHtyc93fOgLRKO72H6tUokActs6Bez2Xd7bLLApggfBA7/YDwrqD3m0KrOWSGY4nXRoJ3RnBwiCBgtRwC1hX8hLEEoak= x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-office365-filtering-correlation-id: f37c11b4-d635-4bc1-c272-08d4c0df0c3e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254075)(48565401081)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:VI1PR0501MB2048; x-ms-traffictypediagnostic: VI1PR0501MB2048: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(133145235818549)(236129657087228)(167848164394848)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(20161123562025)(20161123558100)(20161123564025)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:VI1PR0501MB2048; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:VI1PR0501MB2048; x-forefront-prvs: 03569407CC x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39410400002)(39450400003)(39840400002)(39850400002)(39400400002)(39860400002)(377454003)(24454002)(6486002)(8676002)(6916009)(7736002)(36756003)(3846002)(2950100002)(54906002)(8936002)(478600001)(6512007)(6506006)(6436002)(2900100001)(81166006)(3280700002)(3660700001)(229853002)(102836003)(99286003)(2906002)(189998001)(93886004)(38730400002)(33656002)(5660300001)(15650500001)(53546010)(14454004)(5250100002)(110136004)(305945005)(25786009)(6246003)(66066001)(4326008)(6116002)(54356999)(76176999)(50986999)(53936002)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2048; H:VI1PR0501MB2045.eurprd05.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-ID: <4C9258E6E4EF5D418BC9930340DCB205@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2017 00:12:37.9574 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2048 Subject: Re: [dpdk-dev] [PATCH] net/mlx: update C compliance standard X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Jul 2017 00:12:40 -0000 > On Jul 1, 2017, at 8:58 AM, Ferruh Yigit wrote: >=20 > On 6/30/2017 7:25 PM, Yongseok Koh wrote: >>=20 >>> On Jun 30, 2017, at 11:14 AM, Yongseok Koh wrote: >>>=20 >>>=20 >>>> On Jun 30, 2017, at 10:47 AM, Ferruh Yigit wr= ote: >>>>=20 >>>> On 6/30/2017 6:19 PM, Adrien Mazarguil wrote: >>>>> This commit addresses a compilation issue against Glibc >=3D 2.25, wh= ich >>>>> implements assert() through a nonstandard ({ }) construct. Such const= ructs >>>>> can normally not be used without __extension__ keyword when -pedantic= is >>>>> enabled, as is the case when compiling mlx4 and mlx5 PMDs in debug mo= de. >>>>>=20 >>>>> While assert.h checks for the compiler ability to support GNU extensi= ons, >>>>> Clang, unlike GCC, does not allow the above syntax when combining >>>>> -std=3Dgnu99 with -pedantic. >>>>>=20 >>>>> Work around missing keyword by moving these PMDs to a stricter compli= ance >>>>> standard without GNU extensions but properly checked by Glibc. Doing = so is >>>>> supported on the DPDK side since includes have been cleaned up. >>>>>=20 >>>>> Signed-off-by: Adrien Mazarguil >>>>=20 >>>> Applied to dpdk-next-net/master, thanks. >>> This breaks debug-enabled build of mlx5 as mlx5 isn't ready yet! >> Specifically, the following errors happen. It might be better to later m= ake the >> change for mlx5 with further cleanup. >=20 > I don't see build errors. > Patch is requested to fix mlx DEBUG builds [1]. Can you please give more > details how to reproduce build error? Mine is on CentOS 7.3 and gcc is "version 4.8.5 20150623 (Red Hat 4.8.5-11)= (GCC)" Adrien chatted with me and he is already preparing a simple patch. I've als= o verified his patch fixed the issue. Thanks, Yongseok=