From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9E97643B6F;
	Wed,  6 Mar 2024 18:22:49 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 28F8142DBD;
	Wed,  6 Mar 2024 18:22:49 +0100 (CET)
Received: from fhigh7-smtp.messagingengine.com
 (fhigh7-smtp.messagingengine.com [103.168.172.158])
 by mails.dpdk.org (Postfix) with ESMTP id 4FFD042D96
 for <dev@dpdk.org>; Wed,  6 Mar 2024 18:22:47 +0100 (CET)
Received: from compute6.internal (compute6.nyi.internal [10.202.2.47])
 by mailfhigh.nyi.internal (Postfix) with ESMTP id D2D7111400FE;
 Wed,  6 Mar 2024 12:22:46 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute6.internal (MEProxy); Wed, 06 Mar 2024 12:22:46 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:cc:content-transfer-encoding:content-type:content-type:date
 :date:from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:subject:subject:to:to; s=fm1; t=1709745766;
 x=1709832166; bh=JXGszlpyZVmO2Oh5il+1C6kGthjUhsP0uLMOUyGzgAE=; b=
 b0LS2O6agEAKcp2SKEGnRw5kjUrxla5b7NmW9kzSOMFbUDL5j1+sHuOK4+Ij/5jL
 e5CjvduiTGMCSCmfYzz4Q6qJqDxqqV4k8L4PLzEipWdj3B9xVJ9P7WY3A25QuuT3
 0YdvYxiuo5sSavDQXdn7Tu346COJp2chEhar1ECpjlhFeLZqE8Ua7in0wLZeH3TF
 yUtwDz1JSkIgNEHGZEic9/w0wvyhaARiUi1WcpHjLO85g8iGVQo0Z29uj0J/nUL/
 /vTn0UYJN8NpjB9iFAdX+WmZUV4N8Vh/WavGV5o5+2kaDd2GL1oWcV0Fk9mKyM3e
 aOTxuUFV+JCKzKVjb4a5fg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:content-type:date:date:feedback-id:feedback-id
 :from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy
 :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1709745766; x=
 1709832166; bh=JXGszlpyZVmO2Oh5il+1C6kGthjUhsP0uLMOUyGzgAE=; b=i
 vt/Z7pDIhb4XsxT3Tkbc0qQ9XsFMvjb/mXNtXPCQ+g/iaj1qCHbYfV2jUY4ARoxS
 j/KPh4988UE3xtV9ECp7GlLF7sYAzOgX/1X8gK66ifksIE9XzS7/l7Vqr7R6GCZ4
 GyMyve2zx9VJytcoZF1XTeThc/ZJJvDYeVRVLKi0jhfnPP4YhsBpLsqRl+8tdSGS
 zLgi0OAQUPoj/R/UHLCkuJzO5WqtQvQkCRWGgm+srMoxStiNMivq3+s93Ti1vVoV
 Xur/GqIqyAN1X+UBe721h7vE3BjZiaxOsh55jymRbWAF/7P+aZbH3us83v1Ne6gR
 OMkufZOmP0ENZYnVTAsNQ==
X-ME-Sender: <xms:ZqboZZWxkmGX-bqa0RxRmRBuJOhSHFylgxPHLXVEonGyS6XWbhqsag>
 <xme:ZqboZZmWU4q6WuKYPb8iLVGJzBycdgSLN1s7vi50-EJ_NUSz94Y5l8HtbxlaNgJjF
 R2mTBa7Rkxwb7hhMw>
X-ME-Received: <xmr:ZqboZVbtUHmIJMWpz_8MJ8LLRrf978qsPtbbMWBAE9a08w-ppqzKWmOODzENtVGjMEl42YjPBME-CLkjEz0NBf9wUw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledriedugdeliecutefuodetggdotefrodftvf
 curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
 uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
 fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
 ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek
 gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh
 homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:ZqboZcW92wD6u1FJZScprVrh2eGZDCCjWan0Jg_eF0gEs0c-EfeKzw>
 <xmx:ZqboZTmP7s1KA7namwVmNI-87biBTKy7BXzLOlI1_8Kh-FYrbiiXlw>
 <xmx:ZqboZZfNsvorHzyMKm-dcxMN3wQKvHZjHm6nFdGIF1LbxkIOa7kdMg>
 <xmx:ZqboZRX5I1ZcT0Qywimi2v6C7wr2gD6adweea8Do1G0of1Qelf1VIw>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
 6 Mar 2024 12:22:45 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Tyler Retzlaff <roretzla@linux.microsoft.com>,
 Yipeng Wang <yipeng1.wang@intel.com>,
 Sameh Gobriel <sameh.gobriel@intel.com>,
 Bruce Richardson <bruce.richardson@intel.com>,
 Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Subject: Re: [PATCH v2] hash: make GFNI stubs inline (again)
Date: Wed, 06 Mar 2024 18:22:43 +0100
Message-ID: <13465891.y0N7aAr316@thomas>
In-Reply-To: <20240305030819.276707-1-stephen@networkplumber.org>
References: <20240304184508.89956-1-stephen@networkplumber.org>
 <20240305030819.276707-1-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

05/03/2024 04:07, Stephen Hemminger:
> Tyler found build issues with MSVC and the thash gfni stubs.
> The problem would be link errors from missing symbols.
> 
> This version puts back the rte_thash_gfni function stubs as
> inlines, but instead of logging a message, they panic.
> This is intentional because any application should be checking
> with function rte_thash_gfni_supported() before calling the
> hashing functions here. Better to panic then return zero
> and put out log message which will be ignored...

I want to be able to grep rte_panic in the lib directory
to find those we should remove.
Having "legit" panic calls is a no-go for me.