From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 88633A0546; Tue, 6 Apr 2021 14:18:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 731ED406A2; Tue, 6 Apr 2021 14:18:41 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id CA82E4067C for ; Tue, 6 Apr 2021 14:18:39 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 5A5875C00C6; Tue, 6 Apr 2021 08:18:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 06 Apr 2021 08:18:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= AVwfwQubjTjVzV3u/lyD6VG1E6+FcPMwfT74u1FleGI=; b=hdZ0zYyk5qrdU5uo 42k6AyrjEP/csPIsK6oybcmtTsVerS/R4lLK53iMCRw/mAhj0cYPfU5VmZaRbVcQ FYbfMf0BOWx5a6A+AQX4oRxEm9Wx6BPocefIsR2DSymVxpMRM8saXrrzCz3r2sRd X6bs2ttuU9Pj+GY1tJxTL7hihjBJdBJPbashU4wpJelR9IL6ydFkP2z/5se+GokZ f88H3NILwqUWMrBF5T+H9cuIrfjYvmmNqzADMFRUCf3EvWZXZhIVF8HaTAyw7TVj uwM/l7VvOtRhNZCD+yXj/O47+O8ei8cOUzkHF2p8Qzf1/UMEYr2R02Ds/c04Ey/3 b+xwLA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=AVwfwQubjTjVzV3u/lyD6VG1E6+FcPMwfT74u1Fle GI=; b=wRhgQ+0V38E2fjArSdOcYe/Zce1QFPtzJYcsmU4vHxLBmCt3vVrOpwKdy F9/JypylH8ZAilryLSsZ9BWUjeJ2xbJxOGpOe7MKKc6sn3QdfFsx2Pt8MMLZ+sEZ 3ftrr4MnhhFP7tbA49EnvCylB3r16AoWg+0mj8UeA2Jm1izLDp+gn+saWk/0TRjT U5Ix30Q1EzPZbN6mmvHi0L+3mhEWicLHdhwzjIONXD0ZUbfvurGrTOfI1dCWZHBH rArZwxLui1f+GfRvF85L4XIgpMTDc9WLenUFocUvgN2K/86XZrR7/lXcW8b7oQ/c sc1WyiPW/k223VGMnC/SEnSKebyuw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudejgedggeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffdvffejueetleefieeludduuefgteejleevfeekjeefieegheet ffdvkeefgedunecuffhomhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrd dvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3EA4D24005A; Tue, 6 Apr 2021 08:18:38 -0400 (EDT) From: Thomas Monjalon To: Bing Zhao Cc: Andrew Rybchenko , Ori Kam , "ferruh.yigit@intel.com" , "dev@dpdk.org" Date: Tue, 06 Apr 2021 14:18:35 +0200 Message-ID: <13482208.h4NtUrPqza@thomas> In-Reply-To: References: <1615967952-228321-1-git-send-email-bingz@nvidia.com> <3094400.VKgfFvgXnU@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [RFC] ethdev: introduce action context APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/04/2021 13:02, Bing Zhao: > From: Thomas Monjalon > > 06/04/2021 11:07, Bing Zhao: > > > From: Andrew Rybchenko > > > > On 3/17/21 11:28 AM, Thomas Monjalon wrote: > > > > > 17/03/2021 08:59, Bing Zhao: > > > > >> The new functions rte_flow_action_ctx* that were added will > > > > replace > > > > >> the curret shared functions rte_flow_shared_action_*. > > > > >> - rte_flow_shared_action_create > > > > >> - rte_flow_shared_action_destroy > > > > >> - rte_flow_shared_action_update > > > > >> - rte_flow_shared_action_query > > > > >> + rte_flow_action_ctx_create > > > > >> + rte_flow_action_ctx_destroy > > > > >> + rte_flow_action_ctx_update > > > > >> + rte_flow_action_ctx_query > > > > >> > > > > >> When creating a action context, it could be shared among > > > > different > > > > >> flows or different ports. Or it could also be used by a > > single > > > > flow. > > > > >> The name "shared" is improper in a sense. > > > > > > > > > > Is it the only reason for the change? > > > > > I better understand "shared" even if it is sometimes not > > shared. > > > > > > > > +1 > > > > > > In another email, I explained the change a bit more. Please check > > and give comments, thank you all. > > > > Any link to this email from inbox.dpdk.org? > > The link is here. > http://inbox.dpdk.org/dev/MN2PR12MB29097FE55676D5D389D86C46D0769@MN2PR12MB2909.namprd12.prod.outlook.com/ > > > > > Please explain here the naming reason. > > > > The naming reasons are listed below: > 1. The "shared_action*" is incorrect or improper naming of the interface. > 2. The "_update" interface needs to be changed to support the partial updating capability. > 3. Since we need to modify the update interface, this is a chance to change the improper *experimental* interfaces naming to make them more proper. It does not explain why "action_ctx" is a better name than "shared_action".