From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0630EA0A0E; Tue, 11 May 2021 16:19:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 76C2F40140; Tue, 11 May 2021 16:19:55 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id E03834003E; Tue, 11 May 2021 16:19:52 +0200 (CEST) IronPort-SDR: EQ31qTgs6Guzh5FJBr4/sXkbjj/3FE7Kf2gGZq5LyoJ0p0wcyqFa8Ppmc/4uyw62uwkrmaZQIR B5pd0f/MaaGQ== X-IronPort-AV: E=McAfee;i="6200,9189,9981"; a="263384107" X-IronPort-AV: E=Sophos;i="5.82,290,1613462400"; d="scan'208";a="263384107" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 07:19:51 -0700 IronPort-SDR: 4RJ8NWJwZcu6q0mKoKV6AQzmJa9fsTncbViJCSPOGMlzYeRnEcGb5HS6Na1RdvRlBZ11o1bI+j 2Wx/C/q+j9XQ== X-IronPort-AV: E=Sophos;i="5.82,290,1613462400"; d="scan'208";a="537048411" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.224.45]) ([10.213.224.45]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 07:19:48 -0700 To: John Daley , arybchenko@solarflare.com Cc: dev@dpdk.org, stable@dpdk.org, Hyong Youb Kim References: <20210505183940.9958-1-johndale@cisco.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <13528a8e-9dc8-385d-bd56-c91d2ef69b23@intel.com> Date: Tue, 11 May 2021 15:19:45 +0100 MIME-Version: 1.0 In-Reply-To: <20210505183940.9958-1-johndale@cisco.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/enic: enable GENEVE offload via VNIC configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/5/2021 7:39 PM, John Daley wrote: > The admin-configured vNIC settings (i.e. via CIMC or UCSM) now include > Geneve offload. Use that setting to decide whether to enable or > disable Geneve offload and remove the devarg 'geneve-opt'. > > Also, the firmware now allows the driver to change the Geneve port > number. So extend udp_tunnel_port_{add,del} to accept Geneve port, in > addition to VXLAN. > > Fixes: 93fb21fdbe23 ("net/enic: enable overlay offload for VXLAN and GENEVE") > Cc: stable@dpdk.org > > Signed-off-by: John Daley > Reviewed-by: Hyong Youb Kim > --- > doc/guides/nics/enic.rst | 32 +++--- > drivers/net/enic/base/vnic_dev.c | 2 +- > drivers/net/enic/base/vnic_enet.h | 1 + > drivers/net/enic/enic.h | 4 +- > drivers/net/enic/enic_ethdev.c | 71 +++++++------ > drivers/net/enic/enic_main.c | 161 +++++++++++++++++------------- > drivers/net/enic/enic_res.c | 7 +- > 7 files changed, 154 insertions(+), 124 deletions(-) Hi John, Andrew, Can you please update release notes too?