From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54E63A0C4E; Thu, 12 Aug 2021 18:00:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 375E34111A; Thu, 12 Aug 2021 18:00:05 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 6584040042 for ; Thu, 12 Aug 2021 18:00:01 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10074"; a="213532178" X-IronPort-AV: E=Sophos;i="5.84,316,1620716400"; d="scan'208";a="213532178" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Aug 2021 08:59:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,316,1620716400"; d="scan'208";a="676816593" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga005.fm.intel.com with ESMTP; 12 Aug 2021 08:59:53 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 12 Aug 2021 08:59:53 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Thu, 12 Aug 2021 08:59:53 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.104) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Thu, 12 Aug 2021 08:59:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YHu9iG1CiT9kAYsLr3frz6IIlcdORaLUMOv4VOtEv6nSfkTq0da/Cvbeaxw8JBAZVQr2NpYVr1CkplnjnAWGBuwhrze/9cnM4JkjuhLoM5v4gM4GMFxjT5G7HkGwB2uYvU/7JnAmFixhvsL1OJZCMCJuXwKrTHKUSNSCLN7n7Zu8xtDSIIz7SjauzJEMSpcUzQnPYTlIhwK3N0SIb+fKxtupS7gmt30Gkcs6/Dm16ID7KEC1NDvXHJBNf7Qb190BsU1uFYvgdXXxYdeayZeLx3FxUfhQkeebwiD4M4245mFx+CtKYWBR8GCWZ2LlAWW6U/1vMOURAd9ErtJzh7kycA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+j0T8kg8nUit37dKbeIXBSBnUDVXje3+9zRANFmYVPY=; b=c7AQLsBWxtfw+7BTQJ6cOuZzaB2QLjDAlD/seWu5d2tzGVCTdykB45sGHbS3ABn/2QiculambGlkreQqPpoVBD8xtgQDRnGBTP8Gb0fYeqwzwqCAC7G3BvwkXRP+FRGcOoUaQWYX33tP1/l6EssVOpTIcQ1nZs3tVhWioX0CWOzdbgiSoMyU5Jq0ez7qk875Zj+r6pq/nYDDyVmCLSSneNEUmmkq/JMPkHjBRdC0/rhBANFtPTX43HJBs0gf6w5YSbpiXX5TZM9ZJUxl0qNY3XaViYqpnCM0o5ApkZGaJfPiMaRm8m+uW+ec8hNwAxoH9B6nzQGGsEiZXw16iOxebA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+j0T8kg8nUit37dKbeIXBSBnUDVXje3+9zRANFmYVPY=; b=bqIH6cWTKayWCX7NNq5PQz0DjnpfC/zpVb9HJS/jwsQr5kg0ft/XaaVE952+TPFpTqCTG5wQUt5QaOuui+ag/B12u6Fa2nVma3HGOWYW7ndvO0h4K9YxS9Kp3jMhi1lZzgVjOcq0+M6w1Edku5WWO5AAcwRd3MGKoTtUkNNKhCg= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5045.namprd11.prod.outlook.com (2603:10b6:510:3f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.21; Thu, 12 Aug 2021 15:59:52 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::2979:70ca:38a:dbaf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::2979:70ca:38a:dbaf%7]) with mapi id 15.20.4415.018; Thu, 12 Aug 2021 15:59:52 +0000 To: Aman Singh , References: <20210810073541.60975-1-aman.deep.singh@intel.com> <20210810073541.60975-3-aman.deep.singh@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <1359eb91-c1e9-fb13-5a40-936344cb1b81@intel.com> Date: Thu, 12 Aug 2021 16:59:46 +0100 In-Reply-To: <20210810073541.60975-3-aman.deep.singh@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: PR0P264CA0100.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:19::16) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.206] (37.228.236.146) by PR0P264CA0100.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:19::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.13 via Frontend Transport; Thu, 12 Aug 2021 15:59:51 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e4733589-16c8-4956-cf72-08d95daa3858 X-MS-TrafficTypeDiagnostic: PH0PR11MB5045: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5516; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TpU7N7kvH989WqJ9suY16tccbcF63cSRHadspkpMsTS/8ae73gYJuQkSBDHaWWqNcdTOQw7wYEDP10e/nKRCQsVK1Q5zD0X0xaIlUOIQw9TJuG4iuAlTFQw+X0A450n21jrmPZC6Ra9KyRTKpS9KcUfABh+SZX2zE5ZJ83nIzVe2SmOQnz+kUi+t69kCxWTkmuJPQLOydhdpsNnsj65rwDaQbAKv9cXC71n+/pdFL31Awo41Romw9TBwtLZcVJ2bshPsPRYG9UKr8Mtf5CFZ2Z9aPIBsWgabyvRe0ea55A8fsthhPNWVzDmy5kBOsJ0MJtW5bd3JnFn264aVD6wVHaGlMWpuiRiOhwWloL7kFw9uv8VZUKRaSyr4ed1oKUbULo0N+E6bop0aS7qce5cqvrB22elcn7TbncGuDBU5Qb9SOMUWCb0MYmvlmY0ZVAHacgawmqPATCRY+nn0xbczs+XBDZeEFabqqbaUpZX3T8BSGYZaMTTTt2PYkNv4/t/tks7bk21DlATI5dvUCGNWusDa/MvSlGsSEnuAFS//0v8HDqbIC5NBYBVHeWuBsrwiNsHC1kQs57cQJZDq4R/oUkBjKRGHlOQsFSZeabYx4IZqWPKVStMFRCB5ML1d0zMsdHsTEJlbW5kXck81yEERttWgGHP2UjOgnbRcVetEVVYftwmk/BD+hVW6UEz7ud8sxNqC2cl1RoGFZBPK/PvSGQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(39860400002)(346002)(376002)(366004)(136003)(6666004)(8936002)(5660300002)(44832011)(53546011)(36756003)(26005)(186003)(2906002)(38100700002)(31696002)(8676002)(478600001)(956004)(316002)(66476007)(66556008)(2616005)(6486002)(31686004)(86362001)(83380400001)(16576012)(4744005)(66946007)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WDRnYmo1b3g0Nk5FdG1WaXhYWmxNTHV6Z1dLc01ZQ0hIeUl5bXM1akNHMkZm?= =?utf-8?B?V29seEJkeklnMzN5TXZjend6bnl3UmpZVVlXK0kwQ3ZMbjl0NWtwL3ovajJu?= =?utf-8?B?NVd0eFo4YkxtcEZ6QmRaMFlLZGNCVXN6a3N4c2tLNnIzQWlhdTR6ZGhPVXZY?= =?utf-8?B?V0NuaEpQYmJPYmNzejgzczFhdGluMlJYM283LzVmOWZVQStIems1TDZZdUZu?= =?utf-8?B?U04zNWJ5eG45ZFBmYlQxd1lTb1hFdDZFSFd3V1ZOb3BKaEwyMXBHc2RPeitJ?= =?utf-8?B?TmxLQW9jVnprZXJMbUowRU4zazZybkNacXhQYVlLclJmS1hmRjEwUVlDcGU1?= =?utf-8?B?aGRoZWVGN2x0WmZSQll3bUFXVXFyL0dBZW9FNjBRaGxOVDdVUTU0bjBQV0RJ?= =?utf-8?B?S2toLzNiM0pEYjdha0d1TTF0ajBTN0NiWXNMU0dyYVlQem1IZDNsMldFWEUr?= =?utf-8?B?MTZkd1piYkZuTDlsK0FUa1ZIRjBzR1ZQZDZqRzZHNmtLYVZFUVZHODhxMGEw?= =?utf-8?B?SkwyUkZ4Y0Vjajdrdk53eUNHcktJN3VhRnpTY3MvdlZwMmxVbEx1aC9qejQx?= =?utf-8?B?NjJSdDZMOUVJWlpubnBVYkgzK2JOMys4ZGlaZjlYejJJWmUxSlFRZFZrQlpZ?= =?utf-8?B?UHNsUDdhYUxPVHVBNnNscUNUS0QraWdrdGxWcXQxVHY0M1Axak9qNlRhRUhY?= =?utf-8?B?YlY1bm93STgvWXFFdm9RYkpKR0N0Zno3WTNtNzRHS0IzZ0NWZGttZ3Y2QnB6?= =?utf-8?B?akFKc2U4b05Bc2VZQU9SVFJsVWY3VGZObDZVYnBLRnBCT3lMaExzR0Y5eVdJ?= =?utf-8?B?MGFGVVVTRDZuckYyQVgrS2tISW54bUN5K1B3bG5XcTYzRmpHaHpYWTl0N1hm?= =?utf-8?B?NDN0dTZoTTh5SFBjU2pCNXBDaEU0cDFwK2Qzc1ZXYTV6emhscDc5RzFCc2dR?= =?utf-8?B?WjdJUTExMGlmMHgyeTZFNGpGaFhpRGhBemJzMTFvM0lDUnJoQ2twbDdLZldM?= =?utf-8?B?ckhCNWUyK2NHZzlrakQrUmlFSTJHdDBnYjJJYVZsQ1NETjh4OTBsR3NOc1Jx?= =?utf-8?B?L1dBak96NGRTbFZyR0hoUGFnZHI3aWdDaGl3TkVxN09WRkJUaUlXcGhpeWdZ?= =?utf-8?B?cWlpQ2kza2tsQXN3NE5WbnRpOWgwcHRPdXdUbzZ0aW8rUWVOV1ZKdHk4Zy9p?= =?utf-8?B?YVg2R3ZoaUJ3M0RsalZqOHBUVmdFNlYyMmRYZk42VitqMUNLdER4bjUvbEd1?= =?utf-8?B?UTNBbUpXVVBMZ0hrWGF5MUxiMWFTcGJ5QzFHNGRaU2VxUmNXcjVOVUZtYmMx?= =?utf-8?B?ekE0SFhEYU51T2Qya1lNaW1ZcEVycmhZMFRoR1YzR3pjT3ZEdXRhUzR0eThw?= =?utf-8?B?SDREMWEvVE1UUTRMdGJ3L2I3cklMQmZDclp1dXNpY2hlbGVXOXgwcFgvNjM2?= =?utf-8?B?OFNQei82dXk0Znd2RVhwYzE0aTFiVzNjeDVYK2lmOEFhcGVnaGRRMlNtS2U3?= =?utf-8?B?dHNuQnZhZGdTeDJUOFpCa012VnU3YzNtUlZYSk13c2ttRFdZWlhBQlN1NW5L?= =?utf-8?B?YS82ZjlhbzBuU0ZCYTFobnNPMnZwRGF4WEx3UG4rcWM1a2k4THlramtZK3pK?= =?utf-8?B?T1JDV2NUNzByV283K3BTaU5QZlVtVVl5K2d0VmtiS29PeTkwRHVPUG5uaDBD?= =?utf-8?B?d1JjNU9oUHpHT2s3UUQ1UXE0QnBaZ2JHbVBTK29TdjlmVE5qOHhjS21DT1Jz?= =?utf-8?Q?8iefuBdZQMW1GOcAB3FWa0ty9OM2xeA1B9lWuun?= X-MS-Exchange-CrossTenant-Network-Message-Id: e4733589-16c8-4956-cf72-08d95daa3858 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2021 15:59:52.3830 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Wx36HeMW7qMO5bq6o8zhay1KzFfR54FpUBZO98bnuTPAinFFQVCN9x/4Y3p7oE0OQHw7sOW5kKWNPB0jYPUESg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5045 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 2/2] net: macro to extract MAC address bytes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/10/2021 8:35 AM, Aman Singh wrote: > Added macros to simplyfy print of MAC address. s/simplyfy/simplify > The other method of first formatting mac address > into a string and string printed, is avoided. > There are some cases that 'rte_ether_format_addr()' API is used to convert MAC address into string and later that string is printed. If you mean above usage, that usage is still exist after this patch. As far as I can see this patch is just to add helper macro to get octets of the MAC address. Can you please clarify? > Signed-off-by: Aman Singh > --- > The change in the document will be done in seperate patch. > To ensure document has direct reference of the code. +1, you can add the link of mentioned patch here. And patch title comment in previous patch applies here too, can you please update it? Except above issues, Reviewed-by: Ferruh Yigit