From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
[66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 95CB02BA1
for <dev@dpdk.org>; Thu, 8 Jun 2017 22:45:57 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 264DC20A98;
Thu, 8 Jun 2017 16:45:57 -0400 (EDT)
Received: from frontend1 ([10.202.2.160])
by compute1.internal (MEProxy); Thu, 08 Jun 2017 16:45:57 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:content-transfer-encoding:content-type:date:from:in-reply-to
:message-id:mime-version:references:subject:to:x-me-sender
:x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=QhJPcOsMK3RJD8x
nNahL0I57Ss0d8om6iT76TGYS3SE=; b=sXCeyiJNy3HBJNW+lPJiHxaUebMMq6s
f8gasyCkg6cTqUSoUxLSCh8QSRhQ+A2cT4pR65ylgJVvjEWwWPlAuMJ5acAAlcDY
g8WBqMP10SjGsgVVFtpeqqO5pIq1krGI/RRoaBVTXDQmalOYwMFsTGxL0qm36hSL
3ALnYf0MqkO4=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=
fm1; bh=QhJPcOsMK3RJD8xnNahL0I57Ss0d8om6iT76TGYS3SE=; b=EupWjkkK
fN3yVRh0yAeukmDFKyMd8/uONl6xQH0vjs+UlP3bqnNoi+gF6/ssDHODZnH+dXEj
0b2G6eupfJ5azwkbeHK1VmB8YRQ4D+fYi2N6vRURnq5g1aS2HJIg5vQWMpxDF7Zr
gDSCAB7Mj8I5uadxjM0jDIQ+7t5clTCTsAfr0CARvbm5XRCd2zuzJZMUWCYNzUXb
fVEVPJCNo8QVLEpsa4fYOKIGXNUPpSimxRLKPyBSU+rHQuBdUnmaTtSrLpFK9400
+neexcMv/ep3GcW7Sa/uP+1iG95IOx2EcIhdV4Kb9YCNMdNkN9qpjDQaB/5nIT9l
apYJMVKsNJ8xkw==
X-ME-Sender: <xms:hbc5WVaIvUHHRyMuVpF5tHKFpZaXX1CuOBsjrv9eG55Gv6OrE13QIg>
X-Sasl-enc: kUBJThN6W6S5k04VcA293HGRvXPYOAPZa6QcuVeObOvX 1496954756
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id C92497E6E5;
Thu, 8 Jun 2017 16:45:56 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Jan Blunck <jblunck@infradead.org>,
Gaetan Rivet <gaetan.rivet@6wind.com>, Tetsuya Mukawa <mtetsuyah@gmail.com>,
Declan Doherty <declan.doherty@intel.com>
Date: Thu, 08 Jun 2017 22:45:55 +0200
Message-ID: <136091512.oDuubpNRB2@xps>
In-Reply-To: <20170510110104.70838-1-ferruh.yigit@intel.com>
References: <20170510110104.70838-1-ferruh.yigit@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] eal: remove vdev probe by dev args
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Jun 2017 20:45:57 -0000
10/05/2017 13:01, Ferruh Yigit:
> Virtual device/driver probing done via name.
>
> A new alternative method introduced to probe the device with providing
> driver name in devargs as "driver=<driver_name>".
>
> This patch removes alternative method and fixes virtual device usages
> with proper device names.
>
> Fixes: 87c3bf29c642 ("test: do not short-circuit null device creation")
> Fixes: d39670086a63 ("eal: parse driver argument before probing drivers")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
[...]
> static int
> vdev_probe_all_drivers(struct rte_vdev_device *dev)
> {
> const char *name;
> - char *drv_name;
> struct rte_vdev_driver *driver;
> int ret = 1;
>
> - drv_name = parse_driver_arg(rte_vdev_device_args(dev));
> - name = drv_name ? drv_name : rte_vdev_device_name(dev);
> + name = rte_vdev_device_name(dev);
It seems you are reverting the commit d39670086a63:
eal: parse driver argument before probing drivers
In some cases the virtual device name should be totally different than
the driver being used for the device. Therefore lets parse the devargs for
the "driver" argument before probing drivers in vdev_probe_all_drivers().
Is this "driver" option useless?