From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f50.google.com (mail-wg0-f50.google.com [74.125.82.50])
 by dpdk.org (Postfix) with ESMTP id 4C6E51FE
 for <dev@dpdk.org>; Sat, 12 Jul 2014 00:30:18 +0200 (CEST)
Received: by mail-wg0-f50.google.com with SMTP id n12so1675535wgh.33
 for <dev@dpdk.org>; Fri, 11 Jul 2014 15:30:45 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=7AhGva7GyFXL/dyMdh/GZ167sE5noJa6DVFyscwyvgQ=;
 b=hLG0p7nf9gyLCE1RLAY+ws4k0Ty0topkfI7lTUspVy9XFsRVYo3aIHevlVI3jCSVL8
 qUhzYPSsgjT+buqD6+dKviosOEPIHxawSugECHRl+BZTrQ8Bxa0Q290xuEtjzftEcmjm
 P81Bjz048qHsnPbRnyNBIrcU4VT/zwiVugXxmiK+9ktTKCaY3bPRwH2bGCNtYzH++ezX
 DeautvDkXuqaptTisEtJEtrFUGXLGsAcYA9m3sIOWopNxTLugY+9UGcpBLUvNIzDkx99
 mOF/UWeIeAl/nZeevHONIFtEM9lJVAOP8UmWtoLlR6j6mhGZrlg7PqPI0Bmo1Yb307+B
 ZvPA==
X-Gm-Message-State: ALoCoQlDAYXCbgeWvxM0KeBQi+vQ+T4QOOfhwdvI46TjUkpjCosihUh3FR2iOH6OvQbN76uqJbjd
X-Received: by 10.194.222.5 with SMTP id qi5mr2308059wjc.62.1405117844949;
 Fri, 11 Jul 2014 15:30:44 -0700 (PDT)
Received: from xps13.localnet ([80.215.166.190])
 by mx.google.com with ESMTPSA id pc4sm12064449wic.16.2014.07.11.15.30.42
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 11 Jul 2014 15:30:44 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "John W. Linville" <linville@tuxdriver.com>
Date: Sat, 12 Jul 2014 00:30:34 +0200
Message-ID: <13642580.3DAGicjMse@xps13>
Organization: 6WIND
User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; )
In-Reply-To: <1405024369-30058-1-git-send-email-linville@tuxdriver.com>
References: <1405024369-30058-1-git-send-email-linville@tuxdriver.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] librte_pmd_packet: add PMD for
	AF_PACKET-based virtual devices
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Jul 2014 22:30:18 -0000

About the form of the patch, I have 2 comments:

1) A doc explaining the design, the dependencies and how it can be used would 
be a great help. Could you write it in rst format?

2) checkpatch.pl returns these errors:

ERROR:SPACING: space required before the open parenthesis '('
#468: FILE: lib/librte_pmd_packet/rte_eth_packet.c:250:
+               if(sockfd != -1)

ERROR:SPACING: space required before the open parenthesis '('
#471: FILE: lib/librte_pmd_packet/rte_eth_packet.c:253:
+               if(sockfd != -1)

ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#712: FILE: lib/librte_pmd_packet/rte_eth_packet.c:494:
+               ifr.ifr_name[ifnamelen]='\0';

Thanks
-- 
Thomas