From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 9C02F5A35 for ; Wed, 1 Apr 2015 09:51:08 +0200 (CEST) Received: by wgra20 with SMTP id a20so44006552wgr.3 for ; Wed, 01 Apr 2015 00:51:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=MyLJfIVI4C+nE1q/wcvHq18DzrGd8EeiWJzKj0S1h8A=; b=VsC8LU3d4kl/V6Kqe6T7PS0RlXqRIkMGs1ngsLPIyGDsCvgpI+nWxJwcuvRaTzVfDB l/s8ykjgUtvrMG/uJv8K2jAjH25pWKW8eGD3fuVtSngagPGKtStwXsLmcg+obt8pvqNw 6+fqG1jUgcuiYRlnEUuseTWMj8DkNHKWMkNGyr5U+3E6GJnxh9V24ctujl0cp/Tu9g7w k/fmGfljhormZW+NV0kdpgT1Qi34LM0cbCiRo+ExSbtGsjmbFgygClcGazmUgH+whZt3 t2uBZV8dktgF26ICWcXs5D/ewp1YXGlXdDA1eRepYmRwLmfZHaj4a+DRuAmNHVekj/+U nAzg== X-Gm-Message-State: ALoCoQkL2A1rn/N1xzxmpR01qelPsIb3kyTwH7eT9kLawT6pAEbFg3WZB2n4yAY8tQNazD0b2elF X-Received: by 10.180.80.164 with SMTP id s4mr12375254wix.63.1427874668450; Wed, 01 Apr 2015 00:51:08 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id v8sm27780431wib.0.2015.04.01.00.51.06 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Apr 2015 00:51:07 -0700 (PDT) From: Thomas Monjalon To: "Xie, Huawei" Date: Wed, 01 Apr 2015 09:50:26 +0200 Message-ID: <13730553.gtSSln9O6Y@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: References: <1426925237-8312-1-git-send-email-haifeng.lin@huawei.com> <55191575.5020805@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] cast used->idx to volatile X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2015 07:51:08 -0000 2015-03-30 15:56, Xie, Huawei: > On 3/30/2015 5:21 PM, Linhaifeng wrote: > > On 2015/3/24 18:06, Xie, Huawei wrote: > >> On 3/24/2015 3:44 PM, Linhaifeng wrote: > >>> On 2015/3/24 9:53, Xie, Huawei wrote: > >>>> On 3/24/2015 9:00 AM, Linhaifeng wrote: > >>>>> On 2015/3/23 20:54, Xie, Huawei wrote: > >>>>>> We have compiler barrier before and an external function call behind, so we don't need volatile here. > >>>>>> Do you meet issue? > >>>>>> > >>>>> Tx_q is sometimes stopped when we use virtio_net. Because vhost thought there are no buffers in tx_q and virtio_net > >>>>> though vhost haven't handle all packets so we have to restart VM to restore work. > >>>>> > >>>>> The status in VM is: > >>>>> Mar 18 17:11:10 linux-b2ij kernel: [46337.246687] net eth7: virtnet_poll > >>>>> Mar 18 17:11:10 linux-b2ij kernel: [46337.246690] net eth7: receive_buf > >>>>> Mar 18 17:11:10 linux-b2ij kernel: [46337.246693] net eth7: vi->num=239 > >>>>> Mar 18 17:11:10 linux-b2ij kernel: [46337.246695] net eth7: svq:avail->idx=52939 used->idx=52939 num_free=18 num_added=0 svq->last_used_idx=52820 > >>>>> Mar 18 17:11:10 linux-b2ij kernel: [46337.246699] net eth7: rvq:avail->idx=36215 used->idx=35977 num_free=18 num_added=0 rvq->last_used_idx=35977 > >>>>> Mar 18 17:11:11 linux-b2ij kernel: [46337.901038] net eth7: dev_queue_xmit, qdisc->flags=4, qdisc->state deactiveed=0 > >>>>> Mar 18 17:11:12 linux-b2ij kernel: [46337.901042] net eth7: dev_queue_xmit, txq->state=1, stopped=1 > >>>>> > >>>>> Why compiler barrier not take effect in our case? Is compiler barrier depended on -O3 option? We use -O2 option. > >>>> compiler barrier always works regardless of the optimization option. > >>>> I don't get your story, but the key thing is, do you check the asm code? > >>>> If called from outside as an API, how is it possible it is optimized? > >>>> there is only one update to used->idx in that function. > >>> Do you mean rte_vhost_enqueue_burst also not need cast used->idx to volatile ? Why not remove it? > >> I checked the code. Seems we can remove. That is another issue. > >> For your issue, you meet problem, and submit this this patch, but i am a > >> bit confused it is the root cause. Do you check the asm code that > >> volatile is optimized? > >> > > I had wrote a demo try to find out the different between rte_compiler_barrier and volatile. > > It seems no any effect on rte_compiler_barrier(). > > Haifeng: > > I think it doesn't make too much sense to use volatile for local variables. > > In our rte_vhost_dequeue_burst, there is one memory write to the > used->idx, and there is compiler barrier to keep the order. > Besides, as an API, how could that memory write to be optimized as > register access? > > Even if you call rte_vhost_dequeue_burst in the same src file, which > means in the same translation unit, there is function call after which > has side effect, it still couldn't be optimized. > > Anyway, could we directly check the asm code of rte_vhost_dequeue_burst > to see whether it is optimized? Conclusion is not clear. Is this patch rejected?