From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id 742537E75 for ; Thu, 6 Nov 2014 14:46:23 +0100 (CET) Received: by mail-wi0-f177.google.com with SMTP id ex7so1566287wid.4 for ; Thu, 06 Nov 2014 05:55:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=GQXs8ctpfQDdsS37uDxdhd6/n+Tmz0jg9LlP8HSqsGQ=; b=AqH7hLz9UkyQYIgYdSbBbxxoiyse/HXGCakAKCBdGQNXjIpkzHIAQsb4AY5N78WKB6 Crq7zCbsIbIDEFC/kqH7s7GNn4OMHoRHjrvDJmqq3QEVVbxm2Ql9vQlnVf9S+83UvTUc 3Y1vAAcfuw3+D9Xx3bpOaRdf7PSjxPgE+Or3Gl+gd6JIfmST58N7PWTIOQgRxqtdfz89 eHCxSLde/z/1gi8/s2LCqjgu8NrR0QlnD4AZgEuWHfHetaAMW/dWcb/L00lLjNAXgXc8 Q4MyY55XBoj/Za5dXsGi7+zCwafFuSKkLoxL2WL1PoEMVpc5Vk50oJOvBWduXK4Dxkiy FaUg== X-Gm-Message-State: ALoCoQm/V5Tw6ygaEzfG3oiFSOb/nPYIjngNaAdYhDCBo7v/QGXjz6TR5PaILSzhCAIuXc0GOc7s X-Received: by 10.180.96.162 with SMTP id dt2mr36245253wib.66.1415282150425; Thu, 06 Nov 2014 05:55:50 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id bc1sm18899046wib.16.2014.11.06.05.55.49 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Nov 2014 05:55:49 -0800 (PST) From: Thomas Monjalon To: Ouyang Changchun Date: Thu, 06 Nov 2014 14:55:31 +0100 Message-ID: <13741309.jhnrGuo18k@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: <1414732757-7241-2-git-send-email-changchun.ouyang@intel.com> References: <1414381533-30370-1-git-send-email-changchun.ouyang@intel.com> <1414732757-7241-1-git-send-email-changchun.ouyang@intel.com> <1414732757-7241-2-git-send-email-changchun.ouyang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add vmdq rx mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Nov 2014 13:46:23 -0000 2014-10-31 13:19, Ouyang Changchun: > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -577,6 +577,7 @@ struct rte_eth_vmdq_rx_conf { > uint8_t default_pool; /**< The default pool, if applicable */ > uint8_t enable_loop_back; /**< Enable VT loop back */ > uint8_t nb_pool_maps; /**< We can have up to 64 filters/mappings */ > + uint32_t rx_mode; /**< RX mode for vmdq */ You are adding the field rx_mode in struct rte_eth_vmdq_rx_conf. So the comment "RX mode for vmdq" is not really informative :) It would be more interesting to explain which kind of value this field must contain. Something like "flags from ETH_VMDQ_ACCEPT_*". -- Thomas