From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6D3A45A5F; Mon, 30 Sep 2024 01:31:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 79A1E402DA; Mon, 30 Sep 2024 01:31:21 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2068.outbound.protection.outlook.com [40.107.100.68]) by mails.dpdk.org (Postfix) with ESMTP id 46137402CB for ; Mon, 30 Sep 2024 01:31:19 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OIFLYIUnwPIRcRw/i3QD5+wtLSFvVpwkX9XzZ3nnDZVLou67HW6E+4GPajs/onia+4b8LgrqkNveFD8BFmQBHO0dusZkk5K2GPKoc+inDNRzNSFSrVr7OxdHAwzBbea+MEe9vsY/38U2+sO4sPpEvIZ9R0+6ORz6HKepquhRclvoLEQDCLTPCg7PxsgxhleE4O0iu22v5PHkow/88stSsR7mI40eChfjodWafkIv7TXwoL3GAbPY/DysvPqY/xyAr5nWQwCPBSXkQalA2+0mR+eSDfH34SSIOqhuimwN8WwuDOFzuvdXIUD9ymOBcVGnBmac2d3LTJADejMBYu9WhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bIiDxiIbKjINXBOPc5OuL4ZQPLp3lW+BoAMXNYtwA6U=; b=d8h3/QWfkhYv0sS8uYPkO7XFqRbeeJ5a9dJrp0Lrh1ztcYaKeUXAsIrUj4/71F6/vO4Tk/rTlO1LtpkBm3yZKy7KTSlkmkGvIXHjD+fWCl1jUGx1Y+JzetdioZ22YWkViVVorQqPupP9+E8enMwjULgN0pku2l78AxlWZgFSHeJhBjz+8+c8qH/oDX1Wk+CF2IkHYVCIDNW7LP9PehGfy6dnwJ+6Nz1ENEIHYng0xBcRQnYjywqC8zojnmboWHgvunPjX8Nxzt15hFN3d7NKmteKKqhWOtS7c8YwZ5uOp9S4mSiM9U4xEqGmBjKGrqc72EqhTJQgkwzjJW81WUkuZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bIiDxiIbKjINXBOPc5OuL4ZQPLp3lW+BoAMXNYtwA6U=; b=5nfOltHxGSmw5SAyhkghga6dtDTUdoqFa28Irc+ogLaBE4w6BUpziWq5XuXudasY+eKP3OaAQ+hhIy/kAQL8dKoA30oq+HDUF3znhK/L1uak5VfQ5NIHx/ALYY7Ujlbt3aHbIljPV1OTXrlNnlnLEwz63xjDfW5DS/Xs45zB6m4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by MN2PR12MB4344.namprd12.prod.outlook.com (2603:10b6:208:26e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8005.26; Sun, 29 Sep 2024 23:31:16 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%4]) with mapi id 15.20.8005.024; Sun, 29 Sep 2024 23:31:16 +0000 Message-ID: <13747524-f073-4749-adbd-be1c7681dbcd@amd.com> Date: Mon, 30 Sep 2024 00:31:11 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 0/4] ethdev: rework config restore To: Dariusz Sosnowski , Thomas Monjalon , Andrew Rybchenko Cc: dev@dpdk.org, Bruce Richardson , Konstantin Ananyev References: <20240918092201.33772-1-dsosnowski@nvidia.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240918092201.33772-1-dsosnowski@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0236.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:315::15) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|MN2PR12MB4344:EE_ X-MS-Office365-Filtering-Correlation-Id: 79a5b078-9e0d-4372-7f27-08dce0ded07a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bi84YmJBQm9xSEk1ajhWRlFudjZoRUU2OVB2ZFNrQy9tbVVjWjRSR3pNVnR1?= =?utf-8?B?anJVRmJmY1BZenRTeklwckpNZUF3aUhEdHJZYTJHSXdZZGR4NDJ3NHJ4dTJy?= =?utf-8?B?WHJBRktvTS9wcjE0bXlQb3FiOFUvUTFzZGM1bVlvQXRiR3JvdFczZTFDaEFG?= =?utf-8?B?Ti8yOUwvSURBa1RUanpIWWNVNWFtS2U3VGJJOTNPT0svVnh6NXB4Y1doaEY3?= =?utf-8?B?Rk9GZXl6bWRWaURlNWJjUHRnVDMycUU0ZDBkN1FtbENUdEpySndZWGx2bzBq?= =?utf-8?B?WTJPN0hMZm1EdWtjL3QwU01mMllPNEo2R1oyc3h0ODRqS081ei9oOUMwUVp0?= =?utf-8?B?TitwVVRmZG5hMWprL0JBb1R1ekgyMVI5dk5KbWk5TDQ2b0RZWERVOTg0ek9n?= =?utf-8?B?RkxoalU2elFFY0NzZnB4NWUxaEg3dk5XclNzSDBUU0k5U0R2b3ZtVGdHQ0dK?= =?utf-8?B?S3NtdzlyTVN2d2cyYm1mNnBLSjZYdW9abnl0WmxDVjNUbEpOcDE5b2dEZ0VZ?= =?utf-8?B?QjVxeTNja0VPTmVzTldlTkc1bUNPSC9SVkpnSFVQTlhGR3l5K3d3bEkxZmNz?= =?utf-8?B?aGd0cEtPZmJGZ2czRUN1N0tSWGtGK3FidzlaVHIvMWp1VVI0RU4yV3Z2UDFG?= =?utf-8?B?WDNvZVZpQTI2M3Brck1JMlBRVVhyUWo5UjRhdDA0RExHRDVkZVFqZ3BteXkx?= =?utf-8?B?SzZhYjBaZEhWZWNFby82aUwxY2tJYnI1MlJQZk1DeUpZUGFOQndud0xrUk05?= =?utf-8?B?UERqQTd5TXZXaXR4SFNvYjRRNFh0b3VkWFViU25xWEI2T1lheUM3dkZyblZ3?= =?utf-8?B?QXc2ZnB2SFFzb2RQMlE0WTRXeUtYZGlZK0lZZzVJOUhpcXRabHJCMnhVc01h?= =?utf-8?B?SEQ1ZHZERDQyVVFpOFpTcDRBcjFvaFFRdEdxNnA1UXpmS3BhR0ROU29qenVO?= =?utf-8?B?SmViNnIydmx2d3oxOVdTTXpaOThLdXN5S1hQRERXQ3ZpM0gzalllSy9EUlp6?= =?utf-8?B?dFFVUDQ4TE1NWS9CL2V1cmVlYmx5aE5KMFdqREkvZENPNjV1N3ptTXNZcW5M?= =?utf-8?B?SVNQSk1NWVJTSlQ5ZmdzOHdabWhVWHFreStWa0taMEYrZEQ4L1g3aitVRUdV?= =?utf-8?B?OHo2YUxvbldSdHQ2UEFCMDhuVnVQR1FWTk53blp5SXdqV1pKYnRaTWxaMlR1?= =?utf-8?B?NC9Ub3VZckhqaWtrd0ExOHJaVVB5SytxRGZoNzJ2ZytEdGRjY0MyLzI5UGxn?= =?utf-8?B?bUxGK0R0ODBzSC9Kd1c1M2JuUTFnWHFLWVRua2FoellZY29sRXVveUxhS0JY?= =?utf-8?B?Z2pRTzBOVDBGWmFVZU5SdHhVMmRqTkV2NDYyaTRMTVFWam5jRFhUbGxnWjRs?= =?utf-8?B?N2NLOGFZRnJNZVppMTU4MDI3bkxMYm9HSUN0VmNkYnhjOUdOeURHcDFyM3JF?= =?utf-8?B?cTJYN25sVENuOFVSS1hma3BYN0NPUSszZVN3U2hlaEhsOWZVc1FVQm8waG9k?= =?utf-8?B?R0lERU5rNG9lYndUOVNDY0VPcFU3eEhZWU5EZkFxcUtvWmI1MGplSGFKci9y?= =?utf-8?B?TUFmT3J0VytPVzlSSjM1ZEpBRzgvSDZaamVEU2UxSmkrTytFK1h0VU84UFN3?= =?utf-8?B?UVBlcGZXb1EzS2Q4ZEFKMHB1SkNRcXM5SldKdDJsVW9OSnppWlY4R2NOd1Zr?= =?utf-8?B?TXF6TkZ1RHZMS3FJVEZYK0pVYThhVWdnZWRjbzZUblFuL2p0MXNSQnFnPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VDgwYlEzYjh6RlJkUnk0QTY2SkhoZ2YyRFNHY1NVYk50L2lUTEx0ZXhkZ2Jl?= =?utf-8?B?ak52d1lNTk4raFF5L0p0MHc0T2s2MUVDdDhhd0xRd2dpaGQvT3FzbVplZmVK?= =?utf-8?B?eXdXSmhZWlI5eTYxenoyTFpUUGxvTzJodmwzVi9JOEc2elAwVzJESTNCQ2Ro?= =?utf-8?B?SUxQWHZyZHllT2ppZUd1K2JiZzJNVHd0TXNXODNuWGxTK3h1UWlSVFh0NVFY?= =?utf-8?B?cFJQTk9CMC9FN0N0KzlSZU81c2ZkZzJWWlRhaDhqT3ljenRueVVENEZFT1FH?= =?utf-8?B?MmpJMzlCTEpKR2VtQkhkS2R0bzhFbXhkbUpabzZtWmlhcnpmSEJCbGIvUWNp?= =?utf-8?B?Vm55MVJJRUVaYlBTZDdTRjBxcElxR1BFRnNHcjNZQ3NQbmFzaDYyR2lYbWVK?= =?utf-8?B?MUwvNmtxQ0dGVTg1QUFxNDM2Wk5UYkV4cTkzT3MwdDJDTnZNVC9udmpreVdt?= =?utf-8?B?SjJLdmpkUldhb1hzbnNsTzFxSk1CeUNBRHh5anEvOFA1dkt2MHZyZGpIc2FJ?= =?utf-8?B?R3JOOHBRWmY4dkxnNHpZdkQwOG1aRjZkZGRXNFAvVCsvVVo3MGtzMC9uVzZ2?= =?utf-8?B?RnVrVXRPaVJoTlIzL2VlNGErWDdYNk9XajJLQ1hSdHRsaUkyY3VLRytiRUMw?= =?utf-8?B?eGRiUFhDOGovekhKWWtjK0h3QURqQWtKb3BvMHR4WForT3ErUnkvT0tEVEVH?= =?utf-8?B?M2VhUDFxMmVzY2ttZ2FSL3B2Z1lmQXJ0cU5ZUkpoa0NLV0JCelljc0hNRzRa?= =?utf-8?B?bTREbTJrNmxNSmVlOFF0WCtzVklpU1ExM0VNR0tRams1ai82UXdrSXdxam5F?= =?utf-8?B?MmptdkxQSjEyc01qVkJEU3dSZkx3cXI0azhYbGpsSlRSdkZRMzJFU1BkZ1g4?= =?utf-8?B?d3dsM1R1bC9JclY1YStZZStPU2UxZExjS3Zib2JHRHZqSC85TmI1SlRqVE9Y?= =?utf-8?B?YnZVNjVtcEVPNHJNdDg5OERuaDVYVHNzeDU2aUJrbnJnUW9IREdRTGFackhn?= =?utf-8?B?VUpVaXFjMHBFT3lmTm85TFp0VFRPcFVxcnBPRUlRYlV2Wm1USGVJK3VpVmI2?= =?utf-8?B?Z2k4MDVsOWZ0bHZXN2dESGxkN0N1UUx3UmhReFdwQUlObEh2cmZjZGlydmNH?= =?utf-8?B?TGlpK0lYSS9kRzA1S0JIU2pRaW9NNlRKQi9RSFJzajAwbGVJVFRZNjFKOUlT?= =?utf-8?B?YzNXdVZlaktzbE0zWFlvemRLSytKTGhxTUROUkxSVG95YlVlNEtFeFl0ZTE3?= =?utf-8?B?eVAzTE0wSTUzbXdLcmI2c09mWnoxc2VRNTV2TUY0RFUvRE1GaUVLT2JzMm5t?= =?utf-8?B?SHlKcll4SmlndUlIN1ZJeDM0cStCSmxLc00wMUZodk56aEhxVnBWc25hcjVa?= =?utf-8?B?UnJZbVh1VDBpN1lrTGx3TXZOWXorUXFoQUtJbzlxczhGa003MDZYbkVya0ZY?= =?utf-8?B?ckxkK0dMVTRhMjUrNWxmTnJpUFU2bXpHN3RXdXYrcHkzejcyWUd0bEhQQnFv?= =?utf-8?B?UFRQV3FlZEpSWXJnRUp0L3BZSmRkb2diTzlVU2h4bms1MGVSYW9SVVd2Vklv?= =?utf-8?B?VWd0NmtjU2lxRzJEUVlFNEZnQi94OWgvRFBqaHdjTys2bUxDNWo3cmphN1lt?= =?utf-8?B?M21WenA0bk1HeGN0RGlvM1k5Q2YzemZIOU1IZjlHNkNKaTF0WkVpdkZEYUQy?= =?utf-8?B?ck1zQUU1SnJSNGxDMndJQU03TUEyZXdpcENQSGtabXhGRmJLSVFYMHFzL3RP?= =?utf-8?B?NzN4ODFJOGVLL2YrcUMvQnhMU1pjcTZkd0JCMnVCNVF1RUhPSlB1TkMyTTBj?= =?utf-8?B?TndLL2EwRDl6bU5NZlJhRVU3RmJJYWZwQllmK1NjN1MzM0ZRd0YyMG0rQlY5?= =?utf-8?B?UFNucGZhSXU4ZXdXVmNlTDdTNFNOU3VSL01QTXkwaXJwemFJdW16TjQ4MTRa?= =?utf-8?B?WktsOFZSNUtEb2hpbXFHWkx1aFY4TmNwWW01S1d3MkZCSkJTNTYyQ29wOG9w?= =?utf-8?B?c3hBaFFsU1hmQnh3VDFaSStCOFBtUTlPb3A0L0FrRTlZQkY2N21qMG11cHo5?= =?utf-8?B?N1NkaU55WXRCRlYvdko0Tk9Bb2dsMXA1V2E1S3ExbnN0MUJhRklEUkhRQkxP?= =?utf-8?Q?WRSTs60s+ybdoL2fCOUDEvBmf?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 79a5b078-9e0d-4372-7f27-08dce0ded07a X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2024 23:31:16.7103 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uzhM8AHnA4LyusLdP5ea05xZkeAsGuqeJlRmDuF9VRVJwTQGjpmrKiWs9RkqaaJB X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4344 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/18/2024 10:21 AM, Dariusz Sosnowski wrote: > Hi all, > > We have been working on optimizing the latency of calls to rte_eth_dev_start(), > on ports spawned by mlx5 PMD. Most of the work requires changes in the implementation of > .dev_start() PMD callback, but I also wanted to start a discussion regarding > configuration restore. > > rte_eth_dev_start() does a few things on top of calling .dev_start() callback: > > - Before calling it: > - eth_dev_mac_restore() - if device supports RTE_ETH_DEV_NOLIVE_MAC_ADDR; > - After calling it: > - eth_dev_mac_restore() - if device does not support RTE_ETH_DEV_NOLIVE_MAC_ADDR; > - restore promiscuous config > - restore all multicast config > > eth_dev_mac_restore() iterates over all known MAC addresses - > stored in rte_eth_dev_data.mac_addrs array - and calls > .mac_addr_set() and .mac_addr_add() callbacks to apply these MAC addresses. > > Promiscuous config restore checks if promiscuous mode is enabled or not, > and calls .promiscuous_enable() or .promiscuous_disable() callback. > > All multicast config restore checks if all multicast mode is enabled or not, > and calls .allmulticast_enable() or .allmulticast_disable() callback. > > Callbacks are called directly in all of these cases, to bypass the checks > for applying the same configuration, which exist in relevant APIs. > Checks are bypassed to force drivers to reapply the configuration. > > Let's consider what happens in the following sequence of API calls. > > 1. rte_eth_dev_configure() > 2. rte_eth_tx_queue_setup() > 3. rte_eth_rx_queue_setup() > 4. rte_eth_promiscuous_enable() > - Call dev->dev_ops->promiscuous_enable() > - Stores promiscuous state in dev->data->promiscuous > 5. rte_eth_allmulticast_enable() > - Call dev->dev_ops->allmulticast_enable() > - Stores allmulticast state in dev->data->allmulticast > 6. rte_eth_dev_start() > - Call dev->dev_ops->dev_start() > - Call dev->dev_ops->mac_addr_set() - apply default MAC address > - Call dev->dev_ops->promiscuous_enable() > - Call dev->dev_ops->allmulticast_enable() > > Even though all configuration is available in dev->data after step 5, > library forces reapplying this configuration in step 6. > > In mlx5 PMD case all relevant callbacks require communication with the kernel driver, > to configure the device (mlx5 PMD must create/destroy new kernel flow rules and/or > change netdev config). > > mlx5 PMD handles applying all configuration in .dev_start(), so the following forced callbacks > force additional communication with the kernel. The same configuration is applied multiple times. > > As an optimization, mlx5 PMD could check if a given configuration was applied, > but this would duplicate the functionality of the library > (for example rte_eth_promiscuous_enable() does not call the driver > if dev->data->promiscuous is set). > > Question: Since all of the configuration is available before .dev_start() callback is called, > why ethdev library does not expect .dev_start() to take this configuration into account? > In other words, why library has to reapply the configuration? > > I could not find any particular reason why configuration restore exists > as part of the process (it was in the initial DPDK commit). > My assumption is .dev_stop() cause these values reset in some devices, so .dev_start() restores them back. @Bruce or @Konstantin may remember the history. But I agree this is device specific behavior, and can be managed by what device requires. > The patches included in this RFC, propose a mechanism which would help with managing which drivers > rely on forceful configuration restore. > Drivers could advertise if forceful configuration restore is needed through > `RTE_ETH_DEV_*_FORCE_RESTORE` device flag. If this flag is set, then the driver in question > requires ethdev to forcefully restore configuration. > OK to use flag for it, but not sure about using 'dev_info->dev_flags' (RTE_ETH_DEV_*) for this, as this flag is shared with user and this is all dpdk internal. What about to have a dedicated flag for it? We can have a dedicated set of flag values for restore. Also perhaps we have go into details what needs to be restored after 'stop' and what needs to be restored after 'reset' and use similar mechanism etc... > This way, if we would conclude that it makes sense for .dev_start() to handle all > starting configuration aspects, we could track which drivers still rely on configuration restore. > > Dariusz Sosnowski (4): > ethdev: rework config restore > ethdev: omit promiscuous config restore if not required > ethdev: omit all multicast config restore if not required > ethdev: omit MAC address restore if not required > > lib/ethdev/rte_ethdev.c | 39 ++++++++++++++++++++++++++++++++++----- > lib/ethdev/rte_ethdev.h | 18 ++++++++++++++++++ > 2 files changed, 52 insertions(+), 5 deletions(-) > > -- > 2.39.5 >