From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] mem: fix include in rte_malloc
Date: Wed, 31 Jul 2013 11:18:45 +0200 [thread overview]
Message-ID: <1375262325-5348-1-git-send-email-thomas.monjalon@6wind.com> (raw)
In-Reply-To: <581E2E1085FAEF45B48CF8A139824CF804E64C5644@ACNMAIL1.ACN.ADVANTECH.CORP>
The function rte_malloc_virt2phy has a dependency on rte_memory.h:
phys_addr_t must be defined.
The dependency handling for apps was wrong in the commit 8c86825cbf.
Let's revert this part.
Reported-by: Jia Sui <jia.sui@advantech.com.cn>
Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
app/test/test_hash.c | 2 +-
app/test/test_hash_perf.c | 2 +-
app/test/test_memcpy.c | 1 -
app/test/test_memcpy_perf.c | 1 -
lib/librte_malloc/rte_malloc.h | 1 +
5 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/app/test/test_hash.c b/app/test/test_hash.c
index 4de8cb1..5437e05 100644
--- a/app/test/test_hash.c
+++ b/app/test/test_hash.c
@@ -41,10 +41,10 @@
#include <sys/queue.h>
#include <rte_common.h>
+#include <rte_malloc.h>
#include <rte_cycles.h>
#include <rte_random.h>
#include <rte_memory.h>
-#include <rte_malloc.h>
#include <rte_memzone.h>
#include <rte_tailq.h>
#include <rte_eal.h>
diff --git a/app/test/test_hash_perf.c b/app/test/test_hash_perf.c
index 311c2bd..8a0feb3 100644
--- a/app/test/test_hash_perf.c
+++ b/app/test/test_hash_perf.c
@@ -42,10 +42,10 @@
#include <rte_common.h>
#include <rte_lcore.h>
+#include <rte_malloc.h>
#include <rte_cycles.h>
#include <rte_random.h>
#include <rte_memory.h>
-#include <rte_malloc.h>
#include <rte_memzone.h>
#include <rte_tailq.h>
#include <rte_eal.h>
diff --git a/app/test/test_memcpy.c b/app/test/test_memcpy.c
index 729a2ff..d7777a8 100644
--- a/app/test/test_memcpy.c
+++ b/app/test/test_memcpy.c
@@ -41,7 +41,6 @@
#include <cmdline_parse.h>
#include <rte_cycles.h>
#include <rte_random.h>
-#include <rte_memory.h>
#include <rte_malloc.h>
#include <rte_memcpy.h>
diff --git a/app/test/test_memcpy_perf.c b/app/test/test_memcpy_perf.c
index 1e75f53..236b295 100644
--- a/app/test/test_memcpy_perf.c
+++ b/app/test/test_memcpy_perf.c
@@ -41,7 +41,6 @@
#include <cmdline_parse.h>
#include <rte_cycles.h>
#include <rte_random.h>
-#include <rte_memory.h>
#include <rte_malloc.h>
#include <rte_memcpy.h>
diff --git a/lib/librte_malloc/rte_malloc.h b/lib/librte_malloc/rte_malloc.h
index e68187a..fe85689 100644
--- a/lib/librte_malloc/rte_malloc.h
+++ b/lib/librte_malloc/rte_malloc.h
@@ -42,6 +42,7 @@
*/
#include <stddef.h>
+#include <rte_memory.h>
#ifdef __cplusplus
extern "C" {
--
1.7.10.4
next prev parent reply other threads:[~2013-07-31 9:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 19:39 [dpdk-dev] NIC Stops Transmitting Scott Talbert
2013-07-26 19:53 ` Stephen Hemminger
2013-07-26 20:04 ` Scott Talbert
2013-07-26 22:31 ` jinho hwang
2013-07-26 23:26 ` Scott Talbert
2013-07-29 17:02 ` Scott Talbert
2013-07-31 2:43 ` [dpdk-dev] miss include file in DPDK 1.3.1r2 Jia.Sui
2013-07-31 9:18 ` Thomas Monjalon [this message]
2013-07-31 11:36 ` [dpdk-dev] [PATCH] mem: fix include in rte_malloc didier.pallard
2013-07-31 11:48 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375262325-5348-1-git-send-email-thomas.monjalon@6wind.com \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).