From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99003459BF; Tue, 17 Sep 2024 17:49:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 379C440280; Tue, 17 Sep 2024 17:49:38 +0200 (CEST) Received: from fout6-smtp.messagingengine.com (fout6-smtp.messagingengine.com [103.168.172.149]) by mails.dpdk.org (Postfix) with ESMTP id A82F940261 for ; Tue, 17 Sep 2024 17:49:36 +0200 (CEST) Received: from phl-compute-09.internal (phl-compute-09.phl.internal [10.202.2.49]) by mailfout.phl.internal (Postfix) with ESMTP id 303CE1380233; Tue, 17 Sep 2024 11:49:36 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-09.internal (MEProxy); Tue, 17 Sep 2024 11:49:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1726588176; x=1726674576; bh=ugMI9h8hPW/YgisfLZcFXppu4FvrX5U4/Pgm3WIs3+s=; b= NqT9a6crPW39ifbjsjJ6Fpajy3OmpkUDJlKGjEQvf7kciKQZdrSeD+2g9GnTomv+ YE8ZCDTTIWJH46fzyUZWhC2wM0MZlFXZTjXXxiWQpm7te01JF9fdTJjJXMNcZWTu tMXaTR7+ptBngOIFg5WElQ/JIUtr2wfeYbn9f6uNTBvh0gRZUmak0Sp5h3S0hg+l dcXnZEbaNPte9XApfnCqR6Isd2OQtXLCQnzz7mZFwVtDQhs5zM/0/iSg2jc3qLmj fLoONteePcGf4NemHZTix7s0nMr8LtV5SpYEAgsHROpN7y+pJSMm8ua2D1YcIKuE KOXG5KGIe5uYl/bVF1//rQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1726588176; x= 1726674576; bh=ugMI9h8hPW/YgisfLZcFXppu4FvrX5U4/Pgm3WIs3+s=; b=Y pXQSljDbnDKGAhv0dZwX+xdL+gh6f1v4sx9VIMTBquhA9VuUXryEizCUmvN3E5rT EBov4xuYQ408+AnMd9VXbTJmdP3N6u3kcaUCnKcUunxRiH1ZqgJMh991xqYhQM4X 6N1OUDccXl43LwMnQwDCb+0wTDc8AELbv4zJKtzkHgJdcnl1ZOpyj62B0N5WwqXa FLyTLLF9MnT3IVS4xglQkfbUfewAOCUCs56b9nmCYCL7CSv2g4aenfI+vfziVBee p+PQFQoOTvp2tsluQLk/FJ3XA5zyzwQBOmEJcRjVGMPpsMLblWhteAYobiH6dGxc KHuJf7Xtjics33s0UbxkA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudekjedgleeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthfuredttddtjeen ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeeuffevtefftdeutdefhffftdduveet ffekgeelfeelgffhheejieettdevjeejveenucffohhmrghinhepghhithhhuhgsrdgtoh hmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthdpnhgspghrtghpthhtohepfedpmhhouggvpe hsmhhtphhouhhtpdhrtghpthhtohepshhtvghphhgvnhesnhgvthifohhrkhhplhhumhgs vghrrdhorhhgpdhrtghpthhtohepsghruhgtvgdrrhhitghhrghrughsohhnsehinhhtvg hlrdgtohhmpdhrtghpthhtohepuggvvhesughpughkrdhorhhg X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 17 Sep 2024 11:49:35 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger , Bruce Richardson Cc: dev@dpdk.org Subject: Re: [PATCH] devtools: fix false positive from checkpatch Date: Tue, 17 Sep 2024 17:49:33 +0200 Message-ID: <13789507.uLZWGnKmhe@thomas> In-Reply-To: References: <20240917153421.6552-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 17/09/2024 17:45, Bruce Richardson: > On Tue, Sep 17, 2024 at 08:34:21AM -0700, Stephen Hemminger wrote: > > The codespell dictionary has "stdio" in its bad word list, > > but stdio.h is often used in DPDK code and creates bogus false > > postitives from checkpatch. > > > > Also add a check to the parameters to build-dict.sh so it > > gives usage error if parameter is missing or does not point > > to the codespell git clone. > > > > Signed-off-by: Stephen Hemminger > > --- > > devtools/build-dict.sh | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/devtools/build-dict.sh b/devtools/build-dict.sh > > index a8cac49029..96786d2c53 100755 > > --- a/devtools/build-dict.sh > > +++ b/devtools/build-dict.sh > > @@ -6,6 +6,10 @@ > > > > # path to local clone of https://github.com/codespell-project/codespell.git > > codespell_path=$1 > > +if [ ! -d "$codespell_path/codespell_lib/data" ]; then > > + echo "Usage: $0 " > > + exit 1 > > +fi > > > > # concatenate codespell dictionaries, except GB/US one > > for suffix in .txt _code.txt _informal.txt _names.txt _rare.txt _usage.txt ; do > > @@ -17,6 +21,7 @@ sed '/^..->/d' | > > sed '/^uint->/d' | > > sed "/^doesn'->/d" | > > sed '/^wasn->/d' | > > +sed '/stdio->/d' | > > > Seems a good idea. However, why use "stdio" alone rather than using the > full "stdio.h" header name. Do we expect "stdio" to be used much in > comments or otherwise? The dictionary doesn't know stdio.h You could start with a caret to mimic other entries.