DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [vmxnet3-usermap PATCH] kmod: remove useless debug hack
Date: Fri, 27 Sep 2013 17:07:27 +0200	[thread overview]
Message-ID: <1380294447-27932-1-git-send-email-thomas.monjalon@6wind.com> (raw)

The PCI address was stored in unused variables of the netdev.
It has been introduced in commit 75ab826258c1099e2e56ec48fd17dfa5591111cd.
But it is a useless hack.

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 kmod/vmxnet3_drv.c |   12 ------------
 1 file changed, 12 deletions(-)

diff --git a/kmod/vmxnet3_drv.c b/kmod/vmxnet3_drv.c
index 0443ad6..fc51f7e 100644
--- a/kmod/vmxnet3_drv.c
+++ b/kmod/vmxnet3_drv.c
@@ -3928,9 +3928,6 @@ vmxnet3_probe_device(struct pci_dev *pdev,
 	int size;
 	int num_tx_queues = num_tqs[atomic_read(&devices_found)];
 	int num_rx_queues = num_rqs[atomic_read(&devices_found)];
-	/* Parse device address on the PCIe bus. */
-	uint16_t dom = 0;
-	uint8_t bus = 0, dev = 0, func = 0;
 
 #ifdef VMXNET3_RSS
 	if ((atomic_read(&devices_found) < VMXNET3_SHM_MAX_DEVICES &&
@@ -4171,15 +4168,6 @@ vmxnet3_probe_device(struct pci_dev *pdev,
 	vmxnet3_check_link(adapter, FALSE);
 	atomic_inc(&devices_found);
 
-	/* Fill PCIe bus address info. */
-	sscanf(dev_name(adapter->netdev->dev.parent),
-	       "%04hx:%02hhx:%02hhx.%hhd",
-	       &dom, &bus, &dev, &func);
-
-	adapter->netdev->mem_start = (dom<<16)|(bus<<8)|dev;
-	adapter->netdev->mem_end = (dom<<16)|(bus<<8)|dev;
-	adapter->netdev->if_port = func;
-
 	return 0;
 
 err_register:
-- 
1.7.10.4

             reply	other threads:[~2013-09-27 15:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-27 15:07 Thomas Monjalon [this message]
2013-09-27 15:13 ` Damien Millescamps
2013-09-30  9:24   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1380294447-27932-1-git-send-email-thomas.monjalon@6wind.com \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).