From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f174.google.com (mail-we0-f174.google.com [74.125.82.174]) by dpdk.org (Postfix) with ESMTP id D1EC11F3 for ; Fri, 27 Sep 2013 17:06:48 +0200 (CEST) Received: by mail-we0-f174.google.com with SMTP id q58so2794182wes.19 for ; Fri, 27 Sep 2013 08:07:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id; bh=tGkS8c1QHA44GyjzmibQHrkFa5yvtMv+U9K448Uml4c=; b=ErF9f1K+Q6qi1suAvjpyBMPBch2RhybX3YIYuGj07109jz7Tfx0/4iITYRJGaGRFXj Qx48WRfNt12eaBrBjwIAtSY71OfUiPCu2H8YruypnXkGWClmT4mGqUMMzq6OU9pUqVJq xLEQCQj30NLW9mVcYzRMUAQAii+vcLWknHSCTHHFl4kxLPM8podGZzWzsjAQ5kmyrRwX NT221getigCQ5q2rcMJmiHenlM5cCI1fG/UkAQmisFeCj8lgeVEjYCuA5TVXSSk30KMo Wkzu5Rxm+pg9IJJt4t8aS7swojdlq7q0anS6JQmheyb8Qq+Mq3aQXRzXN3kpDlnR2rsR rNDQ== X-Gm-Message-State: ALoCoQlM5+ICBa0HIu6A6XC+j2A9qGpEfJ9L9IDT7KwNAahmy/HYlqK6fs93PMiTstJdE5iwkjbJ X-Received: by 10.180.89.42 with SMTP id bl10mr2957899wib.47.1380294449774; Fri, 27 Sep 2013 08:07:29 -0700 (PDT) Received: from 6wind.com (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id b13sm39426301wic.9.1969.12.31.16.00.00 (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 27 Sep 2013 08:07:29 -0700 (PDT) Received: by 6wind.com (sSMTP sendmail emulation); Fri, 27 Sep 2013 17:07:27 +0200 From: Thomas Monjalon To: dev@dpdk.org Date: Fri, 27 Sep 2013 17:07:27 +0200 Message-Id: <1380294447-27932-1-git-send-email-thomas.monjalon@6wind.com> X-Mailer: git-send-email 1.7.10.4 Subject: [dpdk-dev] [vmxnet3-usermap PATCH] kmod: remove useless debug hack X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Sep 2013 15:06:49 -0000 The PCI address was stored in unused variables of the netdev. It has been introduced in commit 75ab826258c1099e2e56ec48fd17dfa5591111cd. But it is a useless hack. Signed-off-by: Thomas Monjalon --- kmod/vmxnet3_drv.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/kmod/vmxnet3_drv.c b/kmod/vmxnet3_drv.c index 0443ad6..fc51f7e 100644 --- a/kmod/vmxnet3_drv.c +++ b/kmod/vmxnet3_drv.c @@ -3928,9 +3928,6 @@ vmxnet3_probe_device(struct pci_dev *pdev, int size; int num_tx_queues = num_tqs[atomic_read(&devices_found)]; int num_rx_queues = num_rqs[atomic_read(&devices_found)]; - /* Parse device address on the PCIe bus. */ - uint16_t dom = 0; - uint8_t bus = 0, dev = 0, func = 0; #ifdef VMXNET3_RSS if ((atomic_read(&devices_found) < VMXNET3_SHM_MAX_DEVICES && @@ -4171,15 +4168,6 @@ vmxnet3_probe_device(struct pci_dev *pdev, vmxnet3_check_link(adapter, FALSE); atomic_inc(&devices_found); - /* Fill PCIe bus address info. */ - sscanf(dev_name(adapter->netdev->dev.parent), - "%04hx:%02hhx:%02hhx.%hhd", - &dom, &bus, &dev, &func); - - adapter->netdev->mem_start = (dom<<16)|(bus<<8)|dev; - adapter->netdev->mem_end = (dom<<16)|(bus<<8)|dev; - adapter->netdev->if_port = func; - return 0; err_register: -- 1.7.10.4