From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bk0-f46.google.com (mail-bk0-f46.google.com [209.85.214.46]) by dpdk.org (Postfix) with ESMTP id 8131A156 for ; Tue, 19 Nov 2013 14:02:48 +0100 (CET) Received: by mail-bk0-f46.google.com with SMTP id u15so1700862bkz.5 for ; Tue, 19 Nov 2013 05:03:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id; bh=i9f1pUg2g+at9sewB3Q12QjMBnbNbv3vCGsO573B5gY=; b=QbBTpGqH7jItj1kLAsw4eqWJRHAZ09Cuseu+UNyfQf8vDRkX0BHpLBkgiW3SThFkCp M6cvTN6hz1V40jcxmA2HRQje0FhXMjbkfSm5i1OHTC83h7PtzVhJBvVGGolydKh4nWSO m8tfAVSkMaIP+CAaQH79obkerrS/JjQEn+4e+qqXjUA8+Zu59jpzsoVYIX2werAHlh0I 2dpGkS2pbTK2tmhnuIcXJRjmL+FVkI2AAUwlE/vozNlEO561pLfE6JUG0Tv+F9VM/dcR FRiqhm+9SJonopkNbzn40W6zhH6RZXqfx8OQASzSerLJD1oJPCfQAZ31Ah5H/mW/2T8C kVjg== X-Gm-Message-State: ALoCoQleplz61+AoIMQ9ZJ+gqn6siwAtZVNl9gMeSIwVPhHFWNFP138e2fZs2BGnBCIbgfRUndLe X-Received: by 10.204.123.199 with SMTP id q7mr16690296bkr.10.1384866225235; Tue, 19 Nov 2013 05:03:45 -0800 (PST) Received: from bolet.dev.6wind.com. (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id j13sm5594628bky.0.2013.11.19.05.03.43 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Nov 2013 05:03:44 -0800 (PST) From: Maxime Leroy To: dev@dpdk.org Date: Tue, 19 Nov 2013 14:03:34 +0100 Message-Id: <1384866215-18420-1-git-send-email-maxime.leroy@6wind.com> X-Mailer: git-send-email 1.7.10.4 Subject: [dpdk-dev] [PATCH 1/2] igb/ixgbe: ETH_MQ_RX_NONE should disable RSS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Nov 2013 13:02:48 -0000 As explained in rte_ethdev.h, ETH_MQ_RX_NONE allows to not choose RSS, DCB or VMDQ mode to select the rx queues. But the igb/ixgbe code always select RSS mode with ETH_MQ_RX_NONE. This patch fixes this incoherence between the api and the source code. Signed-off-by: Maxime Leroy --- lib/librte_pmd_e1000/igb_rxtx.c | 4 ++-- lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/librte_pmd_e1000/igb_rxtx.c b/lib/librte_pmd_e1000/igb_rxtx.c index f785d9f..641ceea 100644 --- a/lib/librte_pmd_e1000/igb_rxtx.c +++ b/lib/librte_pmd_e1000/igb_rxtx.c @@ -1745,8 +1745,6 @@ igb_dev_mq_rx_configure(struct rte_eth_dev *dev) */ if (dev->data->nb_rx_queues > 1) switch (dev->data->dev_conf.rxmode.mq_mode) { - case ETH_MQ_RX_NONE: - /* if mq_mode not assign, we use rss mode.*/ case ETH_MQ_RX_RSS: igb_rss_configure(dev); break; @@ -1754,6 +1752,8 @@ igb_dev_mq_rx_configure(struct rte_eth_dev *dev) /*Configure general VMDQ only RX parameters*/ igb_vmdq_rx_hw_configure(dev); break; + case ETH_MQ_RX_NONE: + /* if mq_mode is none, disable rss mode.*/ default: igb_rss_disable(dev); break; diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c index 0f7be95..e1b90f9 100644 --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c @@ -3217,8 +3217,6 @@ ixgbe_dev_mq_rx_configure(struct rte_eth_dev *dev) */ if (dev->data->nb_rx_queues > 1) switch (dev->data->dev_conf.rxmode.mq_mode) { - case ETH_MQ_RX_NONE: - /* if mq_mode not assign, we use rss mode.*/ case ETH_MQ_RX_RSS: ixgbe_rss_configure(dev); break; @@ -3231,6 +3229,8 @@ ixgbe_dev_mq_rx_configure(struct rte_eth_dev *dev) ixgbe_vmdq_rx_hw_configure(dev); break; + case ETH_MQ_RX_NONE: + /* if mq_mode is none, disable rss mode.*/ default: ixgbe_rss_disable(dev); } else -- 1.7.10.4