From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bk0-f46.google.com (mail-bk0-f46.google.com [209.85.214.46]) by dpdk.org (Postfix) with ESMTP id 0FBC6156 for ; Tue, 19 Nov 2013 14:02:48 +0100 (CET) Received: by mail-bk0-f46.google.com with SMTP id u15so1700875bkz.5 for ; Tue, 19 Nov 2013 05:03:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=3IM/g+Uf9z1KNLqtcOeviSK8H+DkYTCwlU7ap4k10oc=; b=X+p/cw9/lxlgn8KimetBZ/wBPCAGGShp/50BVV+NPzMdgOgpjU4ZUSpIuQYpgDow9j XYmljGLF3S8kHxLUIo6oeojDDU6Mp4m5726aXO2D/KzdIPWAQeDl6iL7ZpKIyRvamXRz 1kUSUX9hxabXJmkz+88T2ikVj9/9QLTdzYqRjDVMzOIOAqZXvJM20GwgZ88bp5+WXo2N a6daGiU37P7+KN9vYqhQzKjIcaczkJy1qx+5vzLTStPtya7l0eVSPqp+TXUMoJX4aImR 9PzIYdotLXDxoTo1Fq0GH+cT1dp3NcdO8L2ga32vQtysWGmX9Aru0apQK0Nw5Xazu44Z H16Q== X-Gm-Message-State: ALoCoQm6FvH5SwjfZ3IqmHZvf/+JJWAqsi/lV1bXrNB4MMwxfeXqi2dSsWTCVk2VViyso1C2jhVR X-Received: by 10.204.172.17 with SMTP id j17mr24940bkz.64.1384866226570; Tue, 19 Nov 2013 05:03:46 -0800 (PST) Received: from bolet.dev.6wind.com. (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id j13sm5594628bky.0.2013.11.19.05.03.45 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Nov 2013 05:03:45 -0800 (PST) From: Maxime Leroy To: dev@dpdk.org Date: Tue, 19 Nov 2013 14:03:35 +0100 Message-Id: <1384866215-18420-2-git-send-email-maxime.leroy@6wind.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1384866215-18420-1-git-send-email-maxime.leroy@6wind.com> References: <1384866215-18420-1-git-send-email-maxime.leroy@6wind.com> Subject: [dpdk-dev] [PATCH 2/2] igb/ixgbe: allow RSS with only one Rx queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Nov 2013 13:02:49 -0000 We should be able to enable RSS with one Rx queue. RSS hash can be useful independently of the number of queues. Applications can use RSS hash to identify different flows. Signed-off-by: Maxime Leroy --- lib/librte_pmd_e1000/igb_rxtx.c | 7 ++----- lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 7 ++----- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/lib/librte_pmd_e1000/igb_rxtx.c b/lib/librte_pmd_e1000/igb_rxtx.c index 641ceea..8c1e2cc 100644 --- a/lib/librte_pmd_e1000/igb_rxtx.c +++ b/lib/librte_pmd_e1000/igb_rxtx.c @@ -1743,8 +1743,7 @@ igb_dev_mq_rx_configure(struct rte_eth_dev *dev) /* * SRIOV inactive scheme */ - if (dev->data->nb_rx_queues > 1) - switch (dev->data->dev_conf.rxmode.mq_mode) { + switch (dev->data->dev_conf.rxmode.mq_mode) { case ETH_MQ_RX_RSS: igb_rss_configure(dev); break; @@ -1757,9 +1756,7 @@ igb_dev_mq_rx_configure(struct rte_eth_dev *dev) default: igb_rss_disable(dev); break; - } - else - igb_rss_disable(dev); + } } return 0; diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c index e1b90f9..ae9eda8 100644 --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c @@ -3215,8 +3215,7 @@ ixgbe_dev_mq_rx_configure(struct rte_eth_dev *dev) * SRIOV inactive scheme * any DCB/RSS w/o VMDq multi-queue setting */ - if (dev->data->nb_rx_queues > 1) - switch (dev->data->dev_conf.rxmode.mq_mode) { + switch (dev->data->dev_conf.rxmode.mq_mode) { case ETH_MQ_RX_RSS: ixgbe_rss_configure(dev); break; @@ -3232,9 +3231,7 @@ ixgbe_dev_mq_rx_configure(struct rte_eth_dev *dev) case ETH_MQ_RX_NONE: /* if mq_mode is none, disable rss mode.*/ default: ixgbe_rss_disable(dev); - } - else - ixgbe_rss_disable(dev); + } } else { switch (RTE_ETH_DEV_SRIOV(dev).active) { /* -- 1.7.10.4