From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id BB8B7A0524;
	Tue, 13 Apr 2021 06:46:34 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 409F7160A7E;
	Tue, 13 Apr 2021 06:46:34 +0200 (CEST)
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by mails.dpdk.org (Postfix) with ESMTP id 8CDD9160A7D
 for <dev@dpdk.org>; Tue, 13 Apr 2021 06:46:32 +0200 (CEST)
IronPort-SDR: mCVF7l/R074EOMr2uOOazYMqTbePJb1+8256472fBop0yNoYIIuxXWKziMOnLO3m6Tj1nqWwwR
 gMHd3s8T6v2g==
X-IronPort-AV: E=McAfee;i="6200,9189,9952"; a="255663535"
X-IronPort-AV: E=Sophos;i="5.82,218,1613462400"; d="scan'208";a="255663535"
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 12 Apr 2021 21:46:31 -0700
IronPort-SDR: xwKRcP4KgKFb8fNBPDJn23BpTlb0dtDv59e/lltIfUNkYT5XnVOayMUMO2Rr4oTM7AsdUj4oi8
 g6vjszlDTDhA==
X-IronPort-AV: E=Sophos;i="5.82,218,1613462400"; d="scan'208";a="451789997"
Received: from rmenon-desk.amr.corp.intel.com (HELO [10.166.30.253])
 ([10.166.30.253])
 by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 12 Apr 2021 21:46:30 -0700
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, dev@dpdk.org
References: <20210407222249.6729-1-dmitry.kozliuk@gmail.com>
 <20210410224732.20234-1-dmitry.kozliuk@gmail.com>
From: Ranjit Menon <ranjit.menon@intel.com>
Message-ID: <138b06d2-ab7e-704e-5f9f-d369f2490b45@intel.com>
Date: Mon, 12 Apr 2021 21:46:27 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.1
MIME-Version: 1.0
In-Reply-To: <20210410224732.20234-1-dmitry.kozliuk@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Subject: Re: [dpdk-dev] [PATCH v9 0/4] eal/windows: do not expose POSIX
 symbols
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Dmitry,

On 4/10/2021 3:47 PM, Dmitry Kozlyuk wrote:
> On Windows, EAL contains two sets of functions and macros for POSIX
> compatibility: <rte_os.h> and a networking shim (socket headers).
> The latter conflicts with system headers and should not exist.
> Exposing the former from EAL can break consumer own POSIX compatibility
> layer and is against standards in general. Hide these symbols from
> external consumers, while keeping them available for DPDK code.
>
> v9:
>      * Fix missing <rte_os_shim.h> include in rte_common_log.c.
>        (This will happen again. Going to add a checkpatch test
>         after this series is merged.)
> v8:
>      * Drop rte_thread_sleep API, use rte_delay_us_sleep (Morten Brørup).
>
> Dmitry Kozlyuk (4):
>    eal/windows: hide asprintf() shim
>    eal: make OS shims internal
>    net: work around s_addr macro on Windows
>    net: provide IP-related API on any OS
>
> <Snip>

The change to remove the networking shim breaks l2fwd compilation on 
Windows, since l2fwd/main.c includes netinet/in.h explicitly.

How do you propose we fix this, only for Windows?

ranjit m.