DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [virtio-net-pmd PATCH 08/16] pmd: fix initialization of Tx queue header
Date: Tue,  4 Feb 2014 16:54:23 +0100	[thread overview]
Message-ID: <1391529271-24606-9-git-send-email-thomas.monjalon@6wind.com> (raw)
In-Reply-To: <1391529271-24606-1-git-send-email-thomas.monjalon@6wind.com>

A typo was found by gcc-4.8:
virtio_user.c:744:15: error: argument to 'sizeof' in 'memset' call is the
same expression as the destination; did you mean to dereference it?
[-Werror=sizeof-pointer-memaccess]
         sizeof(tq->tx_hdrs[sz - 1].header));
               ^

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 virtio_user.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/virtio_user.c b/virtio_user.c
index 1074bd8..a5f81df 100644
--- a/virtio_user.c
+++ b/virtio_user.c
@@ -1,5 +1,5 @@
 /*
- * Copyright 2013 6WIND S.A.
+ * Copyright 2013-2014 6WIND S.A.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -741,7 +741,7 @@ virtio_alloc_txq(struct virtio_net_vring* tq, int sz)
 	}
 	/* Reserve a NULL header for NO OP on hypervisor side. */
 	memset(tq->tx_hdrs[sz - 1].header, 0,
-	       sizeof(tq->tx_hdrs[sz - 1].header));
+	       sizeof(*tq->tx_hdrs[sz - 1].header));
 	return 0;
 }
 
-- 
1.7.10.4

  parent reply	other threads:[~2014-02-04 15:53 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-04 15:54 [dpdk-dev] [PATCH 00/16] recipes for RPM packages Thomas Monjalon
2014-02-04 15:54 ` [dpdk-dev] [PATCH 01/16] tools: rename pci_unbind script Thomas Monjalon
2014-02-24 16:03   ` Chris Wright
2014-03-20 17:06     ` Thomas Monjalon
2014-02-04 15:54 ` [dpdk-dev] [PATCH 02/16] virtio: rename library Thomas Monjalon
2014-02-24 16:05   ` Chris Wright
2014-03-20 17:06     ` Thomas Monjalon
2014-02-04 15:54 ` [dpdk-dev] [PATCH 03/16] pkg: add recipe for RPM Thomas Monjalon
2014-02-24 16:29   ` Chris Wright
2014-02-24 16:52   ` Chris Wright
2014-04-02  9:01     ` Thomas Monjalon
2014-04-02 11:11       ` Thomas Graf
2014-02-26 13:07   ` Thomas Graf
2014-02-26 16:19     ` Chris Wright
2014-04-02  9:53     ` Thomas Monjalon
2014-04-02 11:04       ` Thomas Graf
2014-04-02 11:29       ` Neil Horman
2014-02-04 15:54 ` [dpdk-dev] [vmxnet3-usermap PATCH 04/16] pmd: add make help Thomas Monjalon
2014-02-24 18:17   ` Chris Wright
2014-03-26 21:59     ` Thomas Monjalon
2014-02-04 15:54 ` [dpdk-dev] [vmxnet3-usermap PATCH 05/16] pmd: allow to build outside of the source directory Thomas Monjalon
2014-02-24 18:13   ` Chris Wright
2014-03-26 21:59     ` Thomas Monjalon
2014-02-04 15:54 ` [dpdk-dev] [vmxnet3-usermap PATCH 06/16] pmd: allow to install lib and doc Thomas Monjalon
2014-03-26 22:00   ` Thomas Monjalon
2014-02-04 15:54 ` [dpdk-dev] [vmxnet3-usermap PATCH 07/16] pkg: add recipe for RPM Thomas Monjalon
2014-02-26 13:22   ` Thomas Graf
2014-04-02 10:08     ` Thomas Monjalon
2014-04-02 11:07       ` Thomas Graf
2014-02-04 15:54 ` Thomas Monjalon [this message]
2014-03-27  8:23   ` [dpdk-dev] [virtio-net-pmd PATCH 08/16] pmd: fix initialization of Tx queue header Olivier MATZ
2014-03-27  9:34     ` Thomas Monjalon
2014-02-04 15:54 ` [dpdk-dev] [virtio-net-pmd PATCH 09/16] mk: minor fixes Thomas Monjalon
2014-03-27  8:26   ` Olivier MATZ
2014-03-27  9:35     ` Thomas Monjalon
2014-02-04 15:54 ` [dpdk-dev] [virtio-net-pmd PATCH 10/16] mk: allow to build outside of the source directory Thomas Monjalon
2014-03-27  8:31   ` Olivier MATZ
2014-03-27  9:35     ` Thomas Monjalon
2014-02-04 15:54 ` [dpdk-dev] [virtio-net-pmd PATCH 11/16] mk: allow to install lib and doc Thomas Monjalon
2014-03-27  8:32   ` Olivier MATZ
2014-03-27  9:35     ` Thomas Monjalon
2014-02-04 15:54 ` [dpdk-dev] [virtio-net-pmd PATCH 12/16] pkg: add recipe for RPM Thomas Monjalon
2014-02-04 15:54 ` [dpdk-dev] [memnic PATCH 13/16] pmd: rename doc when installing Thomas Monjalon
2014-03-27  8:36   ` Olivier MATZ
2014-03-27 10:29     ` Thomas Monjalon
2014-02-04 15:54 ` [dpdk-dev] [memnic PATCH 14/16] pmd: fix doc uninstalling Thomas Monjalon
2014-03-27  8:45   ` Olivier MATZ
2014-03-27 10:30     ` Thomas Monjalon
2014-02-04 15:54 ` [dpdk-dev] [memnic PATCH 15/16] pmd: remove useless makefile variables Thomas Monjalon
2014-03-27  8:45   ` Olivier MATZ
2014-03-27 10:30     ` Thomas Monjalon
2014-02-04 15:54 ` [dpdk-dev] [memnic PATCH 16/16] pkg: add recipe for RPM Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1391529271-24606-9-git-send-email-thomas.monjalon@6wind.com \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).