From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB154A0A05; Tue, 19 Jan 2021 15:17:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 244CE140E97; Tue, 19 Jan 2021 15:17:32 +0100 (CET) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by mails.dpdk.org (Postfix) with ESMTP id 3C861140E92 for ; Tue, 19 Jan 2021 15:17:29 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 7AC2B5808F5; Tue, 19 Jan 2021 09:17:27 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 19 Jan 2021 09:17:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= dSdANxj2Ey1AMq1p0SGGcEl9QJSALwqdL0Y6sB7vGbs=; b=X0ZeQkYCY2X98zWR sYr0xfRb5Dk5mTZZymID0LEpBo0uIJGqTjuV/pNEr66t5eqRQKUQoC2IueGAsrId ZBjKCA0RsJW2jsHFISf296+gqFILJeSMY96UxLThvqZgK10H6LTZ3fzWx1TRfUXt j4xgqQhnwzjR1OLKhZscXCw1hJiozA4MfoCsmuXwyCRj5+ToDIwfBrB8N7Fmib7q blQoIC+1Itjzqerczu2kMkDbllLCarsnVHKseXlLPCP3HPwgsDll3DIFZzwDdbkm eUkEuu9XuWQnhyXdqaDtYl2qZIIH+ImjNZ90fGftDI+dTroODHVwfUsBIrI8mjk1 69XSPg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=dSdANxj2Ey1AMq1p0SGGcEl9QJSALwqdL0Y6sB7vG bs=; b=jmILADW2ARLc/gqM/lzOVm95QWL6Jm4SQnaXkeRk7RQew35JOOaV6tNRe FzOzr12zJVaW+r+jLuhWaKkrTgVF1v1J5eWmZNpzyruWu4qBZSTGCl06MGMJvLE2 UvQdQwtYlqy39GnuDKpPmfIeWRnu6X+glPctMo7j1vnGA8d2yzojZB4/11lLIOEz evjM+kZLV2OheJWy8iKTfHkMRM881LT9+xJAA3SgV+VhLeY+Xly8Ulg2NWar1H7J 1vnh/G843R01xIOEJJJ1PvMw6zoJNxH+KOOC/94gRfNuOlAS/jgqu2Xie6uV3H1Z l38Mfx0xaeKoSQjKFVaGyJL301V3w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddtgdeifecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 35BBC24005A; Tue, 19 Jan 2021 09:17:25 -0500 (EST) From: Thomas Monjalon To: "Burakov, Anatoly" Cc: dev@dpdk.org, Timothy McDaniel , Jan Viktorin , Ruifeng Wang , Jerin Jacob , David Christensen , Bruce Richardson , Konstantin Ananyev , david.hunt@intel.com, chris.macnamara@intel.com Date: Tue, 19 Jan 2021 15:17:23 +0100 Message-ID: <13958212.9hUD3U9ut9@thomas> In-Reply-To: <95c0b120-3197-0e34-74b1-2ba76b116035@intel.com> References: <5237700.INpASENRAa@thomas> <95c0b120-3197-0e34-74b1-2ba76b116035@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v17 03/11] eal: change API of power intrinsics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 19/01/2021 12:23, Burakov, Anatoly: > On 19-Jan-21 10:42 AM, Thomas Monjalon wrote: > > 19/01/2021 11:29, Burakov, Anatoly: > >> On 18-Jan-21 10:26 PM, Thomas Monjalon wrote: > >>> 14/01/2021 15:46, Anatoly Burakov: > >>>> +struct rte_power_monitor_cond { > >>>> + volatile void *addr; /**< Address to monitor for changes */ > >>>> + uint64_t val; /**< Before attempting the monitoring, the address > >>>> + * may be read and compared against this value. > >>> > >>> "may" be read and compared? > >>> Is there a case where there is no read and compare? > >> > >> Yes, if the mask is not set. > > > > If the mask is not set, the address is "read" anyway > > or it is only "watched" for any change? > > > > Sorry the mechanism is really not clear to me. > > > > The "value" is only used to avoid the sleep, i.e. to check if the write > has already happened. We're waiting on *a write* rather than *a value*, > so it's not equivalent to "wait until equal" call. It's more of a "sleep > until something happens". Please make things explicit in doxygen. The behaviour of each case should be explained crystal clear. Thanks