From: David Marchand <david.marchand@6wind.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 1/2] mem: add write memory barrier before changing heap state
Date: Tue, 15 Apr 2014 15:50:58 +0200 [thread overview]
Message-ID: <1397569859-14460-1-git-send-email-david.marchand@6wind.com> (raw)
From: Didier Pallard <didier.pallard@6wind.com>
a write memory barrier is needed before changing heap state
value, else some concurrent core may see state changing before
all initialization values are written to memory, causing
unpredictable results in malloc function.
Signed-off-by: Didier Pallard <didier.pallard@6wind.com>
---
lib/librte_malloc/malloc_heap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_malloc/malloc_heap.c b/lib/librte_malloc/malloc_heap.c
index f4a0294..64668cb 100644
--- a/lib/librte_malloc/malloc_heap.c
+++ b/lib/librte_malloc/malloc_heap.c
@@ -147,6 +147,7 @@ malloc_heap_init(struct malloc_heap *heap)
*/
heap->numa_socket = heap - mcfg->malloc_heaps;
rte_spinlock_init(&heap->lock);
+ rte_wmb();
heap->initialised = INITIALISED;
}
}
--
1.7.10.4
next reply other threads:[~2014-04-15 13:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 13:50 David Marchand [this message]
2014-04-15 13:50 ` [dpdk-dev] [PATCH 2/2] mem: fix initialization check for malloc heap David Marchand
2014-04-15 14:08 ` [dpdk-dev] [PATCH 1/2] mem: add write memory barrier before changing heap state Richardson, Bruce
2014-04-16 8:55 ` didier.pallard
2014-04-15 14:44 ` Neil Horman
2014-04-18 12:56 ` [dpdk-dev] [PATCH 0/2] rework heap initialisation David Marchand
2014-04-18 12:56 ` [dpdk-dev] [PATCH 1/2] malloc: get rid of numa_socket field David Marchand
2014-04-18 13:08 ` Neil Horman
2014-04-30 9:46 ` Thomas Monjalon
2014-04-18 12:56 ` [dpdk-dev] [PATCH 2/2] malloc: simplify heap initialisation David Marchand
2014-04-18 13:09 ` Neil Horman
2014-04-30 9:47 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397569859-14460-1-git-send-email-david.marchand@6wind.com \
--to=david.marchand@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).