From: Thomas Monjalon <thomas@monjalon.net>
To: Remy Horton <remy.horton@intel.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] metrics: fix potential missing NULL termination
Date: Wed, 04 Apr 2018 16:09:53 +0200 [thread overview]
Message-ID: <13984140.EBaPjM1LZT@xps> (raw)
In-Reply-To: <88c28dcd-3d5e-f88c-4c3a-53cb94b356e7@intel.com>
22/03/2018 11:33, Ferruh Yigit:
> On 2/20/2018 4:05 PM, Remy Horton wrote:
> > Fixes a potential memory overrun detected by Coverity.
> > This overrun cannot currently happen in practice because
> > rte_metrics_reg_names() explicitly forces the last name
> > character to be a NULL terminator. This patch adds the
> > same enforcement to rte_metrics_get_names() in order to
> > correct the warning, as well as using snprintf instead
> > of strncpy to copy name strings.
>
> There is a patch from Bruce to convert snprintf to strlcpy [1], this patch can
> be part of that one.
>
> [1]
> https://dpdk.org/dev/patchwork/patch/35976/
>
> >
> > Coverity issue: 143434
> > Fixes: 349950ddb9c5 ("metrics: add information metrics library")
> > Fixes: 710cab6f675a ("metrics: fix out of bound access")
> >
> > Signed-off-by: Remy Horton <remy.horton@intel.com>
Updated to use strlcpy and applied.
prev parent reply other threads:[~2018-04-04 14:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 14:50 [dpdk-dev] [PATCH v1] " Remy Horton
2018-02-20 15:11 ` Bruce Richardson
2018-02-20 15:32 ` Remy Horton
2018-02-20 16:05 ` [dpdk-dev] [PATCH v2] " Remy Horton
2018-03-22 10:33 ` Ferruh Yigit
2018-04-04 14:09 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13984140.EBaPjM1LZT@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=remy.horton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).