DPDK patches and discussions
 help / color / mirror / Atom feed
From: Olivier Matz <olivier.matz@6wind.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 5/5] examples: fix netmap_compat example
Date: Fri, 25 Apr 2014 14:00:49 +0200	[thread overview]
Message-ID: <1398427249-15418-6-git-send-email-olivier.matz@6wind.com> (raw)
In-Reply-To: <1398427249-15418-1-git-send-email-olivier.matz@6wind.com>

It is not allowed to reference a an absolute file name in SRCS-y.
A VPATH has to be used, else the dependencies won't be checked
properly.

Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
 examples/netmap_compat/bridge/Makefile | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/examples/netmap_compat/bridge/Makefile b/examples/netmap_compat/bridge/Makefile
index 74feb1e..ebc6b1c 100644
--- a/examples/netmap_compat/bridge/Makefile
+++ b/examples/netmap_compat/bridge/Makefile
@@ -41,9 +41,12 @@ include $(RTE_SDK)/mk/rte.vars.mk
 # binary name
 APP = bridge
 
+# for compat_netmap.c
+VPATH := $(SRCDIR)/../lib
+
 # all source are stored in SRCS-y
 SRCS-y := bridge.c
-SRCS-y += $(SRCDIR)/../lib/compat_netmap.c
+SRCS-y += compat_netmap.c
 
 CFLAGS += -O3 -I$(SRCDIR)/../lib -I$(SRCDIR)/../netmap
 CFLAGS += $(WERROR_FLAGS)
-- 
1.9.2

  parent reply	other threads:[~2014-04-25 12:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-25 12:00 [dpdk-dev] [PATCH 0/5] examples: add a new makefile to build all examples Olivier Matz
2014-04-25 12:00 ` [dpdk-dev] [PATCH 1/5] mk: introduce rte.extsubdir.mk Olivier Matz
2014-04-25 12:00 ` [dpdk-dev] [PATCH 2/5] examples: use rte.extsubdir.mk to process subdirectories Olivier Matz
2014-04-25 12:00 ` [dpdk-dev] [PATCH 3/5] examples: add a makefile to build all examples Olivier Matz
2014-04-25 12:00 ` [dpdk-dev] [PATCH 4/5] examples: fix qos_sched makefile Olivier Matz
2014-04-25 12:00 ` Olivier Matz [this message]
2014-04-25 14:05 ` [dpdk-dev] [PATCH 0/5] examples: add a new makefile to build all examples Neil Horman
2014-04-25 16:24   ` Olivier MATZ
2014-04-25 18:39     ` Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398427249-15418-6-git-send-email-olivier.matz@6wind.com \
    --to=olivier.matz@6wind.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).