From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id A65DAF3E for ; Mon, 23 Apr 2018 01:17:00 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1D73121D6A; Sun, 22 Apr 2018 19:16:59 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 22 Apr 2018 19:17:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=jxW1obARXT+JCk7OkpDce+vEgU 1MiUMAHPbwIrW5NCI=; b=Ko76mmVGXVVOB+6I8P0b6ulQ/tl2AjyAv4ZksBaJgy GrE1p4oHBTCASiq+KKU3utnS06nD1L90RSUobydzqniFKSHyQvSul7q9SujIokup II8DlSC+6JGbnc5q+6YznV73OBW40xKmuk6vMc9rvQgVEumvYX/S2jhIQPNf7YfX Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=jxW1ob ARXT+JCk7OkpDce+vEgU1MiUMAHPbwIrW5NCI=; b=mSY7Tz4L7VyI3ZZT0vExuf FwP+0xehkF6GOOaGJqdzDCFkN1xoLQMS1UEwWMQFiym6Xtxn7n3p8uykrLTBrGOd YOwkJ1DS9VMUIneUzJ+SJcD1G/LlkVrhGeB003kGHEY7nznbI2pwF9rE5LgN9mm2 QFiEgBYVErOlrCX314876K0GjcN4IG38Xr5Yak58NTPZFM7Jp6kuxuKB+gMYB+Uf KF3snVbDZ8kqCuUXCHt3NiVwuFrlhkAktP+t9b0/ETLbpOx3cFX2G+BkuXFFE/XX +qm3bDlktU4RiTOqN33OYqO7RQQWNJNbPc7EElaaupgOOKNJmXm0yfR+7ATTT41A == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4CAC5E4076; Sun, 22 Apr 2018 19:16:59 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org Date: Mon, 23 Apr 2018 01:16:58 +0200 Message-ID: <13986424.9OyRsrj3FE@xps> In-Reply-To: <20180228171156.91077-1-bruce.richardson@intel.com> References: <20180228171156.91077-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] mk: allow renaming of build directories X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Apr 2018 23:17:00 -0000 28/02/2018 18:11, Bruce Richardson: > When building using make, the Makefile in the build directory contained > the name of the build directory to be passed as an "O=" parameter to > the DPDK SDK makefiles. Unfortunately, this meant that the compilation > would always fail if the build directory was renamed. To remove this > limitation, we can use $(CURDIR) instead of the directory name. > > Signed-off-by: Bruce Richardson > --- > --- a/buildtools/gen-build-mk.sh > +++ b/buildtools/gen-build-mk.sh > -echo " @\$(MAKE) -C $1 O=$2" > +echo " @\$(MAKE) -C $1 O=\$(CURDIR)" > echo > echo "%::" > -echo " @\$(MAKE) -C $1 O=$2 \$@" > +echo " @\$(MAKE) -C $1 O=\$(CURDIR) \$@" > --- a/mk/rte.sdkconfig.mk > +++ b/mk/rte.sdkconfig.mk > - $(Q)$(RTE_SDK)/buildtools/gen-build-mk.sh $(SDK_RELPATH) $(OUTPUT_RELPATH) \ > - > $(RTE_OUTPUT)/Makefile > + $(Q)$(RTE_SDK)/buildtools/gen-build-mk.sh $(SDK_RELPATH) > $@ You need to remove the comment about the 2nd argument of the script: # $2: path of build dir (can be relative to $1)