From: David Marchand <david.marchand@6wind.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 1/7] pci: fix potential mem leak
Date: Mon, 28 Apr 2014 15:19:41 +0200 [thread overview]
Message-ID: <1398691187-4918-2-git-send-email-david.marchand@6wind.com> (raw)
In-Reply-To: <1398691187-4918-1-git-send-email-david.marchand@6wind.com>
Looking at bsd implementation, we can see that there is a potential mem leak in
linux implementation. Fix this.
Signed-off-by: David Marchand <david.marchand@6wind.com>
---
lib/librte_eal/linuxapp/eal/eal_pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c
index 9538efe..313bab7 100644
--- a/lib/librte_eal/linuxapp/eal/eal_pci.c
+++ b/lib/librte_eal/linuxapp/eal/eal_pci.c
@@ -678,6 +678,7 @@ pci_uio_map_resource(struct rte_pci_device *dev)
(mapaddr = pci_map_resource(dev,
NULL, devname, (off_t)offset,
(size_t)maps[j].size)) == NULL) {
+ rte_free(uio_res);
return (-1);
}
--
1.7.10.4
next prev parent reply other threads:[~2014-04-28 13:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 13:19 [dpdk-dev] [PATCH 0/7] pci cleanup David Marchand
2014-04-28 13:19 ` David Marchand [this message]
2014-05-01 15:00 ` [dpdk-dev] [PATCH 1/7] pci: fix potential mem leak Burakov, Anatoly
2014-05-05 8:14 ` David Marchand
2014-04-28 13:19 ` [dpdk-dev] [PATCH 2/7] pci: align bsd implementation on linux David Marchand
2014-04-28 13:19 ` [dpdk-dev] [PATCH 3/7] pci: remove virtio-uio workaround David Marchand
2014-04-28 13:19 ` [dpdk-dev] [PATCH 4/7] pci: rework interrupt fd init and fix fd leak David Marchand
2014-04-28 13:19 ` [dpdk-dev] [PATCH 5/7] pci: pci_switch_module cleanup David Marchand
2014-04-28 13:19 ` [dpdk-dev] [PATCH 6/7] pci: move RTE_PCI_DRV_FORCE_UNBIND handling out of #ifdef David Marchand
2014-04-28 13:19 ` [dpdk-dev] [PATCH 7/7] pci: remove deprecated RTE_EAL_UNBIND_PORTS option David Marchand
2014-04-29 9:19 ` [dpdk-dev] [PATCH 0/7] pci cleanup Burakov, Anatoly
2014-04-29 11:00 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398691187-4918-2-git-send-email-david.marchand@6wind.com \
--to=david.marchand@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).