From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com
 [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id DD54411C5
 for <dev@dpdk.org>; Sun, 22 Mar 2015 23:23:49 +0100 (CET)
Received: by wibg7 with SMTP id g7so32558121wib.1
 for <dev@dpdk.org>; Sun, 22 Mar 2015 15:23:49 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=FYnM647t3rBev9hKAZ5YWP30mN3X+y5NK8m70qB3aQk=;
 b=TwrrEghx/S5VBmQU6bjThg0Ib7Q5ZzS9ZvEC609tDCp5K3XVLj9AdmGx8haf9lUckD
 BHSMJ0aTiPg/G/Inpc7M6QB+NAvwjUlaeDlGB7sUB+ceXpCNck6fCHJRyfP/M8dAeYSI
 n05vUwnLEGvQL+v4x5D5EwLd+BKKcvjepMd/3vVkmy8Ew7oq3uiHzpGughK36e1nkYMy
 h9N5z6qMRvA19rVW5QTlpLZPFTNKilI37Wz8sM+8G45joKqJMd6Cb/bbhG0tgSh9kcvb
 NpPd1JmdqQ6ccb54crXUN2FU0oD0fMSgdtYZ0ra+5it7DVzKhp6geMIc+P4VNgkGoh4B
 gW5A==
X-Gm-Message-State: ALoCoQndDi5S5gzYl9MEZ6Jr37KRN21b+EcMIALZN0Pr1x1JfrHgkeoUhM7jMPkkul3DkkmGx9Dh
X-Received: by 10.194.61.51 with SMTP id m19mr181469576wjr.39.1427063029719;
 Sun, 22 Mar 2015 15:23:49 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id jt8sm8430349wid.4.2015.03.22.15.23.48
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Sun, 22 Mar 2015 15:23:48 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Date: Sun, 22 Mar 2015 23:23:04 +0100
Message-ID: <13995381.n056FK0HbU@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; )
In-Reply-To: <1427047336-7271-1-git-send-email-pablo.de.lara.guarch@intel.com>
References: <1427047336-7271-1-git-send-email-pablo.de.lara.guarch@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] kni: fix compilation issue on kernel 3.19
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 22 Mar 2015 22:23:50 -0000

> From: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> 
> Due to API changes in functions ndo_dflt_bridge_getlink
> (commit 2c3c031c) and ndo_fdb_add (commit f6f6424b)
> in kernel 3.19, DPDK would not build.
> 
> This patch solves the problem, by checking the kernel version
> and adding the necessary new parameters.
> 
> Mind that function igb_ndo_fdb_add does not need the extra parameter
> if USE_CONST_DEV_UC_CHAR is not set, since that macro is only defined
> when kernel is greater or equal than 3.7
> 
> changes in v2:
> 
> - Added commits id of the API changes done in the kernel
> - Added missing blank line
> - Added extra details in the commit message
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied, thanks