From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id BAD0AAF81 for ; Fri, 9 May 2014 15:16:11 +0200 (CEST) Received: by mail-wi0-f172.google.com with SMTP id hi2so1303545wib.5 for ; Fri, 09 May 2014 06:16:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=Op1hJMtt8b5QX3H2Jd0ElLLMAhGCsu54cKE4Aar+yKc=; b=OIKp4TKdKxNKPQvsdiDbf5TS2LBuC4XXzFiMA+OXh+z4tZCVa1mSpsx0vDC+v3A0j6 tIDCaW9Ha8YFQVsnoyMN1XCR9t3t8lI7GAYLanq6VpDT8RGfxchLfRyNxYFw2AVNG6Zk o2e1LJrO0a3KAFu89AAT86y8z/swWsTeD0UZoNGolzHGJh2RVgxPPfCdQc2aS8ZUokz7 5MSnMHqRNfLfNllqDTVXuTxlvQHsptzotdWLsmVKQW3hKmRkJ/jJbLj8osUhNdbifk2g putttxKY9nmQmYtpqEZmQFM1w+uoJl9a/rtM+RPkQNKQMHbL+BpgYBLKw+Y/8aGXU2u0 qbpg== X-Gm-Message-State: ALoCoQlzcsWe2FDbmZrM/aKumnu5ok4yhNMAwe2SVryn/lwhU71BzewvNi7LMNf2sLHw0GbhTMjg X-Received: by 10.194.81.164 with SMTP id b4mr8586559wjy.2.1399641378049; Fri, 09 May 2014 06:16:18 -0700 (PDT) Received: from alcyon.dev.6wind.com (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id go1sm5086560wib.7.2014.05.09.06.16.16 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 May 2014 06:16:17 -0700 (PDT) From: David Marchand To: dev@dpdk.org Date: Fri, 9 May 2014 15:15:59 +0200 Message-Id: <1399641359-11267-8-git-send-email-david.marchand@6wind.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1399641359-11267-1-git-send-email-david.marchand@6wind.com> References: <1399641359-11267-1-git-send-email-david.marchand@6wind.com> Subject: [dpdk-dev] [PATCH v2 7/7] pci: remove deprecated RTE_EAL_UNBIND_PORTS option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 May 2014 13:16:12 -0000 RTE_EAL_UNBIND_PORTS was deprecated in DPDK 1.4.0 and removed in 1.6.0, but the code was not removed. The bind/unbind operations should not be handled by the eal. These operations should be either done outside of dpdk or inside the PMDs themselves as these are their problems. Signed-off-by: Anatoly Burakov Signed-off-by: David Marchand --- lib/librte_eal/linuxapp/eal/eal_pci.c | 171 --------------------------------- 1 file changed, 171 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c index d529ced..ac2c1fe 100644 --- a/lib/librte_eal/linuxapp/eal/eal_pci.c +++ b/lib/librte_eal/linuxapp/eal/eal_pci.c @@ -146,155 +146,6 @@ error: return -1; } -#ifdef RTE_EAL_UNBIND_PORTS -#define PROC_MODULES "/proc/modules" - -#define IGB_UIO_NAME "igb_uio" - -#define UIO_DRV_PATH "/sys/bus/pci/drivers/%s" - -/* maximum time to wait that /dev/uioX appears */ -#define UIO_DEV_WAIT_TIMEOUT 3 /* seconds */ - -/* - * Check that a kernel module is loaded. Returns 0 on success, or if the - * parameter is NULL, or -1 if the module is not loaded. - */ -static int -pci_uio_check_module(const char *module_name) -{ - FILE *f; - unsigned i; - char buf[BUFSIZ]; - - if (module_name == NULL) - return 0; - - f = fopen(PROC_MODULES, "r"); - if (f == NULL) { - RTE_LOG(ERR, EAL, "Cannot open "PROC_MODULES": %s\n", - strerror(errno)); - return -1; - } - - while(fgets(buf, sizeof(buf), f) != NULL) { - - for (i = 0; i < sizeof(buf) && buf[i] != '\0'; i++) { - if (isspace(buf[i])) - buf[i] = '\0'; - } - - if (strncmp(buf, module_name, sizeof(buf)) == 0) { - fclose(f); - return 0; - } - } - fclose(f); - return -1; -} - -/* bind a PCI to the kernel module driver */ -static int -pci_bind_device(struct rte_pci_device *dev, char dr_path[]) -{ - FILE *f; - int n; - char buf[BUFSIZ]; - char dev_bind[PATH_MAX]; - struct rte_pci_addr *loc = &dev->addr; - - n = rte_snprintf(dev_bind, sizeof(dev_bind), "%s/bind", dr_path); - if ((n < 0) || (n >= (int)sizeof(buf))) { - RTE_LOG(ERR, EAL, "Cannot rte_snprintf device bind path\n"); - return -1; - } - - f = fopen(dev_bind, "w"); - if (f == NULL) { - RTE_LOG(ERR, EAL, "Cannot open %s\n", dev_bind); - return -1; - } - n = rte_snprintf(buf, sizeof(buf), PCI_PRI_FMT "\n", - loc->domain, loc->bus, loc->devid, loc->function); - if ((n < 0) || (n >= (int)sizeof(buf))) { - RTE_LOG(ERR, EAL, "Cannot rte_snprintf PCI infos\n"); - fclose(f); - return -1; - } - if (fwrite(buf, n, 1, f) == 0) { - fclose(f); - return -1; - } - - fclose(f); - return 0; -} - -static int -pci_uio_bind_device(struct rte_pci_device *dev, const char *module_name) -{ - FILE *f; - int n; - char buf[BUFSIZ]; - char uio_newid[PATH_MAX]; - char uio_bind[PATH_MAX]; - - n = rte_snprintf(uio_newid, sizeof(uio_newid), UIO_DRV_PATH "/new_id", module_name); - if ((n < 0) || (n >= (int)sizeof(uio_newid))) { - RTE_LOG(ERR, EAL, "Cannot rte_snprintf uio_newid name\n"); - return -1; - } - - n = rte_snprintf(uio_bind, sizeof(uio_bind), UIO_DRV_PATH, module_name); - if ((n < 0) || (n >= (int)sizeof(uio_bind))) { - RTE_LOG(ERR, EAL, "Cannot rte_snprintf uio_bind name\n"); - return -1; - } - - n = rte_snprintf(buf, sizeof(buf), "%x %x\n", - dev->id.vendor_id, dev->id.device_id); - if ((n < 0) || (n >= (int)sizeof(buf))) { - RTE_LOG(ERR, EAL, "Cannot rte_snprintf vendor_id/device_id\n"); - return -1; - } - - f = fopen(uio_newid, "w"); - if (f == NULL) { - RTE_LOG(ERR, EAL, "Cannot open %s\n", uio_newid); - return -1; - } - if (fwrite(buf, n, 1, f) == 0) { - fclose(f); - return -1; - } - fclose(f); - - pci_bind_device(dev, uio_bind); - return 0; -} - -static int -pci_switch_module(struct rte_pci_driver *dr, struct rte_pci_device *dev, - const char *module_name) -{ - if (rte_eal_process_type() == RTE_PROC_PRIMARY) { - /* check that our driver is loaded */ - if (pci_uio_check_module(module_name) != 0) - rte_exit(EXIT_FAILURE, "The %s module is required by the " - "%s driver\n", module_name, dr->name); - - /* unbind current driver, bind ours */ - if (pci_unbind_kernel_driver(dev) < 0) - return -1; - if (pci_uio_bind_device(dev, module_name) < 0) - return -1; - } - - return 0; -} - -#endif /* ifdef EAL_UNBIND_PORTS */ - /* map a particular resource from a file */ static void * pci_map_resource(void *requested_addr, const char *devname, off_t offset, @@ -303,24 +154,10 @@ pci_map_resource(void *requested_addr, const char *devname, off_t offset, int fd; void *mapaddr; -#ifdef RTE_EAL_UNBIND_PORTS - /* - * open devname, and mmap it: it can take some time to - * appear, so we wait some time before returning an error - */ - unsigned n; - for (n = 0; n < UIO_DEV_WAIT_TIMEOUT*10; n++) { - errno = 0; - if ((fd = open(devname, O_RDWR)) < 0 && errno != ENOENT) - break; - usleep(100000); - } -#else /* * open devname, to mmap it */ fd = open(devname, O_RDWR); -#endif if (fd < 0) { RTE_LOG(ERR, EAL, "Cannot open %s: %s\n", devname, strerror(errno)); @@ -1002,14 +839,6 @@ rte_eal_pci_probe_one_driver(struct rte_pci_driver *dr, struct rte_pci_device *d return 0; } -#ifdef RTE_EAL_UNBIND_PORTS - if (dr->drv_flags & RTE_PCI_DRV_NEED_IGB_UIO) { - /* unbind current driver and bind on igb_uio */ - if (pci_switch_module(dr, dev, IGB_UIO_NAME) < 0) - return -1; - } -#endif - if (dr->drv_flags & RTE_PCI_DRV_NEED_IGB_UIO) { /* map resources for devices that use igb_uio */ if (pci_uio_map_resource(dev) < 0) -- 1.7.10.4