From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ex.trust-in-soft.com (ex.trust-in-soft.com [188.165.147.96]) by dpdk.org (Postfix) with ESMTP id CF28568A8 for ; Mon, 12 May 2014 17:35:15 +0200 (CEST) Received: from localhost.localdomain (84.14.219.4) by S1688.EX1688.lan (2001:41d0:6b:b00::bca5:9360) with Microsoft SMTP Server (TLS) id 15.0.712.22; Mon, 12 May 2014 17:36:25 +0200 From: Julien Cretin To: Date: Mon, 12 May 2014 17:35:11 +0200 Message-ID: <1399908911-18829-4-git-send-email-julien.cretin@trust-in-soft.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1399908911-18829-1-git-send-email-julien.cretin@trust-in-soft.com> References: <1399908911-18829-1-git-send-email-julien.cretin@trust-in-soft.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [84.14.219.4] X-ClientProxiedBy: S1688.EX1688.lan (2001:41d0:6b:b00::bca5:9360) To S1688.EX1688.lan (2001:41d0:6b:b00::bca5:9360) Subject: [dpdk-dev] [PATCH 3/3] app/testpmd: fix incompatible sign for printf arguments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 May 2014 15:35:16 -0000 The socket_id member of struct rte_port is an unsigned int while the d conversion specifier of printf expects an int. The addr_bytes member of struct ether_addr is an array of uint8_t while the X conversion specifier of printf expects an unsigned int. Values of type uint8_t are promoted to type int when used in the ellipsis notation of a function. These minor bugs were found using TrustInSoft Analyzer. Signed-off-by: Julien Cretin --- app/test-pmd/config.c | 16 ++++++++-------- app/test-pmd/testpmd.c | 2 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 1feb133..134bf07 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -100,12 +100,12 @@ static void print_ethaddr(const char *name, struct ether_addr *eth_addr) { printf("%s%02X:%02X:%02X:%02X:%02X:%02X", name, - eth_addr->addr_bytes[0], - eth_addr->addr_bytes[1], - eth_addr->addr_bytes[2], - eth_addr->addr_bytes[3], - eth_addr->addr_bytes[4], - eth_addr->addr_bytes[5]); + (unsigned int)eth_addr->addr_bytes[0], + (unsigned int)eth_addr->addr_bytes[1], + (unsigned int)eth_addr->addr_bytes[2], + (unsigned int)eth_addr->addr_bytes[3], + (unsigned int)eth_addr->addr_bytes[4], + (unsigned int)eth_addr->addr_bytes[5]); } void @@ -256,7 +256,7 @@ port_infos_display(portid_t port_id) printf("\n%s Infos for port %-2d %s\n", info_border, port_id, info_border); print_ethaddr("MAC address: ", &port->eth_addr); - printf("\nConnect to socket: %d", port->socket_id); + printf("\nConnect to socket: %u", port->socket_id); if (port_numa[port_id] != NUMA_NO_CONFIG) { mp = mbuf_pool_find(port_numa[port_id]); @@ -264,7 +264,7 @@ port_infos_display(portid_t port_id) printf("\nmemory allocation on the socket: %d", port_numa[port_id]); } else - printf("\nmemory allocation on the socket: %d",port->socket_id); + printf("\nmemory allocation on the socket: %u",port->socket_id); printf("\nLink status: %s\n", (link.link_status) ? ("up") : ("down")); printf("Link speed: %u Mbps\n", (unsigned) link.link_speed); diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 9c56914..55a5ea1 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -1250,7 +1250,7 @@ start_port(portid_t pid) if (port->need_reconfig > 0) { port->need_reconfig = 0; - printf("Configuring Port %d (socket %d)\n", pi, + printf("Configuring Port %d (socket %u)\n", pi, port->socket_id); /* configure port */ diag = rte_eth_dev_configure(pi, nb_rxq, nb_txq, -- 1.9.1