From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 460662BB1 for ; Fri, 16 Jun 2017 11:42:09 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A94BD206A1; Fri, 16 Jun 2017 05:42:08 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 16 Jun 2017 05:42:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=Op5EPwCrvjgINt/ FyWCjPDD+S0woSUyCsxFDTLf7pao=; b=e7pRSz45eC8UTQ6wPYQWGz0XOkjY3bl zUlulC0NXh1CCE3uqLizLz67raamvj+w6hNsHAiiNUrLAk4NpEug+aACBokbGEXk Lnk5dNsftrJO21g6FSvdQ1W2n0Al805Fo3NOzfGDFoxLN1KfrLDrtYfZ49Y9l8F5 nT704/8GTUMk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=Op5EPwCrvjgINt/FyWCjPDD+S0woSUyCsxFDTLf7pao=; b=NPjoyC2H 8nDpeSs8viyM25tidHAl9t53z7kvffx5nwAz7ZTbRTIx7AS+IaCJw3eco73e40i+ wWwEvPkZDyIv4/3RWjDL3MZ1A+6E3Dlz5xcF2DOI791J42kafVH2wHeMMTCXndXY bqY/BiBNN159tqDlXb6FMqIqcFWOCWZFlLgvN7RORRPAivLCL9p+nnGRgUaZCVs4 4gXDq/7XMtgdOajjRK6/cpMuD5of/5GgsVx93tkGPfh/xoUsw3FBU2Nv+MSEUy7h 4Bq4ynOvEfXPMOTx+YxlCKm3QZE8f41C3G75Zq2mjSb3XeEYSIhRK+slxgBpf8j2 UgV2WnDAVS+Ung== X-ME-Sender: X-Sasl-enc: ntF4Qb5x/MFZiIF3NM92o0mbKcA8MeLFNTvi6LE3PNtQ 1497606128 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5E63B7E7B1; Fri, 16 Jun 2017 05:42:08 -0400 (EDT) From: Thomas Monjalon To: Shreyansh Jain , Bruce Richardson Cc: dev@dpdk.org, "ferruh.yigit@intel.com" , Hemant Agrawal Date: Fri, 16 Jun 2017 11:42:07 +0200 Message-ID: <13999401.01CXETvodY@xps> In-Reply-To: References: <1497591668-3320-1-git-send-email-shreyansh.jain@nxp.com> <20170616085719.GB82628@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 01/38] eal: add support for 24 40 and 48 bit operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Jun 2017 09:42:09 -0000 16/06/2017 11:21, Shreyansh Jain: > Hi Bruce, > > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > > On Fri, Jun 16, 2017 at 11:10:31AM +0530, Shreyansh Jain wrote: > > > From: Hemant Agrawal > > > > > > Bit Swap and LE<=>BE conversions for 23, 40 and 48 bit width > > > > > > Signed-off-by: Hemant Agrawal > > > --- > > > .../common/include/generic/rte_byteorder.h | 78 > > ++++++++++++++++++++++ > > > 1 file changed, 78 insertions(+) > > > > > Are these really common enough for inclusion in an generic EAL file? > > Would they be better being driver specific, so that we don't end up with > > lots of extra byte-swap routines for each possible size used by a > > driver. > > Reasoning was to keep all bit/byte swap at a single place and if it is > useful for others. > > From DPAA perspective, these macro can be anywhere. In case someone else too > has use of this (now or in near-future), probably then we can consider this > in EAL. > Else, if I don't get much responses in a few days, I will shift them to > DPAA driver in next version of this series. I prefer keeping common functions in a common place. So I like this patch.