From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ADE87A034F; Mon, 22 Mar 2021 09:52:25 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3605040040; Mon, 22 Mar 2021 09:52:25 +0100 (CET) Received: from dal2relay182.mxroute.com (dal2relay182.mxroute.com [64.40.26.182]) by mails.dpdk.org (Postfix) with ESMTP id C5D5F4003D for ; Mon, 22 Mar 2021 09:52:23 +0100 (CET) Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by dal2relay182.mxroute.com (ZoneMTA) with ESMTPSA id 178592297b4000362f.003 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Mon, 22 Mar 2021 08:52:22 +0000 X-Zone-Loop: b982d1e58a0a4881f77c81054b7380d294075e12bd5b X-Originating-IP: [149.28.56.236] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=sAkCt0760Dzo8MEg9H8ziPIb4d9l6Mkc44Dwsg8XkYU=; b=dp2JTasHAC5DosjRkbqcmwoID2 OnAdLHiKmUb7a7aabjxNgu/vlg5ioyKL5f6Lv7v9ntrR74fEJoI7B5/NbfY+D0Gf9jqgl5vAI9kIM 46hzKDrDOQIMIV/XYU2jin1w1wl5Re9pGe+EO49SLBWIE6FR7XiVX/+RwtcxIRa4JWp0E0SD/kmwh /xFpFtSgRUcHpAPFVXWK/S4sOWw2pGFS/ivrvAwhmMwyshNZbJ3rDxuoGb/Hu+9E8gvKOdoAB6Ic8 e9aBnyfqr0XTfQKoaUmwd/Fu+/DL1x0JhW4TheWIccmP2LDW05i7FrKSfcQ9maxGnSo+y2sr+o00R sSTlIyWQ==; To: Thomas Monjalon , dev@dpdk.org Cc: ncopa@alpinelinux.org, stable@dpdk.org, Bruce Richardson , Andrew Rybchenko , David Marchand , Konstantin Ananyev , Neil Horman , Haiyue Wang , Adrien Mazarguil References: <20190313170657.16688-1-ncopa@alpinelinux.org> <20210319145730.3555384-1-thomas@monjalon.net> <20210319145730.3555384-3-thomas@monjalon.net> From: "Kinsella, Ray" Message-ID: <139ba04c-4b63-9686-a123-3f3e1e23077b@ashroe.eu> Date: Mon, 22 Mar 2021 08:52:16 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210319145730.3555384-3-thomas@monjalon.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH v7 02/17] buildtools: fix build with busybox X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 19/03/2021 14:57, Thomas Monjalon wrote: > If using busybox for mktemp and awk (as in Alpine), > some bugs prevent the script from running: > > 1/ It seems busybox mktemp requires the pattern to have at least > 6 X and no other suffix. > The same has been fixed for other scripts in the past: > commit 3771edc35438 ("buildtools: fix build for some mktemp") > > 2/ It seems busybox awk does not accept the regex ^.*{ > except if the opening curly brace is escaped. > > Fixes: 4c82473412e8 ("build: add internal tag check") > Fixes: 68b1f1cda5b4 ("build: check AVX512 rather than binutils version") > Fixes: 3290ac14eb94 ("buildtools: detect discrepancies for experimental symbols") > Cc: stable@dpdk.org > > Signed-off-by: Thomas Monjalon > Acked-by: Bruce Richardson > Acked-by: Andrew Rybchenko > Acked-by: David Marchand > --- > buildtools/binutils-avx512-check.sh | 2 +- > buildtools/check-symbols.sh | 2 +- > buildtools/map-list-symbol.sh | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/buildtools/binutils-avx512-check.sh b/buildtools/binutils-avx512-check.sh > index a7e068140f..2a833b64b7 100755 > --- a/buildtools/binutils-avx512-check.sh > +++ b/buildtools/binutils-avx512-check.sh > @@ -3,7 +3,7 @@ > # Copyright(c) 2020 Intel Corporation > > AS=${AS:-as} > -OBJFILE=$(mktemp -t dpdk.binutils-check.XXXXXX.o) > +OBJFILE=$(mktemp -t dpdk.binutils-check.XXXXXX) > trap 'rm -f "$OBJFILE"' EXIT > # from https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90028 > GATHER_PARAMS='0x8(,%ymm1,1),%ymm0{%k2}' > diff --git a/buildtools/check-symbols.sh b/buildtools/check-symbols.sh > index e407553a34..6723e38450 100755 > --- a/buildtools/check-symbols.sh > +++ b/buildtools/check-symbols.sh > @@ -18,7 +18,7 @@ then > exit 0 > fi > > -DUMPFILE=$(mktemp -t dpdk.${0##*/}.XXX.objdump) > +DUMPFILE=$(mktemp -t dpdk.${0##*/}.XXXXXX) Does it make sense to change it to DUMPFILE=$(mktemp -t dpdk.${0##*/}.objdump.XXXXXX) So we can preserve what the file is in the filename? > trap 'rm -f "$DUMPFILE"' EXIT > objdump -t $OBJFILE >$DUMPFILE > > diff --git a/buildtools/map-list-symbol.sh b/buildtools/map-list-symbol.sh > index 5509b4a7fa..3bf9bd66f8 100755 > --- a/buildtools/map-list-symbol.sh > +++ b/buildtools/map-list-symbol.sh > @@ -44,7 +44,7 @@ for file in $@; do > ret = 1; > } > } > - /^.*{/ { > + /^.*\{/ { > if ("'$section'" == "all" || $1 == "'$section'") { > current_section = $1; > } >