Re: [dpdk-dev] [PATCH v5 09/19] vhost: enable fds passing when sending vhost-user messages

[Maxime Coquelin <maxime.coquelin@redhat.com>]

On 10/10/2018 12:09 PM, Tiwei Bie wrote:
> On Tue, Oct 09, 2018 at 10:54:16PM +0200, Maxime Coquelin wrote:
>> Passing userfault fds to Qemu will be required for postcopy
>> live-migration feature.
>>
>> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>> ---
>>   lib/librte_vhost/vhost_user.c | 27 +++++++++++++++------------
>>   1 file changed, 15 insertions(+), 12 deletions(-)
>>
>> diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
>> index bce2395a3..99adcedfa 100644
>> --- a/lib/librte_vhost/vhost_user.c
>> +++ b/lib/librte_vhost/vhost_user.c
>> @@ -161,6 +161,7 @@ vhost_user_get_features(struct virtio_net **pdev, struct VhostUserMsg *msg,
>>   
>>   	msg->payload.u64 = features;
>>   	msg->size = sizeof(msg->payload.u64);
>> +	msg->fd_num = 0;
> 
> When message handlers in this file return VH_RESULT_REPLY,
> the msg->fd_num will be zeroed explicitly. Do we also want
> to do this in vhost_crypto_msg_post_handler()?

I think that would be better indeed.

>>   
>>   	return VH_RESULT_REPLY;
>>   }
> [...]
>