From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id A42931B450; Wed, 10 Oct 2018 12:27:05 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E280630820C1; Wed, 10 Oct 2018 10:27:04 +0000 (UTC) Received: from [10.36.112.48] (ovpn-112-48.ams2.redhat.com [10.36.112.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A976026348; Wed, 10 Oct 2018 10:26:59 +0000 (UTC) To: Tiwei Bie Cc: dev@dpdk.org, zhihong.wang@intel.com, jfreimann@redhat.com, nicknickolaev@gmail.com, i.maximets@samsung.com, bruce.richardson@intel.com, alejandro.lucero@netronome.com, dgilbert@redhat.com, stable@dpdk.org References: <20181009205426.21219-1-maxime.coquelin@redhat.com> <20181009205426.21219-10-maxime.coquelin@redhat.com> <20181010100928.GB2956@debian> From: Maxime Coquelin Message-ID: <13aa3971-31b8-7546-63a5-64b185e2d26b@redhat.com> Date: Wed, 10 Oct 2018 12:26:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181010100928.GB2956@debian> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Wed, 10 Oct 2018 10:27:05 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v5 09/19] vhost: enable fds passing when sending vhost-user messages X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Oct 2018 10:27:05 -0000 On 10/10/2018 12:09 PM, Tiwei Bie wrote: > On Tue, Oct 09, 2018 at 10:54:16PM +0200, Maxime Coquelin wrote: >> Passing userfault fds to Qemu will be required for postcopy >> live-migration feature. >> >> Signed-off-by: Dr. David Alan Gilbert >> Signed-off-by: Maxime Coquelin >> --- >> lib/librte_vhost/vhost_user.c | 27 +++++++++++++++------------ >> 1 file changed, 15 insertions(+), 12 deletions(-) >> >> diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c >> index bce2395a3..99adcedfa 100644 >> --- a/lib/librte_vhost/vhost_user.c >> +++ b/lib/librte_vhost/vhost_user.c >> @@ -161,6 +161,7 @@ vhost_user_get_features(struct virtio_net **pdev, struct VhostUserMsg *msg, >> >> msg->payload.u64 = features; >> msg->size = sizeof(msg->payload.u64); >> + msg->fd_num = 0; > > When message handlers in this file return VH_RESULT_REPLY, > the msg->fd_num will be zeroed explicitly. Do we also want > to do this in vhost_crypto_msg_post_handler()? I think that would be better indeed. >> >> return VH_RESULT_REPLY; >> } > [...] >