DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	Ivan Malov <ivan.malov@arknetworks.am>
Cc: stable@dpdk.org, Andy Moreton <amoreton@xilinx.com>, dev@dpdk.org
Subject: Re: [PATCH] net/sfc: invalidate switch port entry on representor unplug
Date: Mon, 13 Mar 2023 10:32:12 +0000	[thread overview]
Message-ID: <13c5d1a7-948d-6fec-e402-59d32344359d@amd.com> (raw)
In-Reply-To: <9e7ba4dd-c8b7-879b-fc2d-7b7a601277e1@oktetlabs.ru>

On 3/12/2023 7:28 AM, Andrew Rybchenko wrote:
> On 3/10/23 20:07, Ivan Malov wrote:
>> Once allocated, a switch port list entry always stays there,
>> even after unplugging the ethdev that created it. Currently,
>> the entry's ethdev ID is not cleared on unplug. Referencing
>> the ethdev ID of a detached representor from a flow rule is
>> going to succeed, which is a bug. Also, if the user unplugs
>> endpoint "A" representor and plugs one for "B" instead, the
>> latter will pick the same ethdev ID as the gone representor,
>> but it will have a new port list entry added for it. If the
>> user tries to reference the ethdev ID from a flow rule, the
>> code will fetch the wrong entry ("A" rather than "B") since
>> it sits closer to the list head. That is a serious bug, too.
>>
>> Make the driver invalidate ethdev ID field on ethdev unplug.
>>
>> Fixes: 1fb65e4dae8a ("net/sfc: support flow action port ID in transfer
>> rules")
>> Fixes: a62ec90522a6 ("net/sfc: add port representors infrastructure")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Ivan Malov <ivan.malov@arknetworks.am>
>> Reviewed-by: Andy Moreton <amoreton@xilinx.com>
> 
> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> 
> 

Applied to dpdk-next-net/main, thanks.

      reply	other threads:[~2023-03-13 10:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-10 17:07 Ivan Malov
2023-03-12  7:28 ` Andrew Rybchenko
2023-03-13 10:32   ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13c5d1a7-948d-6fec-e402-59d32344359d@amd.com \
    --to=ferruh.yigit@amd.com \
    --cc=amoreton@xilinx.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=ivan.malov@arknetworks.am \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).