From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id D6DE56CC7 for ; Thu, 28 Jun 2018 11:39:45 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jun 2018 02:39:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,282,1526367600"; d="scan'208";a="68002465" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.28]) ([10.237.220.28]) by fmsmga001.fm.intel.com with ESMTP; 28 Jun 2018 02:39:26 -0700 To: Qi Zhang , thomas@monjalon.net Cc: konstantin.ananyev@intel.com, dev@dpdk.org, bruce.richardson@intel.com, ferruh.yigit@intel.com, benjamin.h.shelton@intel.com, narender.vangati@intel.com, John McNamara References: <20180607123849.14439-1-qi.z.zhang@intel.com> <20180628015247.42232-1-qi.z.zhang@intel.com> <20180628015247.42232-20-qi.z.zhang@intel.com> From: "Burakov, Anatoly" Message-ID: <13c99537-a273-742a-ad6e-533eb7e36b33@intel.com> Date: Thu, 28 Jun 2018 10:39:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180628015247.42232-20-qi.z.zhang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 19/19] doc: update release notes for multi process hotplug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jun 2018 09:39:47 -0000 On 28-Jun-18 2:52 AM, Qi Zhang wrote: > Update release notes for the new multi process hotplug feature. > > Signed-off-by: Qi Zhang > --- +CC John Mc as our resident native English speaker :) > doc/guides/rel_notes/release_18_08.rst | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/doc/guides/rel_notes/release_18_08.rst b/doc/guides/rel_notes/release_18_08.rst > index bc0124295..fc4736814 100644 > --- a/doc/guides/rel_notes/release_18_08.rst > +++ b/doc/guides/rel_notes/release_18_08.rst > @@ -46,6 +46,20 @@ New Features > Flow API support has been added to CXGBE Poll Mode Driver to offload > flows to Chelsio T5/T6 NICs. > > +* **Support ethernet device hotplug for primary-secondary model.** > + > + In primary-secondary process model, ethernet devices are regarded as shared > + by default, attach or detach a device on any process will broadcast to > + other processes through mp channel then device information will be > + synchronzied on all processes. While secondary process can still attach > + or detach a private device (vdev only) with specific API. Suggested rewording: **Support ethdev multiprocess hotplug.** Hotplug and hot-unplug for ethdev devices will now be supported in multiprocessing scenario. Any ethdev devices created in the primary process will be regarded as shared and will be available for all DPDK processes, while secondary processes will have a choice between adding a private (non-shared) or a shared device. Synchronization between processes will be done using DPDK IPC. ------ I hope this is accurate enough, but please correct me if my interpretation of the changes is wrong! > + > +* **Support ethernet device lock.** > + > + An ethernet device can be directly or conditionally locked. A directly > + locked device can't be detached, while when try to detach a conditionally > + locked device a pre-registered callback will be invoked to perform condition > + check and decide if it can be detached or not. Suggested rewording: **Support ethernet device locking.** Application can now lock an ethernet device to prevent unexpected device removal. Devices can either be locked unconditionally, or an application can register for a callback before unplug for the purposes of performing cleanup before releasing the device (or have a chance to deny unplug). > > API Changes > ----------- > @@ -60,6 +74,13 @@ API Changes > Also, make sure to start the actual text at the margin. > ========================================================= > > +* ethdev: scope of rte_eth_dev_attach and rte_eth_dev_detach is extended. > + > + In primary-secondary process model, ``rte_eth_dev_attach`` will guarantee that > + device be attached on all processes, if any process failed to attach, it will > + rollback to orignal status. IMO no need to mention rollback - these are internal implementation details. The main thing is, the device is either attached everywhere, or attached nowhere. ``rte_eth_dev_detach`` also guarantee device be > + detached on all processes, if device is locked by any process, it will roll > + back to original status. Again, no need to mention internal implementation details - it would be sufficient to mention that rte_eth_dev_detach will only succeed if the device is not locked by any of the participating processes. > > ABI Changes > ----------- > -- Thanks, Anatoly