From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id A82D45F21 for ; Wed, 27 Mar 2019 12:14:37 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1AACD3082B4F; Wed, 27 Mar 2019 11:14:37 +0000 (UTC) Received: from [10.36.112.59] (ovpn-112-59.ams2.redhat.com [10.36.112.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E8E7719C7C; Wed, 27 Mar 2019 11:14:33 +0000 (UTC) To: Tiwei Bie , zhihong.wang@intel.com, dev@dpdk.org Cc: jfreimann@redhat.com References: <20190325052716.7730-1-tiwei.bie@intel.com> From: Maxime Coquelin Message-ID: <13d7d402-c5ae-2263-761b-8a0707bbb4f5@redhat.com> Date: Wed, 27 Mar 2019 12:14:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190325052716.7730-1-tiwei.bie@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Wed, 27 Mar 2019 11:14:37 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] net/virtio: define avail and used flags as constants X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Mar 2019 11:14:37 -0000 On 3/25/19 6:27 AM, Tiwei Bie wrote: > We are consistently passing 1 as the argument in the data path, > so there is no need to define avail/used flags as function-like > macros anymore. This patch changes the avail and used flags to > constants. And a frequently used combination is also introduced. > > Signed-off-by: Tiwei Bie > --- > drivers/net/virtio/virtio_ethdev.c | 10 ++++------ > drivers/net/virtio/virtio_ring.h | 9 +++++++-- > drivers/net/virtio/virtio_rxtx.c | 9 ++++----- > .../net/virtio/virtio_user/virtio_user_dev.c | 17 ++++++++++------- > drivers/net/virtio/virtqueue.h | 4 ++-- > 5 files changed, 27 insertions(+), 22 deletions(-) Applied to dpdk-next-virtio/master. Thanks, Maxime From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 339E2A05D3 for ; Wed, 27 Mar 2019 12:14:39 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0E2E95F44; Wed, 27 Mar 2019 12:14:39 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id A82D45F21 for ; Wed, 27 Mar 2019 12:14:37 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1AACD3082B4F; Wed, 27 Mar 2019 11:14:37 +0000 (UTC) Received: from [10.36.112.59] (ovpn-112-59.ams2.redhat.com [10.36.112.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E8E7719C7C; Wed, 27 Mar 2019 11:14:33 +0000 (UTC) To: Tiwei Bie , zhihong.wang@intel.com, dev@dpdk.org Cc: jfreimann@redhat.com References: <20190325052716.7730-1-tiwei.bie@intel.com> From: Maxime Coquelin Message-ID: <13d7d402-c5ae-2263-761b-8a0707bbb4f5@redhat.com> Date: Wed, 27 Mar 2019 12:14:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190325052716.7730-1-tiwei.bie@intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Wed, 27 Mar 2019 11:14:37 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] net/virtio: define avail and used flags as constants X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190327111432.Db-QtWr7zBtKzJvoCdhkZ-Xxtihcp-hBxbVw5cyXsWc@z> On 3/25/19 6:27 AM, Tiwei Bie wrote: > We are consistently passing 1 as the argument in the data path, > so there is no need to define avail/used flags as function-like > macros anymore. This patch changes the avail and used flags to > constants. And a frequently used combination is also introduced. > > Signed-off-by: Tiwei Bie > --- > drivers/net/virtio/virtio_ethdev.c | 10 ++++------ > drivers/net/virtio/virtio_ring.h | 9 +++++++-- > drivers/net/virtio/virtio_rxtx.c | 9 ++++----- > .../net/virtio/virtio_user/virtio_user_dev.c | 17 ++++++++++------- > drivers/net/virtio/virtqueue.h | 4 ++-- > 5 files changed, 27 insertions(+), 22 deletions(-) Applied to dpdk-next-virtio/master. Thanks, Maxime