DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] mk: allow updates to build config on make install
Date: Wed, 14 May 2014 11:22:35 +0100	[thread overview]
Message-ID: <1400062955-27338-1-git-send-email-bruce.richardson@intel.com> (raw)

There was an issue with rebuilding the code following a change to
one of the config files inside the "config" directory. If one did
a "make install T=<target>" and then made a modification to the
defconfig_<target> file (or applied a patch which modified that file)
a subsequent re-run of the make install command would not rebuild
the .config file leading to either build failures or an incorrect
build. This change fixes that issue.

Signed-off-by: Bruce Richardson<bruce.richardson@intel.com>
---
 mk/rte.sdkinstall.mk |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk
index 61a8771..00cb616 100644
--- a/mk/rte.sdkinstall.mk
+++ b/mk/rte.sdkinstall.mk
@@ -56,9 +56,7 @@ install: $(INSTALL_TARGETS)
 
 %_install:
 	@echo ================== Installing $*
-	$(Q)if [ ! -f $(BUILD_DIR)/$*/.config ]; then \
-		$(MAKE) config T=$* O=$(BUILD_DIR)/$*; \
-	fi
+	$(Q)$(MAKE) config T=$* O=$(BUILD_DIR)/$*
 	$(Q)$(MAKE) all O=$(BUILD_DIR)/$*
 
 #
-- 
1.7.0.7

             reply	other threads:[~2014-05-14 10:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-14 10:22 Bruce Richardson [this message]
2014-05-14 10:33 ` Thomas Monjalon
2014-05-14 10:51   ` Richardson, Bruce
2014-05-14 11:55     ` Thomas Monjalon
2014-05-14 12:33       ` Richardson, Bruce
2014-05-14 12:54         ` Thomas Monjalon
2014-05-14 12:57           ` Richardson, Bruce
2014-05-14 15:55 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
2014-05-20 11:37   ` Olivier MATZ
2014-06-10 13:51     ` [dpdk-dev] [PATCH v3] " Thomas Monjalon
2014-06-10 16:02       ` Olivier MATZ
2014-06-10 16:29         ` Richardson, Bruce
2014-06-10 16:38           ` [dpdk-dev] [PATCH v4] " Thomas Monjalon
2014-06-10 18:43             ` Richardson, Bruce
2014-06-11  9:54               ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1400062955-27338-1-git-send-email-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).