From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by dpdk.org (Postfix) with ESMTP id 0B767594F for ; Thu, 22 May 2014 05:35:19 +0200 (CEST) Received: from azsmga001.ch.intel.com ([10.2.17.19]) by azsmga101.ch.intel.com with ESMTP; 21 May 2014 20:35:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.98,884,1392192000"; d="scan'208";a="435337941" Received: from shilc102.sh.intel.com ([10.239.39.44]) by azsmga001.ch.intel.com with ESMTP; 21 May 2014 20:35:27 -0700 Received: from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com [10.239.29.89]) by shilc102.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP id s4M3ZM2g002991; Thu, 22 May 2014 11:35:24 +0800 Received: from shecgisg004.sh.intel.com (localhost [127.0.0.1]) by shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP id s4M3ZJxx006319; Thu, 22 May 2014 11:35:21 +0800 Received: (from hzhan75@localhost) by shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id s4M3ZIC2006315; Thu, 22 May 2014 11:35:18 +0800 From: Helin Zhang To: dev@dpdk.org Date: Thu, 22 May 2014 11:35:17 +0800 Message-Id: <1400729717-6195-1-git-send-email-helin.zhang@intel.com> X-Mailer: git-send-email 1.7.0.7 Subject: [dpdk-dev] [PATCH v2] kni: bug fix for compile issue in KNI on Fedora 18 with kernel 3.6.10 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 May 2014 03:35:20 -0000 Error of "implicit-function-declaration" can be seen when building KNI kernel module on Linux kernel 3.6.10 platform, as follows. "x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/igb_ethtool.c: In function \u2018igb_get_eee\u2019: x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/igb_ethtool.c: 2441:4: error: implicit declaration of function \u2018mmd_eee_adv_to_ethtool_adv_t\u2019 [-Werror=implicit-function-declaration] x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/igb_ethtool.c: In function \u2018igb_set_eee\u2019: x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/igb_ethtool.c: 2551:2: error: implicit declaration of function \u2018ethtool_adv_to_mmd_eee_adv_t\u2019 [-Werror=implicit-function-declaration]" The root cause is as follows. On Fedora 18 with kernel 3.6.10, ETHTOOL_GEEE is defined in Linux header file of "linux/ethtool.h", while is not defined in most of other linux kernel versions. mmd_eee_cap_to_ethtool_sup_t(), mmd_eee_adv_to_ethtool_adv_t() and ethtool_adv_to_mmd_eee_adv_t() in kcompat.h are disabled by "#if !defined(ETHTOOL_GEEE) || (RHEL_RELEASE_CODE && RHEL_RELEASE_CODE <= RHEL_RELEASE_VERSION(6,4))", while are called in igb_get_eee() in igb_ethtool.c which is enabled by "#ifdef ETHTOOL_GEEE". Signed-off-by: Helin Zhang --- lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h index e9e80ea..4c27d5d 100644 --- a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h +++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h @@ -3586,7 +3586,7 @@ static inline bool ether_addr_equal(const u8 *addr1, const u8 *addr2) #define ADVERTISED_40000baseLR4_Full (1 << 26) #endif -#if !defined(ETHTOOL_GEEE) || (RHEL_RELEASE_CODE && RHEL_RELEASE_CODE <= RHEL_RELEASE_VERSION(6,4)) +#if defined(ETHTOOL_GEEE) || (RHEL_RELEASE_CODE && RHEL_RELEASE_CODE <= RHEL_RELEASE_VERSION(6,4)) /** * mmd_eee_cap_to_ethtool_sup_t * @eee_cap: value of the MMD EEE Capability register -- 1.8.1.4