From: Vadim Suraev <vadim.suraev@gmail.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 0/2] timer bugs fixes
Date: Fri, 23 May 2014 22:43:02 +0300 [thread overview]
Message-ID: <1400874184-15818-1-git-send-email-vadim.suraev@gmail.com> (raw)
Vadim Suraev (2):
Bug: when a periodic timer's callback is running, if another
timer is manipulated, the periodic timer is not reloaded.
Solution: set the update flag only if the modified timer is
in RUNNING state
Bug: When a timer is running - if rte_timer_stop is called, the
pending decrement is skipped (decremented only if the timer
is pending) and due to the update flag the future processing
is skipped so the timer is counted as pending while it is
stopped. - the same applies when rte_timer_reset is called
but then the pending statistics is additionally incremented
so the timer is counted pending twice.
Solution:
decrement the pending statistics after returning from the
callback. If rte_timer_stop was called, it skipped
decrementing the pending statistics. If rte_time_reset was
called, the pending statistics was incremented. If neither
was called and the timer is periodic, the pending statistics
is incremented when it is reloaded
lib/librte_timer/rte_timer.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
--
1.7.9.5
next reply other threads:[~2014-05-23 19:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 19:43 Vadim Suraev [this message]
2014-05-23 19:43 ` [dpdk-dev] [PATCH 1/2] timer bug fix Vadim Suraev
2014-05-23 19:43 ` [dpdk-dev] [PATCH 2/2] " Vadim Suraev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400874184-15818-1-git-send-email-vadim.suraev@gmail.com \
--to=vadim.suraev@gmail.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).