DPDK patches and discussions
 help / color / mirror / Atom feed
From: Helin Zhang <helin.zhang@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v2 15/27] app/testpmd: enlarge the hash flags of RSS to 64 bits
Date: Thu,  5 Jun 2014 13:08:59 +0800	[thread overview]
Message-ID: <1401944951-23783-16-git-send-email-helin.zhang@intel.com> (raw)
In-Reply-To: <1401944951-23783-1-git-send-email-helin.zhang@intel.com>

As the hash flags of RSS has been enlarged from 16 bits to 64 bits in
'struct rte_eth_rss_conf' in rte_ethdev.h, the size of it in testpmd
should be enlarged as well. In addition, macro of ETH_RSS_IP is used
to replace all IP hash flags of RSS.

Signed-off-by: Helin Zhang <helin.zhang@intel.com>
Signed-off-by: Jing Chen <jing.d.chen@intel.com>
Acked-by: Cunming Liang <cunming.liang@intel.com>
Acked-by: Jijiang Liu <jijiang.liu@intel.com>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
Tested-by: Waterman Cao <waterman.cao@intel.com>
---
 app/test-pmd/cmdline.c    | 4 ++--
 app/test-pmd/parameters.c | 5 ++---
 app/test-pmd/testpmd.c    | 2 +-
 app/test-pmd/testpmd.h    | 2 +-
 4 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index ddb825d..fb52e89 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -1135,9 +1135,9 @@ cmd_config_rss_parsed(void *parsed_result,
 	uint8_t i;
 
 	if (!strcmp(res->value, "ip"))
-		rss_conf.rss_hf = ETH_RSS_IPV4 | ETH_RSS_IPV6;
+		rss_conf.rss_hf = ETH_RSS_IP;
 	else if (!strcmp(res->value, "udp"))
-		rss_conf.rss_hf = ETH_RSS_IPV4_UDP | ETH_RSS_IPV6_UDP;
+		rss_conf.rss_hf = ETH_RSS_UDP;
 	else if (!strcmp(res->value, "none"))
 		rss_conf.rss_hf = 0;
 	else {
diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
index 7a60048..725ca6f 100644
--- a/app/test-pmd/parameters.c
+++ b/app/test-pmd/parameters.c
@@ -832,10 +832,9 @@ launch_args_parse(int argc, char** argv)
 			if (!strcmp(lgopts[opt_idx].name, "forward-mode"))
 				set_pkt_forwarding_mode(optarg);
 			if (!strcmp(lgopts[opt_idx].name, "rss-ip"))
-				rss_hf = ETH_RSS_IPV4 | ETH_RSS_IPV6;
+				rss_hf = ETH_RSS_IP;
 			if (!strcmp(lgopts[opt_idx].name, "rss-udp"))
-				rss_hf = ETH_RSS_IPV4 |
-						ETH_RSS_IPV6 | ETH_RSS_IPV4_UDP;
+				rss_hf = ETH_RSS_UDP;
 			if (!strcmp(lgopts[opt_idx].name, "rxq")) {
 				n = atoi(optarg);
 				if (n >= 1 && n <= (int) MAX_QUEUE_ID)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index bc38305..eea2c6c 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -250,7 +250,7 @@ uint32_t txq_flags = 0; /* No flags set. */
 /*
  * Receive Side Scaling (RSS) configuration.
  */
-uint16_t rss_hf = ETH_RSS_IPV4 | ETH_RSS_IPV6; /* RSS IP by default. */
+uint64_t rss_hf = ETH_RSS_IP; /* RSS IP by default. */
 
 /*
  * Port topology configuration
diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
index c2b970e..f91f9cd 100644
--- a/app/test-pmd/testpmd.h
+++ b/app/test-pmd/testpmd.h
@@ -326,7 +326,7 @@ extern portid_t fwd_ports_ids[RTE_MAX_ETHPORTS];
 extern struct rte_port *ports;
 
 extern struct rte_eth_rxmode rx_mode;
-extern uint16_t rss_hf;
+extern uint64_t rss_hf;
 
 extern queueid_t nb_rxq;
 extern queueid_t nb_txq;
-- 
1.8.1.4

  parent reply	other threads:[~2014-06-05  5:11 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-05  5:08 [dpdk-dev] [PATCH v2 00/27] Add i40e PMD support Helin Zhang
2014-06-05  5:08 ` [dpdk-dev] [PATCH v2 01/27] i40e: add basic shared code Helin Zhang
2014-06-05  5:08 ` [dpdk-dev] [PATCH v2 02/27] i40e: add PMD source files Helin Zhang
2014-06-05  5:08 ` [dpdk-dev] [PATCH v2 03/27] pci: add macros and pci device IDs to support i40e Helin Zhang
2014-06-05  5:08 ` [dpdk-dev] [PATCH v2 04/27] igb_uio: add i40e support Helin Zhang
2014-06-05  5:08 ` [dpdk-dev] [PATCH v2 05/27] mbuf: add new packet flags for i40e Helin Zhang
2014-06-05 15:30   ` Stephen Hemminger
     [not found]     ` <F35DEAC7BCE34641BA9FAC6BCA4A12E70A735ACB@SHSMSX104.ccr.corp.intel.com>
2014-06-12  1:38       ` Zhang, Helin
2014-06-05  5:08 ` [dpdk-dev] [PATCH v2 06/27] ethdev: add i40e support Helin Zhang
2014-06-05  5:08 ` [dpdk-dev] [PATCH v2 07/27] ethdev: support setting maximum packet length to less than 1518 Helin Zhang
2014-06-05  5:08 ` [dpdk-dev] [PATCH v2 08/27] vmxnet3: enlarge the hash flags of RSS to 64 bits Helin Zhang
2014-06-05  5:08 ` [dpdk-dev] [PATCH v2 09/27] ixgbe: " Helin Zhang
2014-06-05  5:08 ` [dpdk-dev] [PATCH v2 10/27] igb: " Helin Zhang
2014-06-05  5:08 ` [dpdk-dev] [PATCH v2 11/27] mk: add i40e support Helin Zhang
2014-06-05  5:08 ` [dpdk-dev] [PATCH v2 12/27] config: add configurations for i40e Helin Zhang
2014-06-05  5:08 ` [dpdk-dev] [PATCH v2 13/27] app/test-pmd: support displaying 32 bytes RX descriptors Helin Zhang
2014-06-05  5:08 ` [dpdk-dev] [PATCH v2 14/27] app/test-pmd: add command of 'tx_vlan set pvid port_id vlan_id (on|off)' Helin Zhang
2014-06-05  5:08 ` Helin Zhang [this message]
2014-06-05  5:09 ` [dpdk-dev] [PATCH v2 16/27] app/test-pmd: add L3 packet type in offload flags Helin Zhang
2014-06-05  5:09 ` [dpdk-dev] [PATCH v2 17/27] examples/dpdk_qat: use ETH_RSS_IP to replace IP hash flags of RSS Helin Zhang
2014-06-05  5:09 ` [dpdk-dev] [PATCH v2 18/27] examples/ip_reassembly: " Helin Zhang
2014-06-05  5:09 ` [dpdk-dev] [PATCH v2 19/27] examples/l3fwd-power: " Helin Zhang
2014-06-05  5:09 ` [dpdk-dev] [PATCH v2 20/27] examples/l3fwd-vf: " Helin Zhang
2014-06-05  5:09 ` [dpdk-dev] [PATCH v2 21/27] examples/l3fwd: " Helin Zhang
2014-06-05  5:09 ` [dpdk-dev] [PATCH v2 22/27] examples/load_balancer: " Helin Zhang
2014-06-05  5:09 ` [dpdk-dev] [PATCH v2 23/27] examples/multi_process: " Helin Zhang
2014-06-05  5:09 ` [dpdk-dev] [PATCH v2 24/27] examples/qos_meter: " Helin Zhang
2014-06-05  5:09 ` [dpdk-dev] [PATCH v2 25/27] igb_uio: add sys files to read/write specific bits in pci config space Helin Zhang
2014-06-05  5:09 ` [dpdk-dev] [PATCH v2 26/27] pci: support reading/writing sys files of 'extended_tag' and 'max_read_request_size' Helin Zhang
2014-06-05  5:09 ` [dpdk-dev] [PATCH v2 27/27] config: add configurations for enabling 'Extended Tag' or resetting 'Max Read Request Size' Helin Zhang
2014-06-05  8:36 ` [dpdk-dev] [PATCH v2 00/27] Add i40e PMD support Zhu, Heqing
2014-06-17 16:27 ` Thomas Monjalon
2014-06-18  8:51   ` Zhang, Helin
2014-06-18  9:23     ` Thomas Monjalon
2014-06-19  6:24       ` Zhang, Helin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1401944951-23783-16-git-send-email-helin.zhang@intel.com \
    --to=helin.zhang@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).