From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id C4798B0BE for ; Tue, 17 Jun 2014 00:28:54 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 16 Jun 2014 15:29:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,489,1400050800"; d="scan'208";a="558492140" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by orsmga002.jf.intel.com with ESMTP; 16 Jun 2014 15:29:09 -0700 Received: from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com [10.237.217.46]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id s5GMT851008894; Mon, 16 Jun 2014 23:29:08 +0100 Received: from sivswdev02.ir.intel.com (localhost [127.0.0.1]) by sivswdev02.ir.intel.com with ESMTP id s5GMT8u2032295; Mon, 16 Jun 2014 23:29:08 +0100 Received: (from bricha3@localhost) by sivswdev02.ir.intel.com with id s5GMT8O3032291; Mon, 16 Jun 2014 23:29:08 +0100 From: Bruce Richardson To: dev@dpdk.org Date: Mon, 16 Jun 2014 23:29:05 +0100 Message-Id: <1402957745-31967-1-git-send-email-bruce.richardson@intel.com> X-Mailer: git-send-email 1.7.0.7 Subject: [dpdk-dev] [PATCH] vfio: make container open error non-fatal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jun 2014 22:28:55 -0000 When setting up an app to run using the uio driver, errors caused by VFIO failures should not abruptly cause the app to fail. Example: on a board with 8 ports bound to igb_uio module, and no VFIO configuration, a testpmd run currently fails with: EAL: cannot open VFIO container! EAL: 0000:04:00.0 cannot open VFIO container! EAL: Error - exiting with code: 1 Cause: Requested device 0000:04:00.0 cannot be used With this patch applied, the problem with VFIO is ignored and testpmd successfully starts up - with ignored errors with vfio - as below: EAL: PCI device 0000:04:00.0 on NUMA socket 0 EAL: probe driver: 8086:1521 rte_igb_pmd EAL: unknown IOMMU driver! EAL: 0000:04:00.0 cannot open VFIO container! EAL: 0000:04:00.0 not managed by UIO driver, skipping <...scan results for other ports skipped...> EAL: PCI device 0000:8e:00.0 on NUMA socket 1 EAL: probe driver: 8086:154a rte_ixgbe_pmd EAL: unknown IOMMU driver! EAL: 0000:8e:00.0 cannot open VFIO container! EAL: PCI memory mapped at 0x7ff4ff5fa000 EAL: PCI memory mapped at 0x7ff4ff5f6000 EAL: PCI device 0000:8e:00.1 on NUMA socket 1 EAL: probe driver: 8086:154a rte_ixgbe_pmd EAL: unknown IOMMU driver! EAL: 0000:8e:00.1 cannot open VFIO container! EAL: PCI memory mapped at 0x7ff4ff4f6000 EAL: PCI memory mapped at 0x7ff4ff4f2000 Interactive-mode selected Configuring Port 0 (socket 0) <...other 7 ports ...> Checking link statuses... Port 0 Link Up - speed 10000 Mbps - full-duplex Port 1 Link Down Port 2 Link Up - speed 10000 Mbps - full-duplex Port 3 Link Down Port 4 Link Up - speed 10000 Mbps - full-duplex Port 5 Link Down Port 6 Link Up - speed 10000 Mbps - full-duplex Port 7 Link Down Done testpmd> This issue is introduced by the VFIO patch set addition, specifically commit ff0b67d1. Signed-off-by: Bruce Richardson --- lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c index 4de6061..4af38f6 100644 --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c @@ -528,7 +528,7 @@ pci_vfio_map_resource(struct rte_pci_device *dev) int vfio_container_fd = pci_vfio_get_container_fd(); if (vfio_container_fd < 0) { RTE_LOG(ERR, EAL, " %s cannot open VFIO container!\n", pci_addr); - return -1; + return 1; } vfio_cfg.vfio_container_fd = vfio_container_fd; -- 1.9.3