From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by dpdk.org (Postfix) with ESMTP id 835E8B0B4 for ; Fri, 20 Jun 2014 08:14:48 +0200 (CEST) Received: from azsmga001.ch.intel.com ([10.2.17.19]) by azsmga101.ch.intel.com with ESMTP; 19 Jun 2014 23:15:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,512,1400050800"; d="scan'208";a="447831336" Received: from shvmail01.sh.intel.com ([10.239.29.42]) by azsmga001.ch.intel.com with ESMTP; 19 Jun 2014 23:15:04 -0700 Received: from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com [10.239.29.89]) by shvmail01.sh.intel.com with ESMTP id s5K6F2c4018839; Fri, 20 Jun 2014 14:15:02 +0800 Received: from shecgisg004.sh.intel.com (localhost [127.0.0.1]) by shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP id s5K6EwsH023799; Fri, 20 Jun 2014 14:15:00 +0800 Received: (from hzhan75@localhost) by shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id s5K6Ewme023786; Fri, 20 Jun 2014 14:14:58 +0800 From: Helin Zhang To: dev@dpdk.org Date: Fri, 20 Jun 2014 14:14:45 +0800 Message-Id: <1403244889-21358-4-git-send-email-helin.zhang@intel.com> X-Mailer: git-send-email 1.7.0.7 In-Reply-To: <1403244889-21358-1-git-send-email-helin.zhang@intel.com> References: <1403244889-21358-1-git-send-email-helin.zhang@intel.com> Subject: [dpdk-dev] [PATCH 3/7] i40e: ignore the failure of updating default filter settings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jun 2014 06:14:49 -0000 The failure of updating the default filter setting should be ignored. The updating is to change the default vlan filter behaviours configured by firmware to expected. The failure happens on the firmware version of 4.2.2, while doesn't happen on previous versions, as the default settings of firmware changed. Signed-off-by: Helin Zhang Acked-by: Cunming Liang Acked-by: Jing Chen --- lib/librte_pmd_i40e/i40e_ethdev.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c index a335242..102a206 100644 --- a/lib/librte_pmd_i40e/i40e_ethdev.c +++ b/lib/librte_pmd_i40e/i40e_ethdev.c @@ -2473,13 +2473,14 @@ i40e_vsi_setup(struct i40e_pf *pf, (void)rte_memcpy(pf->dev_addr.addr_bytes, hw->mac.perm_addr, ETH_ADDR_LEN); ret = i40e_update_default_filter_setting(vsi); - if (ret != I40E_SUCCESS) { - PMD_DRV_LOG(ERR, "Failed to remove default " - "filter setting\n"); - goto fail_msix_alloc; - } - } - else if (type == I40E_VSI_SRIOV) { + if (ret != I40E_SUCCESS) + PMD_DRV_LOG(ERR, "Failure of removing default filter " + "setting can be ignored\n"); + /** + * The failure of updating default filter setting + * can be ignored + */ + } else if (type == I40E_VSI_SRIOV) { memset(&ctxt, 0, sizeof(ctxt)); /** * For other VSI, the uplink_seid equals to uplink VSI's -- 1.8.1.4