From: Robert Sanford <rsanford2@gmail.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v3 0/2] malloc: fix malloc and free linear complexity
Date: Mon, 23 Jun 2014 17:17:08 -0400 [thread overview]
Message-ID: <1403558230-40042-1-git-send-email-rsanford2@gmail.com> (raw)
In-Reply-To: <1400245141-10938-1-git-send-email-rsanford2@gmail.com>
Comments on previous versions of this patch:
http://dpdk.org/ml/archives/dev/2014-May/002297.html
http://dpdk.org/ml/archives/dev/2014-June/003518.html
Additional changes from original to v3:
* Reduce the minimum-sized block that we put on a free list when
splitting a larger block, from 192 to 64. Although memory is
plentiful, why waste 64 and 128-byte (plus overhead) blocks?
-#define MIN_DATA_SIZE (CACHE_LINE_SIZE * 2)
+#define MIN_DATA_SIZE (CACHE_LINE_SIZE)
- if (old_elem_size <= MALLOC_ELEM_OVERHEAD + MIN_DATA_SIZE){
+ if (old_elem_size < MALLOC_ELEM_OVERHEAD + MIN_DATA_SIZE){
- if (elem->size - new_size > MIN_DATA_SIZE + MALLOC_ELEM_OVERHEAD){
+ if (elem->size - new_size >= MIN_DATA_SIZE + MALLOC_ELEM_OVERHEAD){
Changes from v2 to v3:
* Change the size ranges of the five free lists per heap. The first
list will effectively contain blocks of size [64,256].
- * heap->free_head[0] - (0 , 2^7]
- * heap->free_head[1] - (2^7 , 2^9]
- * heap->free_head[2] - (2^9 , 2^11]
- * heap->free_head[3] - (2^11, 2^13]
- * heap->free_head[4] - (2^13, MAX_SIZE]
+ * heap->free_head[0] - (0 , 2^8]
+ * heap->free_head[1] - (2^8 , 2^10]
+ * heap->free_head[2] - (2^10 ,2^12]
+ * heap->free_head[3] - (2^12, 2^14]
+ * heap->free_head[4] - (2^14, MAX_SIZE]
- #define MALLOC_MINSIZE_LOG2 7
+ #define MALLOC_MINSIZE_LOG2 8
* Fix typos and false assumptions in malloc unit tests. Even without
linked-list enhancements to lib rte_malloc, malloc autotest fails
every second (2nd) run.
next prev parent reply other threads:[~2014-06-23 21:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 12:59 [dpdk-dev] [PATCH v2] " rsanford2
2014-06-17 16:05 ` De Lara Guarch, Pablo
2014-06-17 16:29 ` Robert Sanford
2014-06-23 21:17 ` Robert Sanford [this message]
2014-06-24 14:55 ` [dpdk-dev] [PATCH v3 0/2] " De Lara Guarch, Pablo
2014-06-26 12:37 ` Thomas Monjalon
2014-06-23 21:17 ` [dpdk-dev] [PATCH v3 1/2] " Robert Sanford
2014-06-23 21:17 ` [dpdk-dev] [PATCH v3 2/2] " Robert Sanford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403558230-40042-1-git-send-email-rsanford2@gmail.com \
--to=rsanford2@gmail.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).